From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 571F2C433EF for ; Thu, 2 Dec 2021 20:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349054AbhLBVBd (ORCPT ); Thu, 2 Dec 2021 16:01:33 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:57282 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239259AbhLBVBX (ORCPT ); Thu, 2 Dec 2021 16:01:23 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8F893B82496 for ; Thu, 2 Dec 2021 20:57:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36C87C00446; Thu, 2 Dec 2021 20:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638478678; bh=Vz6b7cV6W7mHrkub6Y7jYpgSpo5eJxuDHXnlPbz4LNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fXPOryibPB4GoekQqhs51X824Hb23aNOfD7mGBKqe6Hu6RzWw5T071AObNQ17Hy1n As73CwWovUvU0+tWTRCPqpC6ePAJ8F8bXqjo/SKNrWyGy1F8dz8Sz2NJ81+Zh/Agbo +Tij6tayDHR4WR7xDf2VIWcfLVSwhbnP+NWrqTZEtS1Xi1GBURQTTwZw7vr1UsUH5+ b3AtyA8aQJO3EJk4WLq/cIoPOz5J8RLmnroaw2NcaygK5YD+chrkCraQBDqn0Kus+/ gy8snUZjtbMkXV2ABwdI7JTDxRsAcYDD2np7CNuRwO+CL6HQDuD/wwbQuQCsK5hWLY 2JlgQdbVXtpqg== Date: Thu, 2 Dec 2021 12:57:56 -0800 From: Eric Biggers To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Message-ID: References: <20211116214510.2934905-1-jaegeuk@kernel.org> <20211116214510.2934905-5-jaegeuk@kernel.org> <1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: > On 12/02, Jaegeuk Kim wrote: > > On 12/02, Eric Biggers wrote: > > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > > > On 2021/12/2 12:15, Eric Biggers wrote: > > > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > > > > Why not relocating this check before f2fs_map_blocks()? > > > > > > > > Wait, it supports DIO in multi-device image after commit 71f2c8206202 > > > > ("f2fs: multidevice: support direct IO"), how about > > > > checking with f2fs_allow_multi_device_dio()? > > > > > > > > Thanks, > > > > > > > > > > Okay, that was not the case when I sent this patch originally. We'll need to > > > update this to support multiple devices. > > > > Chao/Eric, does this make sense? > > > > --- a/fs/f2fs/data.c > > +++ b/fs/f2fs/data.c > > @@ -4070,11 +4070,10 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, > > } > > if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk))) > > return -EINVAL; > > - iomap->addr = blks_to_bytes(inode, map.m_pblk); > > > > - if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode)))) > > - return -EINVAL; > > - iomap->bdev = inode->i_sb->s_bdev; > > + iomap->bdev = map->m_multidev_dio ? map.m_bdev : > > correction: map.m_multidev_dio > I guess so, but why doesn't f2fs_map_blocks() just always set m_bdev to the correct block device? What is the point of m_multidev_dio? - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11D54C433EF for ; Thu, 2 Dec 2021 20:58:15 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mst9i-0005In-TL; Thu, 02 Dec 2021 20:58:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mst9h-0005Ig-Rj for linux-f2fs-devel@lists.sourceforge.net; Thu, 02 Dec 2021 20:58:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LGiYNtlAJ3/C4WZvkDDI/LfgJEtbI/MoLNQfnsOYzJE=; b=J/nKNVpCAZ8wIvcP9ZHj7cyrKl 1W+EitInSB+sYFOD2YtjRhbd8oAfHzQ3rRHz/47T78+flIn3ysJqLIgQg7fgZeUGXqIrFiDZ43/To XcZ7EeexdzJBAtH7wkR6p2Fi+WWXq4RdrT7jxAh3PgVfVbE8vR8eTmkvHxPwGbIjJe6U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LGiYNtlAJ3/C4WZvkDDI/LfgJEtbI/MoLNQfnsOYzJE=; b=Ga4IUejJeQsKReVbEP8O/uhZot ptWMTUg1eU1BEvDgQWicgCNX71xX1LuY/TXUfjYrvzZc3YecDteaaRjHbxdwv8I6gNY0NW0Q/K9gS FDJ5X09sR1IQ9ujQj3oG6hzSBMeVe0D4nHPDAcPF5cQNKXclJYbBzlBxoFR0w0zUz9os=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mst9g-001vRq-Ak for linux-f2fs-devel@lists.sourceforge.net; Thu, 02 Dec 2021 20:58:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DCD2262822 for ; Thu, 2 Dec 2021 20:57:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36C87C00446; Thu, 2 Dec 2021 20:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638478678; bh=Vz6b7cV6W7mHrkub6Y7jYpgSpo5eJxuDHXnlPbz4LNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fXPOryibPB4GoekQqhs51X824Hb23aNOfD7mGBKqe6Hu6RzWw5T071AObNQ17Hy1n As73CwWovUvU0+tWTRCPqpC6ePAJ8F8bXqjo/SKNrWyGy1F8dz8Sz2NJ81+Zh/Agbo +Tij6tayDHR4WR7xDf2VIWcfLVSwhbnP+NWrqTZEtS1Xi1GBURQTTwZw7vr1UsUH5+ b3AtyA8aQJO3EJk4WLq/cIoPOz5J8RLmnroaw2NcaygK5YD+chrkCraQBDqn0Kus+/ gy8snUZjtbMkXV2ABwdI7JTDxRsAcYDD2np7CNuRwO+CL6HQDuD/wwbQuQCsK5hWLY 2JlgQdbVXtpqg== Date: Thu, 2 Dec 2021 12:57:56 -0800 From: Eric Biggers To: Jaegeuk Kim Message-ID: References: <20211116214510.2934905-1-jaegeuk@kernel.org> <20211116214510.2934905-5-jaegeuk@kernel.org> <1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1mst9g-001vRq-Ak Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: > On 12/02, Jaegeuk Kim wrote: > > On 12/02, Eric Biggers wrote: > > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > > > On 2021/12/2 12:15, Eric Biggers wrote: > > > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > > > > Why not relocating this check before f2fs_map_blocks()? > > > > > > > > Wait, it supports DIO in multi-device image after commit 71f2c8206202 > > > > ("f2fs: multidevice: support direct IO"), how about > > > > checking with f2fs_allow_multi_device_dio()? > > > > > > > > Thanks, > > > > > > > > > > Okay, that was not the case when I sent this patch originally. We'll need to > > > update this to support multiple devices. > > > > Chao/Eric, does this make sense? > > > > --- a/fs/f2fs/data.c > > +++ b/fs/f2fs/data.c > > @@ -4070,11 +4070,10 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, > > } > > if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk))) > > return -EINVAL; > > - iomap->addr = blks_to_bytes(inode, map.m_pblk); > > > > - if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode)))) > > - return -EINVAL; > > - iomap->bdev = inode->i_sb->s_bdev; > > + iomap->bdev = map->m_multidev_dio ? map.m_bdev : > > correction: map.m_multidev_dio > I guess so, but why doesn't f2fs_map_blocks() just always set m_bdev to the correct block device? What is the point of m_multidev_dio? - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel