From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BE6C433F5 for ; Fri, 3 Dec 2021 12:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352089AbhLCMaL (ORCPT ); Fri, 3 Dec 2021 07:30:11 -0500 Received: from mga04.intel.com ([192.55.52.120]:8019 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236481AbhLCMaK (ORCPT ); Fri, 3 Dec 2021 07:30:10 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="235700117" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="235700117" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="678082863" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mt7d5-001lPG-5I; Fri, 03 Dec 2021 14:25:31 +0200 Date: Fri, 3 Dec 2021 14:25:30 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Marc Zyngier , Matti Vaittinen , Sergio Paracuellos , Chunyan Zhang , Baruch Siach , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Tony Lindgren , Nicolas Saenz Julienne , Linus Walleij , Jianqun Xu , Alexandru Ardelean , Thierry Reding , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , patches@opensource.cirrus.com, bcm-kernel-feedback-list , linux-power , Linux ARM , "moderated list:ARM/Mediatek SoC..." , linux-pwm@vger.kernel.org, Linux-OMAP , linux-unisoc@lists.infradead.org, "open list:ARM/Rockchip SoC..." , linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, Ray Jui , Florian Fainelli , Scott Branden , Gregory Fong , Eugeniy Paltsev , Keerthy , Orson Zhai , Baolin Wang , Chunyan Zhang , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Lee Jones , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Manivannan Sadhasivam , Heiko Stuebner , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Jonathan Hunter Subject: Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211202210839.79140-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Fri, Dec 03, 2021 at 09:40:55AM +0100, Bartosz Golaszewski wrote: > On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko > wrote: > > > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > > > Signed-off-by: Andy Shevchenko > > --- > > I have a bad feeling about this but I've gone through the drivers in > this patch and it seems like you don't update any of the drivers that > use multiple child OF nodes so I can't really point out any obvious > bug. Yes, like I said it's just a series to kick off the conversion. I left the corner cases to the last. > I have another change I'm working on that's related, let me send it shortly. Do you mean it should be attached to the series? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21520C433F5 for ; Fri, 3 Dec 2021 12:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NuwhhUcIoGS8Uu/SCAcFT46spTTNW0zR7xVrTlqU17k=; b=hXGRytKDgAnW/c KjWeGJcjaURuWMJDdoXbTgh2qXzwKv/76JSKsgwJBCFW12XizSdS4V2fkt6HyqfTKhqfXbgAc2gYT F9REsHeOqJxPKhoW6kJYXkqp6Cl90FygzeoVHPkvu1Il8tvz7GeZctcXH1aQdv9k/RECyrhAUpvzv LqPkNjIXiD5HgQCe6VQziQ/Ok7iqr0a086Pd1qe2rskHUP36uEdt2+G/TJG9x6W6gLuU0/0sGbx+R kfJRutUHhiWTfaO5TeEQWA4z1ObhwCiHPj7bFZ90MvHDiRAM0kdpylfrUFYqB4WKzNaX1A/w2BGD/ AxZc1Ro6EJ9iIVGA3uWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mt7eq-00FiiV-28; Fri, 03 Dec 2021 12:27:20 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mt7eJ-00FiXm-P9; Fri, 03 Dec 2021 12:26:49 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="223839592" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="223839592" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="678082863" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mt7d5-001lPG-5I; Fri, 03 Dec 2021 14:25:31 +0200 Date: Fri, 3 Dec 2021 14:25:30 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Marc Zyngier , Matti Vaittinen , Sergio Paracuellos , Chunyan Zhang , Baruch Siach , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Tony Lindgren , Nicolas Saenz Julienne , Linus Walleij , Jianqun Xu , Alexandru Ardelean , Thierry Reding , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , patches@opensource.cirrus.com, bcm-kernel-feedback-list , linux-power , Linux ARM , "moderated list:ARM/Mediatek SoC..." , linux-pwm@vger.kernel.org, Linux-OMAP , linux-unisoc@lists.infradead.org, "open list:ARM/Rockchip SoC..." , linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, Ray Jui , Florian Fainelli , Scott Branden , Gregory Fong , Eugeniy Paltsev , Keerthy , Orson Zhai , Baolin Wang , Chunyan Zhang , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Lee Jones , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Manivannan Sadhasivam , Heiko Stuebner , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Jonathan Hunter Subject: Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211202210839.79140-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211203_042647_910202_73B35ADA X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Dec 03, 2021 at 09:40:55AM +0100, Bartosz Golaszewski wrote: > On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko > wrote: > > > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > > > Signed-off-by: Andy Shevchenko > > --- > > I have a bad feeling about this but I've gone through the drivers in > this patch and it seems like you don't update any of the drivers that > use multiple child OF nodes so I can't really point out any obvious > bug. Yes, like I said it's just a series to kick off the conversion. I left the corner cases to the last. > I have another change I'm working on that's related, let me send it shortly. Do you mean it should be attached to the series? -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22B50C433EF for ; Fri, 3 Dec 2021 12:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w+xMSpUt2oae7bY4BgP41WQqm0Zy2TM6AzDFsA04vaY=; b=sy1PY35gD2GJ+l MpBd24selYpPYPqPC/bytWHistJ/24Va+Wol/+Sa+ZVwdVGuo/gPUnK+xn2cCAJ0/cX6nN9kX4Byu ZB4bJ+HPcS16brFMA3Fr8NRoNhX8+rO/h4wcsezYhPCFd9er2Ysul2hwmEcAJncQQm7JoYUbUzOyB yRzRxODy2Vy4zn7TyacAkE3Lgmg5jULwWfB0IVCWLCt+QwVbqe4GSoVQGoe9Xzk7k1HDN00YM4WM1 monf/AYpcBRd9UVd9D003IMETF/cGNQ0IZcid5BJp++j2f7SVkClUCULydp5P6hEO0M7VadqJ4Hth oYMGYt0HEf0N1R3W6Fqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mt7em-00Figi-Da; Fri, 03 Dec 2021 12:27:16 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mt7eJ-00FiXm-P9; Fri, 03 Dec 2021 12:26:49 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="223839592" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="223839592" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="678082863" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mt7d5-001lPG-5I; Fri, 03 Dec 2021 14:25:31 +0200 Date: Fri, 3 Dec 2021 14:25:30 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Marc Zyngier , Matti Vaittinen , Sergio Paracuellos , Chunyan Zhang , Baruch Siach , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Tony Lindgren , Nicolas Saenz Julienne , Linus Walleij , Jianqun Xu , Alexandru Ardelean , Thierry Reding , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , patches@opensource.cirrus.com, bcm-kernel-feedback-list , linux-power , Linux ARM , "moderated list:ARM/Mediatek SoC..." , linux-pwm@vger.kernel.org, Linux-OMAP , linux-unisoc@lists.infradead.org, "open list:ARM/Rockchip SoC..." , linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, Ray Jui , Florian Fainelli , Scott Branden , Gregory Fong , Eugeniy Paltsev , Keerthy , Orson Zhai , Baolin Wang , Chunyan Zhang , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Lee Jones , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Manivannan Sadhasivam , Heiko Stuebner , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Jonathan Hunter Subject: Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211202210839.79140-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211203_042647_910202_73B35ADA X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Dec 03, 2021 at 09:40:55AM +0100, Bartosz Golaszewski wrote: > On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko > wrote: > > > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > > > Signed-off-by: Andy Shevchenko > > --- > > I have a bad feeling about this but I've gone through the drivers in > this patch and it seems like you don't update any of the drivers that > use multiple child OF nodes so I can't really point out any obvious > bug. Yes, like I said it's just a series to kick off the conversion. I left the corner cases to the last. > I have another change I'm working on that's related, let me send it shortly. Do you mean it should be attached to the series? -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C8C5C4332F for ; Fri, 3 Dec 2021 12:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kKDfWAHGGOmsMWknU4m3jaOV0ZjIpWxt2OGLzGmI3gU=; b=dUKlhWOxauNBYQ 1qLS67KkDd68G5M9KPAK3YRCIUphOUmL2ZD+NOrU3WoxhujqDDJ07wSr8Z4A0y7vWmj4tuyEPLdu6 2bmazEGtzCVf2Rbbz0P6vDNdcvFUQKF3+zBbLARl0QZlPN82utIOc7kXYcRoPhdsKtaM22fbIa0x8 i17BZTxXUqQZppO1DVjYx3dhvQxvmHrR9JAkaP7mLMtBg5lluop6MheENy+I4IKXDJyj/D7TdP0yV Ag8A2emrZw4Ymyu70Sjb+fAXCeiZsaK7YCBbuFRDvyLybhbMf6m+GQf6tfMnWZ61qDGW6JvqWCnEC /ArLi/YdubJ61EHA7euQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mt7eY-00Fiay-K8; Fri, 03 Dec 2021 12:27:03 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mt7eJ-00FiXm-P9; Fri, 03 Dec 2021 12:26:49 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="223839592" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="223839592" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="678082863" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mt7d5-001lPG-5I; Fri, 03 Dec 2021 14:25:31 +0200 Date: Fri, 3 Dec 2021 14:25:30 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Marc Zyngier , Matti Vaittinen , Sergio Paracuellos , Chunyan Zhang , Baruch Siach , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Tony Lindgren , Nicolas Saenz Julienne , Linus Walleij , Jianqun Xu , Alexandru Ardelean , Thierry Reding , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , patches@opensource.cirrus.com, bcm-kernel-feedback-list , linux-power , Linux ARM , "moderated list:ARM/Mediatek SoC..." , linux-pwm@vger.kernel.org, Linux-OMAP , linux-unisoc@lists.infradead.org, "open list:ARM/Rockchip SoC..." , linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, Ray Jui , Florian Fainelli , Scott Branden , Gregory Fong , Eugeniy Paltsev , Keerthy , Orson Zhai , Baolin Wang , Chunyan Zhang , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Lee Jones , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Manivannan Sadhasivam , Heiko Stuebner , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Jonathan Hunter Subject: Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211202210839.79140-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211203_042647_910202_73B35ADA X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 03, 2021 at 09:40:55AM +0100, Bartosz Golaszewski wrote: > On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko > wrote: > > > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > > > Signed-off-by: Andy Shevchenko > > --- > > I have a bad feeling about this but I've gone through the drivers in > this patch and it seems like you don't update any of the drivers that > use multiple child OF nodes so I can't really point out any obvious > bug. Yes, like I said it's just a series to kick off the conversion. I left the corner cases to the last. > I have another change I'm working on that's related, let me send it shortly. Do you mean it should be attached to the series? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel