From: Fernando Ramos <greenfoo@u92.eu>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, davvid@gmail.com,
sunshine@sunshineco.com, seth@eseth.com,
levraiphilippeblain@gmail.com, rogi@skylittlesystem.org
Subject: Re: [PATCH v3 2/3] vimdiff: add tool documentation
Date: Sat, 4 Dec 2021 09:31:58 +0100 [thread overview]
Message-ID: <YasnfjKqEmI+7rLG@zacax395.localdomain> (raw)
In-Reply-To: <211201.86ee6w9fq8.gmgdl@evledraar.gmail.com>
On 21/12/01 10:27PM, Ævar Arnfjörð Bjarmason wrote:
>
> > +merge_cmd_help() {
> > + case "$1" in
> > + *)
> > + echo "Run 'man git-mergetool--vimdiff' for details"
> > + ;;
> > + esac
> > +
> > + return 0
> > +}
> > +
> > +
>
> Isn't the case/esac in those functions entirely redundant and they could
> just "echo"?
Yes, I originally left it here in case we wanted to print different messages for
different variants (vimdiff, vimdiff2, ...).
But now that the documentation has been placed into a single file, I don't see
a reason to keep this. I'll remove it. Thanks for noticing.
next prev parent reply other threads:[~2021-12-04 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 20:43 [PATCH v3 0/3] vimdiff: new implementation with layout support Fernando Ramos
2021-11-30 20:43 ` [PATCH v3 1/3] " Fernando Ramos
2021-11-30 20:43 ` [PATCH v3 2/3] vimdiff: add tool documentation Fernando Ramos
2021-12-01 21:27 ` Ævar Arnfjörð Bjarmason
2021-12-04 8:31 ` Fernando Ramos [this message]
2021-11-30 20:43 ` [PATCH v3 3/3] vimdiff: integrate layout tests in the unit tests framework ('t' folder) Fernando Ramos
2021-12-01 21:25 ` Ævar Arnfjörð Bjarmason
2021-12-01 5:03 ` [PATCH v3 0/3] vimdiff: new implementation with layout support Eric Sunshine
2021-12-01 18:49 ` Fernando Ramos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YasnfjKqEmI+7rLG@zacax395.localdomain \
--to=greenfoo@u92.eu \
--cc=avarab@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=levraiphilippeblain@gmail.com \
--cc=rogi@skylittlesystem.org \
--cc=seth@eseth.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.