From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C3CC433EF for ; Wed, 8 Dec 2021 21:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237581AbhLHVzx (ORCPT ); Wed, 8 Dec 2021 16:55:53 -0500 Received: from cloud.peff.net ([104.130.231.41]:47118 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234407AbhLHVzx (ORCPT ); Wed, 8 Dec 2021 16:55:53 -0500 Received: (qmail 11426 invoked by uid 109); 8 Dec 2021 21:52:21 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 08 Dec 2021 21:52:21 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 8226 invoked by uid 111); 8 Dec 2021 21:52:20 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 08 Dec 2021 16:52:20 -0500 Authentication-Results: peff.net; auth=none Date: Wed, 8 Dec 2021 16:52:19 -0500 From: Jeff King To: Junio C Hamano Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Elijah Newren , Johannes Schindelin via GitGitGadget , Git Mailing List , Derrick Stolee , Eric Sunshine , Bagas Sanjaya , Theodore Ts'o , Matt Rogers , Johannes Schindelin Subject: Re: [RFC/PATCH] Makefile: add test-all target Message-ID: References: <211207.86ilw0matb.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Dec 08, 2021 at 12:04:50PM -0800, Junio C Hamano wrote: > > That is an interesting way to demonstrate how orthogonal the issues > > are, which in turn means that it is not such a big deal to add back > > the coverage to the part that goes to contrib/scalar/. As the actual > > implementation, it is a bit too icky, though. > > So, how about doing it this way? This is based on 'master' and does > not cover contrib/scalar, but if we want to go this route, it should > be trivial to do it on top of a merge of ab/ci-updates and js/scalar > into 'master'. Good idea? Terrible idea? Not good enough? I don't mind the general direction, but... > +# Additional tests from places in contrib/ that are prepared to take > +# "make -C $there test", but expects that the primary build is done > +# already. > +test-extra: all > + $(MAKE) -C contrib/diff-highlight test > + $(MAKE) -C contrib/mw-to-git test > + $(MAKE) -C contrib/subtree test I'm not sure of the quality of tests in some of the contrib stuff. The tests in diff-highlight worked for me when I added them, but it's not like I ever run them regularly, or that they've been tested on a wide variety of platforms. So I think this is as likely to cause somebody a headache due to a dumb portability problem or random bitrot as it is to actually find a bug. I guess test-extra wouldn't be run by default, but only via CI, so maybe that limits the blast radius sufficiently. For diff-highlight in particular, you need to have a working perl, so you'd probably want to at least wrap it with a NO_PERL ifndef. For mw-to-git, you need to have MediaWiki::API installed, though I think the tests at least notice this and skip everything if you don't. -Peff