From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH 3/6] libxtables: Add xtables_exit_tryhelp()
Date: Thu, 9 Dec 2021 01:37:40 +0100 [thread overview]
Message-ID: <YbFP1PI+NSUD238i@salvia> (raw)
In-Reply-To: <20211209002257.21467-4-phil@nwl.cc>
On Thu, Dec 09, 2021 at 01:22:54AM +0100, Phil Sutter wrote:
> This is just the exit_tryhelp() function which existed three times in
> identical form with a more suitable name.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> include/xtables.h | 1 +
> iptables/ip6tables.c | 19 ++++---------------
> iptables/iptables.c | 19 ++++---------------
> iptables/xtables.c | 21 +++++----------------
> libxtables/xtables.c | 10 ++++++++++
> 5 files changed, 24 insertions(+), 46 deletions(-)
>
> diff --git a/include/xtables.h b/include/xtables.h
> index ca674c2663eb4..fdf77d83199d0 100644
> --- a/include/xtables.h
> +++ b/include/xtables.h
> @@ -501,6 +501,7 @@ xtables_parse_interface(const char *arg, char *vianame, unsigned char *mask);
>
> extern struct xtables_globals *xt_params;
> #define xtables_error (xt_params->exit_err)
> +extern void xtables_exit_tryhelp(int status) __attribute__((noreturn));
Probably add this to xshared.c instead of libxtables?
next prev parent reply other threads:[~2021-12-09 0:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 0:22 [iptables PATCH 0/6] Some more code de-duplication Phil Sutter
2021-12-09 0:22 ` [iptables PATCH 1/6] xshared: Share print_match_save() between legacy ip*tables Phil Sutter
2021-12-09 0:22 ` [iptables PATCH 2/6] xshared: Share a common printhelp function Phil Sutter
2021-12-09 0:22 ` [iptables PATCH 3/6] libxtables: Add xtables_exit_tryhelp() Phil Sutter
2021-12-09 0:37 ` Pablo Neira Ayuso [this message]
2021-12-09 2:05 ` Phil Sutter
2021-12-09 0:22 ` [iptables PATCH 4/6] xtables_globals: Introduce program_variant Phil Sutter
2021-12-09 0:22 ` [iptables PATCH 5/6] libxtables: Extend basic_exit_err() Phil Sutter
2021-12-09 0:22 ` [iptables PATCH 6/6] iptables-*-restore: Drop pointless line reference Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbFP1PI+NSUD238i@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.