From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 566ABC433EF for ; Thu, 9 Dec 2021 17:00:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 40B3A10E1FF; Thu, 9 Dec 2021 16:54:16 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D43B89F45 for ; Thu, 9 Dec 2021 13:24:26 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="262199415" X-IronPort-AV: E=Sophos;i="5.88,192,1635231600"; d="scan'208";a="262199415" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 05:24:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,192,1635231600"; d="scan'208";a="503486183" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga007.jf.intel.com with SMTP; 09 Dec 2021 05:24:15 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 09 Dec 2021 15:24:13 +0200 Date: Thu, 9 Dec 2021 15:24:13 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <20211203112029.1057-1-ville.syrjala@linux.intel.com> <87zgp93ooj.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zgp93ooj.fsf@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Nuke {pipe, plane}_to_crtc_mapping[] X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Dec 09, 2021 at 03:14:52PM +0200, Jani Nikula wrote: > On Fri, 03 Dec 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > These plane/pipe->crtc mapping arrays are rather pointless. > > Get rid of them and just iterate the lists instead. > > Nice follow-up to my cleanups. On the series, > > Reviewed-by: Jani Nikula > > intel_crtc_first() might have been nice for the prefix, but does it > sound too awkward? *shrug* Yeah, sounds a bit wonky to my ear. I'd probably have of those "wtf does that do?" moments if I saw a intel_crtc_first() call in the code. -- Ville Syrjälä Intel