From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F39D3C433F5 for ; Fri, 10 Dec 2021 15:02:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239621AbhLJPGZ (ORCPT ); Fri, 10 Dec 2021 10:06:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235206AbhLJPGZ (ORCPT ); Fri, 10 Dec 2021 10:06:25 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25E6FC061746 for ; Fri, 10 Dec 2021 07:02:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E27B6B82875 for ; Fri, 10 Dec 2021 15:02:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11473C00446; Fri, 10 Dec 2021 15:02:44 +0000 (UTC) Date: Fri, 10 Dec 2021 15:02:41 +0000 From: Catalin Marinas To: Mark Rutland Cc: linux-kernel@vger.kernel.org, ardb@kernel.org, bp@alien8.de, broonie@kernel.org, dave.hansen@linux.intel.com, jpoimboe@redhat.com, jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, maz@kernel.org, mingo@redhat.com, peterz@infradead.org, tabba@google.com, tglx@linutronix.de, will@kernel.org Subject: Re: [RFC PATCH 3/6] arm64: remove __dma_*_area() aliases Message-ID: References: <20211206124715.4101571-1-mark.rutland@arm.com> <20211206124715.4101571-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211206124715.4101571-4-mark.rutland@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 06, 2021 at 12:47:12PM +0000, Mark Rutland wrote: > The __dma_inv_area() and __dma_clean_area() aliases make cache.S harder > to navigate, but don't gain us anything in practice. > > For clarity, let's remove them along with their redundant comments. The > only users are __dma_map_area() and __dma_unmap_area(), which need to be > position independent, and can call __pi_dcache_inval_poc() and > __pi_dcache_clean_poc() directly. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Ard Biesheuvel > Cc: Catalin Marinas > Cc: Fuad Tabba > Cc: Marc Zyngier > Cc: Will Deacon Acked-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79ED1C433F5 for ; Fri, 10 Dec 2021 15:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eG/2w4CvkWHCbRtE/z9n9JJxVMUOsh72UGv/UeDot64=; b=sZ+7kia7O6npVo jj+K7NuJsc3AEp/DYeScfJ8GPEkO65bxnFU4k3RN4VFivj7kdnyvrP5IaxcMcyYinWbl72Ah5EEW3 hmnmSVuDkXcXBWuo3J4qcL7SPR+TuS5h52NCbIHAoGfepp/rN3jPJX/RzunBKnZZWUzPQzY8LLCkX Ja/8tv9uM1Cbd6nKZ6wx8vNd6BdCHt7DbNjLOoWg26d3s0dvkK+DD4/OdPzaknoBWF/zbLtAEMiS9 QsO7UIgkxhLdV9QhhDcaLAIBRBezoVe6rGdOgMhcu1400uBEalTwLYneeRaYxFznLBE1OqZgGmxzJ mUPxKObXoZekN9fgYT4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvhQG-002IOB-9A; Fri, 10 Dec 2021 15:02:56 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvhQC-002IMU-Uu for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 15:02:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6FD48CE2B0B; Fri, 10 Dec 2021 15:02:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11473C00446; Fri, 10 Dec 2021 15:02:44 +0000 (UTC) Date: Fri, 10 Dec 2021 15:02:41 +0000 From: Catalin Marinas To: Mark Rutland Cc: linux-kernel@vger.kernel.org, ardb@kernel.org, bp@alien8.de, broonie@kernel.org, dave.hansen@linux.intel.com, jpoimboe@redhat.com, jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, maz@kernel.org, mingo@redhat.com, peterz@infradead.org, tabba@google.com, tglx@linutronix.de, will@kernel.org Subject: Re: [RFC PATCH 3/6] arm64: remove __dma_*_area() aliases Message-ID: References: <20211206124715.4101571-1-mark.rutland@arm.com> <20211206124715.4101571-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211206124715.4101571-4-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_070253_200044_541F48BB X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 12:47:12PM +0000, Mark Rutland wrote: > The __dma_inv_area() and __dma_clean_area() aliases make cache.S harder > to navigate, but don't gain us anything in practice. > > For clarity, let's remove them along with their redundant comments. The > only users are __dma_map_area() and __dma_unmap_area(), which need to be > position independent, and can call __pi_dcache_inval_poc() and > __pi_dcache_clean_poc() directly. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Ard Biesheuvel > Cc: Catalin Marinas > Cc: Fuad Tabba > Cc: Marc Zyngier > Cc: Will Deacon Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel