From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6896C433EF for ; Fri, 10 Dec 2021 18:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245098AbhLJSHs (ORCPT ); Fri, 10 Dec 2021 13:07:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245092AbhLJSHr (ORCPT ); Fri, 10 Dec 2021 13:07:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DBA6C061746 for ; Fri, 10 Dec 2021 10:04:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2E4AEB8294F for ; Fri, 10 Dec 2021 18:04:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFF83C00446; Fri, 10 Dec 2021 18:04:06 +0000 (UTC) Date: Fri, 10 Dec 2021 18:04:03 +0000 From: Catalin Marinas To: andrey.konovalov@linux.dev Cc: Marco Elver , Alexander Potapenko , Vincenzo Frascino , Peter Collingbourne , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v2 32/34] arm64: select KASAN_VMALLOC for SW/HW_TAGS modes Message-ID: References: <4f56dd2bfaf945032a226f90141bb4f8e73959b7.1638825394.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f56dd2bfaf945032a226f90141bb4f8e73959b7.1638825394.git.andreyknvl@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 06, 2021 at 10:44:09PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Generic KASAN already selects KASAN_VMALLOC to allow VMAP_STACK to be > selected unconditionally, see commit acc3042d62cb9 ("arm64: Kconfig: > select KASAN_VMALLOC if KANSAN_GENERIC is enabled"). > > The same change is needed for SW_TAGS KASAN. > > HW_TAGS KASAN does not require enabling KASAN_VMALLOC for VMAP_STACK, > they already work together as is. Still, selecting KASAN_VMALLOC still > makes sense to make vmalloc() always protected. In case any bugs in > KASAN's vmalloc() support are discovered, the command line kasan.vmalloc > flag can be used to disable vmalloc() checking. > > This patch selects KASAN_VMALLOC for all KASAN modes for arm64. > > Signed-off-by: Andrey Konovalov Acked-by: Catalin Marinas I also had a look at the rest of the patches and they look fine to me (even the init_tags comment, feel free to ignore it). I'll poke Vincenzo next week to look at the patches with his co-developed-by tag. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E57AC433F5 for ; Fri, 10 Dec 2021 18:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2n9DDmWGlhehXwPQEN4VebLXrbNb1nrAG8z/GAHe9oA=; b=MKTGIgcxwnK5q2 DgXHC3LvCI5msBwCTGic0leCpC0RFTq3fVEhZEx1rDzsDuNRucyW2VGqraaxpXSYQgjYq3ZoxtZsc cf/vTrCUXNzxFnGjox0KbdmDTst61z7Kkc1eA6rZkxx3BHGgGgKAiNU/n7uGw+/GCE8U/rO10MaOx NbnQqZke8aPYWiOW8MGVA/l4DEkUBy7kpVmQN/sPXTccLkamv6gVaXYC1scSLgbK9qvqEhfnENZuS Z1P692X/PvH0x6em6Bpq+tPz161NcXb1DVK7IqB0Eeg0XgZ26ZBQrLQIBSrWBaHlild31boPJGrf/ INeMBKWtZi2+GwLZ8dag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvkJd-00389o-HE; Fri, 10 Dec 2021 18:08:18 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvkFg-0036cM-Dy for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 18:04:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1313DB82706; Fri, 10 Dec 2021 18:04:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFF83C00446; Fri, 10 Dec 2021 18:04:06 +0000 (UTC) Date: Fri, 10 Dec 2021 18:04:03 +0000 From: Catalin Marinas To: andrey.konovalov@linux.dev Cc: Marco Elver , Alexander Potapenko , Vincenzo Frascino , Peter Collingbourne , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v2 32/34] arm64: select KASAN_VMALLOC for SW/HW_TAGS modes Message-ID: References: <4f56dd2bfaf945032a226f90141bb4f8e73959b7.1638825394.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4f56dd2bfaf945032a226f90141bb4f8e73959b7.1638825394.git.andreyknvl@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_100412_650145_EA4D7084 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 10:44:09PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Generic KASAN already selects KASAN_VMALLOC to allow VMAP_STACK to be > selected unconditionally, see commit acc3042d62cb9 ("arm64: Kconfig: > select KASAN_VMALLOC if KANSAN_GENERIC is enabled"). > > The same change is needed for SW_TAGS KASAN. > > HW_TAGS KASAN does not require enabling KASAN_VMALLOC for VMAP_STACK, > they already work together as is. Still, selecting KASAN_VMALLOC still > makes sense to make vmalloc() always protected. In case any bugs in > KASAN's vmalloc() support are discovered, the command line kasan.vmalloc > flag can be used to disable vmalloc() checking. > > This patch selects KASAN_VMALLOC for all KASAN modes for arm64. > > Signed-off-by: Andrey Konovalov Acked-by: Catalin Marinas I also had a look at the rest of the patches and they look fine to me (even the init_tags comment, feel free to ignore it). I'll poke Vincenzo next week to look at the patches with his co-developed-by tag. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel