From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4502C433FE for ; Mon, 13 Dec 2021 05:45:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbhLMFpz (ORCPT ); Mon, 13 Dec 2021 00:45:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbhLMFpx (ORCPT ); Mon, 13 Dec 2021 00:45:53 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AADB8C06173F; Sun, 12 Dec 2021 21:45:53 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id 8so13978126pfo.4; Sun, 12 Dec 2021 21:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YxTqaHrb1WONr4bzbFg9s07xU3CclGU8fXdbhcxL4wY=; b=HrwQaPS9mX/xUntq2L4rPSLlfvXt8WxPbyDS1O81vEPuznXszRyVBMEpIQ4jUGYr+d n3hpK21TmtA97jBvAb9Ml9Samja179i6QsL8zq0chSGWstVYH2g2NlcXim+ROrJd31TB upHt1ukE/j5f24oq8kOyeTyw2ti7EkoCRfrpCwFq7qh04ZPK0nzWy3HaEu4wYtBTaxjU 8B1dVPArY3cDt4LIWdIcPQG5SEXaMMw2f0bmsvIwh9R9chh2xCcM/5PKlnv4PfMY37gR BFcL3i7lfZG7UDnsT947ul+rwowo1kOwvqE+L1rPJdMFbUxeTC8pNtVpMPkoV4PwAg84 SOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YxTqaHrb1WONr4bzbFg9s07xU3CclGU8fXdbhcxL4wY=; b=OPRHMk4w7yNq3yQv/snDtvhlFVlvLreWKw3oV1Y8XuKKoUrN2KLyDxFFKakudHXNoH zOgsOymWH/2fCKmZKvGQWmzzQpIDkLg6Mvv5R0nUTKA9zszSKfNY+yIFQg6hzzurIAdP A+FFdLkCRtfPFKB441Kr8BJ3N7uAsBRWQjqqdvuF7G0VFNHlP4oKW60tk4F8ujCqC/xe 4sgXHhiqjAnbIpCqcwbrIgy/R+KHSOtVfBGQB4RiCU9hGYcPFtnp/r/um1XGI7Vc5Fq6 tozdbA2G7VABIDMSO709T5cGoMd9vnFI8WUDXCksGxZhxjASURZ1ULCkskDG7doAPMm4 CkYw== X-Gm-Message-State: AOAM5309j8poMD/j88fCTkL/WVHjl/dGONg7btfxF7m/07obBEQyUr9o lc4wUuvml1DJL6VdnzKSjwc= X-Google-Smtp-Source: ABdhPJxSAkGXd7eqoG11hnQsbGyVxpD1ryL7wjbnVUDsr9Yqg6avZ0fCzJ7Z0d4Br6GhMorxKY+8Vg== X-Received: by 2002:aa7:93c4:0:b0:49f:a7f5:7f5a with SMTP id y4-20020aa793c4000000b0049fa7f57f5amr31796521pff.8.1639374353027; Sun, 12 Dec 2021 21:45:53 -0800 (PST) Received: from google.com ([2620:15c:202:201:e537:8856:7d40:7c6]) by smtp.gmail.com with ESMTPSA id mq14sm5553657pjb.54.2021.12.12.21.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Dec 2021 21:45:51 -0800 (PST) Date: Sun, 12 Dec 2021 21:45:48 -0800 From: Dmitry Torokhov To: Alistair Francis Cc: Alistair Francis , linux-arm-kernel , devicetree , linux-input , Linux Kernel Mailing List , Mylene Josserand , Linus Walleij , Andreas Kemnade , Henrik Rydberg , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Maxime Ripard Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Message-ID: References: <20211103114830.62711-1-alistair@alistair23.me> <20211103114830.62711-2-alistair@alistair23.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 01, 2021 at 10:27:46PM +1000, Alistair Francis wrote: > On Sat, Nov 6, 2021 at 4:47 PM Dmitry Torokhov > wrote: > > > > Hi Alistair, > > > > On Wed, Nov 03, 2021 at 09:48:27PM +1000, Alistair Francis wrote: > > > From: Mylčne Josserand > > > ... > > > + si->tch_hdr.max, > > > + si->xy_mode + 3 + si->tch_hdr.ofs, > > > + si->tch_hdr.bofs); > > > + > > > + num_cur_tch = tch.hdr; > > > + if (num_cur_tch > max_tch) { > > > + dev_err(dev, "Num touch err detected (n=%d)\n", num_cur_tch); > > > + num_cur_tch = max_tch; > > > + } > > > + > > > + if (num_cur_tch == 0 && ts->num_prv_rec == 0) > > > + return 0; > > > + > > > + /* extract xy_data for all currently reported touches */ > > > + if (num_cur_tch) > > > + cyttsp5_get_mt_touches(ts, &tch, num_cur_tch); > > > + else > > > + cyttsp5_mt_lift_all(ts); > > > > Not needed with INPUT_MT_DROP_UNUSED. > > I tried INPUT_MT_DROP_UNUSED and I still need this function I am curious why that is. Probably call to input_mt_sync_frame() was in a wrong place? ... > > > + > > > +static int cyttsp5_deassert_int(struct cyttsp5 *ts) > > > +{ > > > + u16 size; > > > + u8 buf[2]; > > > + int rc; > > > + > > > + rc = regmap_bulk_read(ts->regmap, HID_INPUT_REG, buf, 2); > > > + if (rc < 0) > > > + return rc; > > > + > > > + size = get_unaligned_le16(&buf[0]); > > > + if (size == 2 || size == 0) > > > + return 0; > > > > If you were to use level interrupts this probably would not be needed. > > I have tried with/without this and I still can't get level interrupts working. Does the platform support level interrupts? ... > > > +static int cyttsp5_probe(struct device *dev, struct regmap *regmap, int irq, > > > + const char *name) > > > +{ > > > + struct cyttsp5 *ts; > > > + struct cyttsp5_sysinfo *si; > > > + int rc = 0, i; > > > + > > > + ts = devm_kzalloc(dev, sizeof(*ts), GFP_KERNEL); > > > + if (!ts) > > > + return -ENOMEM; > > > + > > > + /* Initialize device info */ > > > + ts->regmap = regmap; > > > + ts->dev = dev; > > > + si = &ts->sysinfo; > > > + dev_set_drvdata(dev, ts); > > > + > > > + /* Initialize mutexes and spinlocks */ > > > + mutex_init(&ts->system_lock); > > > + > > > + /* Initialize wait queue */ > > > + init_waitqueue_head(&ts->wait_q); > > > + > > > + /* Power up the device */ > > > + ts->vdd = regulator_get(dev, "vdd"); > > > > Do not mix managed an unmanaged resources. You are leaking this > > regulator. > > I'm not clear what I should do differently here. devm_regulator_get(). > > > > > > + if (IS_ERR(ts->vdd)) { > > > + rc = PTR_ERR(ts->vdd); > > > + dev_set_drvdata(dev, NULL); > > > + kfree(ts); You can't call kfree() for memory allocated with devm_kzalloc(). > > > + return rc; > > > + } > > > + > > > + rc = regulator_enable(ts->vdd); > > > + if (rc) { > > > + regulator_put(ts->vdd); > > > + dev_set_drvdata(dev, NULL); > > > + kfree(ts); > > > + return rc; > > > + } > > > + > > > + /* Reset the gpio to be in a reset state */ > > > + ts->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); > > > + if (IS_ERR(ts->reset_gpio)) { > > > + rc = PTR_ERR(ts->reset_gpio); > > > + dev_err(dev, "Failed to request reset gpio, error %d\n", rc); > > > + return rc; > > > + } > > > + gpiod_set_value(ts->reset_gpio, 1); > > > + > > > + /* Need a delay to have device up */ > > > + msleep(20); > > > + > > > + rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq, > > > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > > > > Please do not override platform setup with hardcoded triggers. Also, it > > is strongly recommended to use level interrupts for these peripherals. > > > > This is also likely unsafe if controller is not completely shut off and > > is capable of generating interrupts given input device is not yet > > allocated. > > I have dropped the `IRQF_TRIGGER_FALLING |` > > I have tried to use level interrupts, but I can't get the device > working with them. That is weird, does the interrupt controller support level interrupts? Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9F13C433F5 for ; Mon, 13 Dec 2021 05:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VS83OasqGP6Pjx54CJxbcrpXyhnZEdm7YZRWy8+air0=; b=KoK/WVm7m5sH6g tAawnMYCtcU7wZ/PtNTBGTlXXN00Xb6XYpkT62FreB8CePRJ91CG5UVmmQ123zbisOOIkaP0fy9cV mbo0Us9rd2MHMRaEXrHy1WOqeEbBLjiOACzJZPR0BnS4gzOnOXRIKlHwM5qZkvutxUUca/9kV9m1K K+I5YJiK7r/ER97fE5xV0yOrb+YmN0HkzfRwJNMnRD9q2+HkDkOBlEA7E/1rp8QNNCQM/jizXLrCV S5RclA9GAZFsCbVMcqZ5qKyvvwwC+bzfG4F3BwGGdi26EFzIxuYajbkr+7FFFdYITdA3qiM7FBquh e5tkg5gHIVCCRB6FOvqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwe9u-007rUs-R9; Mon, 13 Dec 2021 05:45:59 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwe9q-007rU4-MR for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 05:45:56 +0000 Received: by mail-pg1-x530.google.com with SMTP id j11so13605897pgs.2 for ; Sun, 12 Dec 2021 21:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YxTqaHrb1WONr4bzbFg9s07xU3CclGU8fXdbhcxL4wY=; b=HrwQaPS9mX/xUntq2L4rPSLlfvXt8WxPbyDS1O81vEPuznXszRyVBMEpIQ4jUGYr+d n3hpK21TmtA97jBvAb9Ml9Samja179i6QsL8zq0chSGWstVYH2g2NlcXim+ROrJd31TB upHt1ukE/j5f24oq8kOyeTyw2ti7EkoCRfrpCwFq7qh04ZPK0nzWy3HaEu4wYtBTaxjU 8B1dVPArY3cDt4LIWdIcPQG5SEXaMMw2f0bmsvIwh9R9chh2xCcM/5PKlnv4PfMY37gR BFcL3i7lfZG7UDnsT947ul+rwowo1kOwvqE+L1rPJdMFbUxeTC8pNtVpMPkoV4PwAg84 SOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YxTqaHrb1WONr4bzbFg9s07xU3CclGU8fXdbhcxL4wY=; b=29w8iaaPSj7bELzjesGSBHKTU9O03SOidDI0jd0FY/mOad1wf/ZKlEtzd4fhfAfqVU cMkui3sI3zVfylsOl62TwSxZy+NHDozROGlYCFRIbOdCKwta1HlQnpDPaF8yKAf+eKJT GjEs5AMDs9uitaqkRz3jSIOABQ2YlP7xpFUi2Th+4B1vDYIsNOa8jHfYbxknfmgYjB/e 2jodGkx0/VlCcA04yhk8LN443OcwAH/f3yt/X2MHNl7ISvf8x1hlC3Z6OFZUCw7EtfnZ WN4bzihn8WCMyti7GJys5USRf4KuAUbHjT/UNluOjANIqhM0/JPza8UuSvUUGvoxwai9 H68g== X-Gm-Message-State: AOAM532Ws2X9bzAAkoUzSJHBlPTQqdDXb70J5hs3Kn44qz0cakgeItC9 R/qLQ5X7wBLyZ8f0Dq9tBVA= X-Google-Smtp-Source: ABdhPJxSAkGXd7eqoG11hnQsbGyVxpD1ryL7wjbnVUDsr9Yqg6avZ0fCzJ7Z0d4Br6GhMorxKY+8Vg== X-Received: by 2002:aa7:93c4:0:b0:49f:a7f5:7f5a with SMTP id y4-20020aa793c4000000b0049fa7f57f5amr31796521pff.8.1639374353027; Sun, 12 Dec 2021 21:45:53 -0800 (PST) Received: from google.com ([2620:15c:202:201:e537:8856:7d40:7c6]) by smtp.gmail.com with ESMTPSA id mq14sm5553657pjb.54.2021.12.12.21.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Dec 2021 21:45:51 -0800 (PST) Date: Sun, 12 Dec 2021 21:45:48 -0800 From: Dmitry Torokhov To: Alistair Francis Cc: Alistair Francis , linux-arm-kernel , devicetree , linux-input , Linux Kernel Mailing List , Mylene Josserand , Linus Walleij , Andreas Kemnade , Henrik Rydberg , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Maxime Ripard Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Message-ID: References: <20211103114830.62711-1-alistair@alistair23.me> <20211103114830.62711-2-alistair@alistair23.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211212_214554_789682_6770A3E1 X-CRM114-Status: GOOD ( 33.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMDEsIDIwMjEgYXQgMTA6Mjc6NDZQTSArMTAwMCwgQWxpc3RhaXIgRnJhbmNp cyB3cm90ZToKPiAgT24gU2F0LCBOb3YgNiwgMjAyMSBhdCA0OjQ3IFBNIERtaXRyeSBUb3Jva2hv dgo+IDxkbWl0cnkudG9yb2tob3ZAZ21haWwuY29tPiB3cm90ZToKPiA+Cj4gPiBIaSBBbGlzdGFp ciwKPiA+Cj4gPiBPbiBXZWQsIE5vdiAwMywgMjAyMSBhdCAwOTo0ODoyN1BNICsxMDAwLCBBbGlz dGFpciBGcmFuY2lzIHdyb3RlOgo+ID4gPiBGcm9tOiBNeWzEjW5lIEpvc3NlcmFuZCA8bXlsZW5l Lmpvc3NlcmFuZEBib290bGluLmNvbT4KPiA+ID4KLi4uCj4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc2ktPnRjaF9oZHIubWF4LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHNpLT54eV9tb2RlICsgMyArIHNpLT50Y2hfaGRyLm9mcywKPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzaS0+dGNoX2hkci5ib2ZzKTsKPiA+ID4gKwo+ID4gPiArICAg ICBudW1fY3VyX3RjaCA9IHRjaC5oZHI7Cj4gPiA+ICsgICAgIGlmIChudW1fY3VyX3RjaCA+IG1h eF90Y2gpIHsKPiA+ID4gKyAgICAgICAgICAgICBkZXZfZXJyKGRldiwgIk51bSB0b3VjaCBlcnIg ZGV0ZWN0ZWQgKG49JWQpXG4iLCBudW1fY3VyX3RjaCk7Cj4gPiA+ICsgICAgICAgICAgICAgbnVt X2N1cl90Y2ggPSBtYXhfdGNoOwo+ID4gPiArICAgICB9Cj4gPiA+ICsKPiA+ID4gKyAgICAgaWYg KG51bV9jdXJfdGNoID09IDAgJiYgdHMtPm51bV9wcnZfcmVjID09IDApCj4gPiA+ICsgICAgICAg ICAgICAgcmV0dXJuIDA7Cj4gPiA+ICsKPiA+ID4gKyAgICAgLyogZXh0cmFjdCB4eV9kYXRhIGZv ciBhbGwgY3VycmVudGx5IHJlcG9ydGVkIHRvdWNoZXMgKi8KPiA+ID4gKyAgICAgaWYgKG51bV9j dXJfdGNoKQo+ID4gPiArICAgICAgICAgICAgIGN5dHRzcDVfZ2V0X210X3RvdWNoZXModHMsICZ0 Y2gsIG51bV9jdXJfdGNoKTsKPiA+ID4gKyAgICAgZWxzZQo+ID4gPiArICAgICAgICAgICAgIGN5 dHRzcDVfbXRfbGlmdF9hbGwodHMpOwo+ID4KPiA+IE5vdCBuZWVkZWQgd2l0aCBJTlBVVF9NVF9E Uk9QX1VOVVNFRC4KPiAKPiBJIHRyaWVkIElOUFVUX01UX0RST1BfVU5VU0VEIGFuZCBJIHN0aWxs IG5lZWQgdGhpcyBmdW5jdGlvbgoKSSBhbSBjdXJpb3VzIHdoeSB0aGF0IGlzLiBQcm9iYWJseSBj YWxsIHRvIGlucHV0X210X3N5bmNfZnJhbWUoKSB3YXMgaW4KYSB3cm9uZyBwbGFjZT8KCi4uLgoK PiA+ID4gKwo+ID4gPiArc3RhdGljIGludCBjeXR0c3A1X2RlYXNzZXJ0X2ludChzdHJ1Y3QgY3l0 dHNwNSAqdHMpCj4gPiA+ICt7Cj4gPiA+ICsgICAgIHUxNiBzaXplOwo+ID4gPiArICAgICB1OCBi dWZbMl07Cj4gPiA+ICsgICAgIGludCByYzsKPiA+ID4gKwo+ID4gPiArICAgICByYyA9IHJlZ21h cF9idWxrX3JlYWQodHMtPnJlZ21hcCwgSElEX0lOUFVUX1JFRywgYnVmLCAyKTsKPiA+ID4gKyAg ICAgaWYgKHJjIDwgMCkKPiA+ID4gKyAgICAgICAgICAgICByZXR1cm4gcmM7Cj4gPiA+ICsKPiA+ ID4gKyAgICAgc2l6ZSA9IGdldF91bmFsaWduZWRfbGUxNigmYnVmWzBdKTsKPiA+ID4gKyAgICAg aWYgKHNpemUgPT0gMiB8fCBzaXplID09IDApCj4gPiA+ICsgICAgICAgICAgICAgcmV0dXJuIDA7 Cj4gPgo+ID4gSWYgeW91IHdlcmUgdG8gdXNlIGxldmVsIGludGVycnVwdHMgdGhpcyBwcm9iYWJs eSB3b3VsZCBub3QgYmUgbmVlZGVkLgo+IAo+IEkgaGF2ZSB0cmllZCB3aXRoL3dpdGhvdXQgdGhp cyBhbmQgSSBzdGlsbCBjYW4ndCBnZXQgbGV2ZWwgaW50ZXJydXB0cyB3b3JraW5nLgoKRG9lcyB0 aGUgcGxhdGZvcm0gc3VwcG9ydCBsZXZlbCBpbnRlcnJ1cHRzPwoKLi4uCj4gPiA+ICtzdGF0aWMg aW50IGN5dHRzcDVfcHJvYmUoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgcmVnbWFwICpyZWdt YXAsIGludCBpcnEsCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqbmFt ZSkKPiA+ID4gK3sKPiA+ID4gKyAgICAgc3RydWN0IGN5dHRzcDUgKnRzOwo+ID4gPiArICAgICBz dHJ1Y3QgY3l0dHNwNV9zeXNpbmZvICpzaTsKPiA+ID4gKyAgICAgaW50IHJjID0gMCwgaTsKPiA+ ID4gKwo+ID4gPiArICAgICB0cyA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqdHMpLCBHRlBf S0VSTkVMKTsKPiA+ID4gKyAgICAgaWYgKCF0cykKPiA+ID4gKyAgICAgICAgICAgICByZXR1cm4g LUVOT01FTTsKPiA+ID4gKwo+ID4gPiArICAgICAvKiBJbml0aWFsaXplIGRldmljZSBpbmZvICov Cj4gPiA+ICsgICAgIHRzLT5yZWdtYXAgPSByZWdtYXA7Cj4gPiA+ICsgICAgIHRzLT5kZXYgPSBk ZXY7Cj4gPiA+ICsgICAgIHNpID0gJnRzLT5zeXNpbmZvOwo+ID4gPiArICAgICBkZXZfc2V0X2Ry dmRhdGEoZGV2LCB0cyk7Cj4gPiA+ICsKPiA+ID4gKyAgICAgLyogSW5pdGlhbGl6ZSBtdXRleGVz IGFuZCBzcGlubG9ja3MgKi8KPiA+ID4gKyAgICAgbXV0ZXhfaW5pdCgmdHMtPnN5c3RlbV9sb2Nr KTsKPiA+ID4gKwo+ID4gPiArICAgICAvKiBJbml0aWFsaXplIHdhaXQgcXVldWUgKi8KPiA+ID4g KyAgICAgaW5pdF93YWl0cXVldWVfaGVhZCgmdHMtPndhaXRfcSk7Cj4gPiA+ICsKPiA+ID4gKyAg ICAgLyogUG93ZXIgdXAgdGhlIGRldmljZSAqLwo+ID4gPiArICAgICB0cy0+dmRkID0gcmVndWxh dG9yX2dldChkZXYsICJ2ZGQiKTsKPiA+Cj4gPiBEbyBub3QgbWl4IG1hbmFnZWQgYW4gdW5tYW5h Z2VkIHJlc291cmNlcy4gWW91IGFyZSBsZWFraW5nIHRoaXMKPiA+IHJlZ3VsYXRvci4KPiAKPiBJ J20gbm90IGNsZWFyIHdoYXQgSSBzaG91bGQgZG8gZGlmZmVyZW50bHkgaGVyZS4KCmRldm1fcmVn dWxhdG9yX2dldCgpLgoKPiAKPiA+Cj4gPiA+ICsgICAgIGlmIChJU19FUlIodHMtPnZkZCkpIHsK PiA+ID4gKyAgICAgICAgICAgICByYyA9IFBUUl9FUlIodHMtPnZkZCk7Cj4gPiA+ICsgICAgICAg ICAgICAgZGV2X3NldF9kcnZkYXRhKGRldiwgTlVMTCk7Cj4gPiA+ICsgICAgICAgICAgICAga2Zy ZWUodHMpOwoKWW91IGNhbid0IGNhbGwga2ZyZWUoKSBmb3IgbWVtb3J5IGFsbG9jYXRlZCB3aXRo IGRldm1fa3phbGxvYygpLgoKPiA+ID4gKyAgICAgICAgICAgICByZXR1cm4gcmM7Cj4gPiA+ICsg ICAgIH0KPiA+ID4gKwo+ID4gPiArICAgICByYyA9IHJlZ3VsYXRvcl9lbmFibGUodHMtPnZkZCk7 Cj4gPiA+ICsgICAgIGlmIChyYykgewo+ID4gPiArICAgICAgICAgICAgIHJlZ3VsYXRvcl9wdXQo dHMtPnZkZCk7Cj4gPiA+ICsgICAgICAgICAgICAgZGV2X3NldF9kcnZkYXRhKGRldiwgTlVMTCk7 Cj4gPiA+ICsgICAgICAgICAgICAga2ZyZWUodHMpOwo+ID4gPiArICAgICAgICAgICAgIHJldHVy biByYzsKPiA+ID4gKyAgICAgfQo+ID4gPiArCj4gPiA+ICsgICAgIC8qIFJlc2V0IHRoZSBncGlv IHRvIGJlIGluIGEgcmVzZXQgc3RhdGUgKi8KPiA+ID4gKyAgICAgdHMtPnJlc2V0X2dwaW8gPSBk ZXZtX2dwaW9kX2dldF9vcHRpb25hbChkZXYsICJyZXNldCIsIEdQSU9EX09VVF9MT1cpOwo+ID4g PiArICAgICBpZiAoSVNfRVJSKHRzLT5yZXNldF9ncGlvKSkgewo+ID4gPiArICAgICAgICAgICAg IHJjID0gUFRSX0VSUih0cy0+cmVzZXRfZ3Bpbyk7Cj4gPiA+ICsgICAgICAgICAgICAgZGV2X2Vy cihkZXYsICJGYWlsZWQgdG8gcmVxdWVzdCByZXNldCBncGlvLCBlcnJvciAlZFxuIiwgcmMpOwo+ ID4gPiArICAgICAgICAgICAgIHJldHVybiByYzsKPiA+ID4gKyAgICAgfQo+ID4gPiArICAgICBn cGlvZF9zZXRfdmFsdWUodHMtPnJlc2V0X2dwaW8sIDEpOwo+ID4gPiArCj4gPiA+ICsgICAgIC8q IE5lZWQgYSBkZWxheSB0byBoYXZlIGRldmljZSB1cCAqLwo+ID4gPiArICAgICBtc2xlZXAoMjAp Owo+ID4gPiArCj4gPiA+ICsgICAgIHJjID0gZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycShkZXYs IGlycSwgTlVMTCwgY3l0dHNwNV9oYW5kbGVfaXJxLAo+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgSVJRRl9UUklHR0VSX0ZBTExJTkcgfCBJUlFGX09ORVNIT1QsCj4g Pgo+ID4gUGxlYXNlIGRvIG5vdCBvdmVycmlkZSBwbGF0Zm9ybSBzZXR1cCB3aXRoIGhhcmRjb2Rl ZCB0cmlnZ2Vycy4gQWxzbywgaXQKPiA+IGlzIHN0cm9uZ2x5IHJlY29tbWVuZGVkIHRvIHVzZSBs ZXZlbCBpbnRlcnJ1cHRzIGZvciB0aGVzZSBwZXJpcGhlcmFscy4KPiA+Cj4gPiBUaGlzIGlzIGFs c28gbGlrZWx5IHVuc2FmZSBpZiBjb250cm9sbGVyIGlzIG5vdCBjb21wbGV0ZWx5IHNodXQgb2Zm IGFuZAo+ID4gaXMgY2FwYWJsZSBvZiBnZW5lcmF0aW5nIGludGVycnVwdHMgZ2l2ZW4gaW5wdXQg ZGV2aWNlIGlzIG5vdCB5ZXQKPiA+IGFsbG9jYXRlZC4KPiAKPiBJIGhhdmUgZHJvcHBlZCB0aGUg YElSUUZfVFJJR0dFUl9GQUxMSU5HIHxgCj4gCj4gSSBoYXZlIHRyaWVkIHRvIHVzZSBsZXZlbCBp bnRlcnJ1cHRzLCBidXQgSSBjYW4ndCBnZXQgdGhlIGRldmljZQo+IHdvcmtpbmcgd2l0aCB0aGVt LgoKVGhhdCBpcyB3ZWlyZCwgZG9lcyB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgc3VwcG9ydCBs ZXZlbCBpbnRlcnJ1cHRzPwoKVGhhbmtzLgoKLS0gCkRtaXRyeQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=