From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3A5C4332F for ; Mon, 13 Dec 2021 22:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243968AbhLMWvJ (ORCPT ); Mon, 13 Dec 2021 17:51:09 -0500 Received: from mail-ot1-f52.google.com ([209.85.210.52]:45929 "EHLO mail-ot1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243945AbhLMWvH (ORCPT ); Mon, 13 Dec 2021 17:51:07 -0500 Received: by mail-ot1-f52.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso19022930otf.12; Mon, 13 Dec 2021 14:51:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TXNuhThSZzYh5dHlQEsy87eUYOOCcMvcopbthlMlzi0=; b=NHPDWRJY/+FfnhFlo8/StQQ+lix2feBhwgfXhSCSiO3lqSaFC9aK5klIyX0bIKOqq4 HHfs6qnoFyW/3mk8l0wTklJHPBv+nG1uZ5pmNXORgvuSF8W1vqXW4OE8Ic3nMQbRNX76 bLgNrNFt2HJo37MWEWZSBZzccUAdXt9jKrnaJph+sexHaRUZpxMOXeDGKUEkODMn1sqf holWK0Y4nu1UfZBywfZBkJwFZWhj9knd6HiG1otnj2VFrg44nmtrvSsky+gACpuROZW0 SJWFvh7dk0R4TI8nc1aolflDahHqmkwO9vWFvcxmduPvGFjrJAUDXa+edgZCAIebCMqc 8lkg== X-Gm-Message-State: AOAM532hNlfoi9aPPFOVXfjRghAHYtWeRu0BObA3ntUR3XRdgbV4ny86 3jmNvMw/NWsr/XzmqN+2Uw== X-Google-Smtp-Source: ABdhPJxCfZL3SzReunSYLPdv6bxyyePW0yFhigNTzi/mCZehsa7+8nCDGdg/U+lRD5jiU+CUp/zDpg== X-Received: by 2002:a9d:77d1:: with SMTP id w17mr1156068otl.329.1639435867068; Mon, 13 Dec 2021 14:51:07 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e4sm1490630oiy.12.2021.12.13.14.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 14:51:06 -0800 (PST) Received: (nullmailer pid 1725465 invoked by uid 1000); Mon, 13 Dec 2021 22:51:05 -0000 Date: Mon, 13 Dec 2021 16:51:05 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Sandy Huang , David Airlie , Daniel Vetter , - , David Heidelberg , ~okias/devicetree@lists.sr.ht, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI Message-ID: References: <20211206212651.126405-1-david@ixit.cz> <26502781.jAYDHVeSjN@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <26502781.jAYDHVeSjN@diego> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko Stübner wrote: > Hi David, > > Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg: > > Convert into YAML format into format, which can be validated. > > > > Changes: > > - drop panel from example > > the patch subject is strange, talking about a "power domain node". > That needs a fix. > > Some more things below. > > > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - rockchip,px30-mipi-dsi > > + - rockchip,rk3288-mipi-dsi > > + - rockchip,rk3399-mipi-dsi > > + - const: snps,dw-mipi-dsi > > > + - items: > > + - const: rockchip,px30-mipi-dsi > > + - items: > > + - const: rockchip,rk3288-mipi-dsi > > + - items: > > + - const: rockchip,rk3399-mipi-dsi > > what are these for? > > I see that px30 uses the dsi without the snps part, but you > can also just add a patch adding that second compatible to px30.dtsi Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful. But I guess that's more invasive so maybe stick with changing px30. > > I don't think we need to support both ways. Agreed. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 632B4C433F5 for ; Mon, 13 Dec 2021 22:51:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32D4B10E88D; Mon, 13 Dec 2021 22:51:08 +0000 (UTC) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id D32A110E88D for ; Mon, 13 Dec 2021 22:51:07 +0000 (UTC) Received: by mail-ot1-f49.google.com with SMTP id u18-20020a9d7212000000b00560cb1dc10bso19030873otj.11 for ; Mon, 13 Dec 2021 14:51:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TXNuhThSZzYh5dHlQEsy87eUYOOCcMvcopbthlMlzi0=; b=jFpiASBD4k7dHE9IWRVyiBOI+Gx536eox1eF7PHbbDe4Z7uq2M4lkYYb88oMbEFE1Q GDbroW2agHYyQDUDx79Bu60UgNCm8czxZQxY+DV+oDwTTiz9yRJkH8aBGAF7vaVIgzdl M/8jImeO4oWdr07wJSMGoAs7sOBZEVO3f/KFWn5JiKRo3zeq5HVvEvBKiLVzdam4nB1c /naWMFZvcvQ5pW0oWI0LaqKKf371FnXwvwZObdf717A2f3H5hZqbdM2nTKBhDmuhGtkT ru4PZB3qBqDJW1zTFZf1ipn27xmJCI9tZ6h/EXjINNKCuelitJZg4htsdcCsLPfZVdFV 6f1w== X-Gm-Message-State: AOAM533eVcLSTUhtyIhVTCwlxQZurL6bWNHpnIqdPVeV56mjxflqPxw9 tKD3upXMWm02nLpeLsUgQg== X-Google-Smtp-Source: ABdhPJxCfZL3SzReunSYLPdv6bxyyePW0yFhigNTzi/mCZehsa7+8nCDGdg/U+lRD5jiU+CUp/zDpg== X-Received: by 2002:a9d:77d1:: with SMTP id w17mr1156068otl.329.1639435867068; Mon, 13 Dec 2021 14:51:07 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e4sm1490630oiy.12.2021.12.13.14.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 14:51:06 -0800 (PST) Received: (nullmailer pid 1725465 invoked by uid 1000); Mon, 13 Dec 2021 22:51:05 -0000 Date: Mon, 13 Dec 2021 16:51:05 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI Message-ID: References: <20211206212651.126405-1-david@ixit.cz> <26502781.jAYDHVeSjN@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <26502781.jAYDHVeSjN@diego> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: - , devicetree@vger.kernel.org, David Airlie , Sandy Huang , David Heidelberg , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, ~okias/devicetree@lists.sr.ht, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko Stübner wrote: > Hi David, > > Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg: > > Convert into YAML format into format, which can be validated. > > > > Changes: > > - drop panel from example > > the patch subject is strange, talking about a "power domain node". > That needs a fix. > > Some more things below. > > > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - rockchip,px30-mipi-dsi > > + - rockchip,rk3288-mipi-dsi > > + - rockchip,rk3399-mipi-dsi > > + - const: snps,dw-mipi-dsi > > > + - items: > > + - const: rockchip,px30-mipi-dsi > > + - items: > > + - const: rockchip,rk3288-mipi-dsi > > + - items: > > + - const: rockchip,rk3399-mipi-dsi > > what are these for? > > I see that px30 uses the dsi without the snps part, but you > can also just add a patch adding that second compatible to px30.dtsi Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful. But I guess that's more invasive so maybe stick with changing px30. > > I don't think we need to support both ways. Agreed. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FF78C433EF for ; Mon, 13 Dec 2021 22:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xSvqGjQk/uHLVy8VEcp2Be1bjiaW02KqSp0LKgHb4+E=; b=dNJafzFvR2oKwx 6I5Lj7lcKmdkssO+Vg0ouxHLoeCUZlEBpBHAFqk9HwwoR09TA5izFsvi80n8rij1/UiTR3urSpzTb PTci3Va+ltcsvdizndb7R79/ep/Y7VhtSOR0znY1H1hKljqZbo31oD96V1lT9SilUC2Oik6+w6g/D jOXzkuLCsjXPy/7/MUIfvA7QjKz6YbQm4eGyVGbjlcVyt+UZE0X6rVcPIVfj9yrcouVAODJvHmEml NnxCBKMmXx3sdKbRtpqDAfSxw8MNIK75dshRBUDg8fJwB5Kcd1/gO3IIxjFgRRBMrORENXz25pQgm FWHUX42DoZoek9LFDEhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwuHT-00BtaK-Oo; Mon, 13 Dec 2021 22:58:51 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwu9z-00Brox-Oh; Mon, 13 Dec 2021 22:51:09 +0000 Received: by mail-ot1-f42.google.com with SMTP id x19-20020a9d7053000000b0055c8b39420bso19090746otj.1; Mon, 13 Dec 2021 14:51:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TXNuhThSZzYh5dHlQEsy87eUYOOCcMvcopbthlMlzi0=; b=G2jaFwGbAO5ctRjdNDGHY4nWPR1dWjEuNrBheC2I7/3GUNkz/GsHxp9W3osnxCSDUR FnQbBg9lHjuDWCGvvtqyJasijR2wjVqHPJdLIoxOapG1KOrsOi6ijUpSBd2znTRupTuv wQvjDE52ZfzcYWINuRXjeyRgxc7JBPhXdGekcXrP8mVMtiaJ6WjGP46FEJZJ4ZNNyOjN xl/UsLz30lp5Kn6MJAECJcH63e0VagfuFLVzX/hPCTJQgJ7q+2bhcBdAajO2Yvo7Mm1j aac3QWglroOh/mb0Z9kSSAlRGz80gfJP97eLBlr5JAkHcW+4/0mRCBpWCQrVyRgymPfH aD4g== X-Gm-Message-State: AOAM531EIAmzEvIKk6JlHOJLc4HTGncYBdk7y/cW+5CBW+efAgvwUcYd 36yewyxdc68Jo3X1cRYO3w== X-Google-Smtp-Source: ABdhPJxCfZL3SzReunSYLPdv6bxyyePW0yFhigNTzi/mCZehsa7+8nCDGdg/U+lRD5jiU+CUp/zDpg== X-Received: by 2002:a9d:77d1:: with SMTP id w17mr1156068otl.329.1639435867068; Mon, 13 Dec 2021 14:51:07 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e4sm1490630oiy.12.2021.12.13.14.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 14:51:06 -0800 (PST) Received: (nullmailer pid 1725465 invoked by uid 1000); Mon, 13 Dec 2021 22:51:05 -0000 Date: Mon, 13 Dec 2021 16:51:05 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Sandy Huang , David Airlie , Daniel Vetter , - , David Heidelberg , ~okias/devicetree@lists.sr.ht, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI Message-ID: References: <20211206212651.126405-1-david@ixit.cz> <26502781.jAYDHVeSjN@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <26502781.jAYDHVeSjN@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_145107_856350_8D7144DB X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko St=FCbner wrote: > Hi David, > = > Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg: > > Convert into YAML format into format, which can be validated. > > = > > Changes: > > - drop panel from example > = > the patch subject is strange, talking about a "power domain node". > That needs a fix. > = > Some more things below. > = > = > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - rockchip,px30-mipi-dsi > > + - rockchip,rk3288-mipi-dsi > > + - rockchip,rk3399-mipi-dsi > > + - const: snps,dw-mipi-dsi > = > > + - items: > > + - const: rockchip,px30-mipi-dsi > > + - items: > > + - const: rockchip,rk3288-mipi-dsi > > + - items: > > + - const: rockchip,rk3399-mipi-dsi > = > what are these for? > = > I see that px30 uses the dsi without the snps part, but you > can also just add a patch adding that second compatible to px30.dtsi Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful. = But I guess that's more invasive so maybe stick with changing px30. > = > I don't think we need to support both ways. Agreed. Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BA86C433EF for ; Mon, 13 Dec 2021 22:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ML/MwyvprJ+68yDnI21jnW6nuKfiL1piKldOaMMegH0=; b=GX8jY7NlpOdJOy LwvhZNAmofYL6v0J4/w/8lQ/+nud37UeJcXvOeRUsbMdWXynTwTMEnV2DdTANkrr69UbZ7gjuewCc AvlS7HzRybIw6TvvpUlKA9Za/RzyKQXIstEkv5Pg1SeN8ryNZcR0VHMRGQ6oxA8Z2ORTpUbfhaVyg E2SNPkgAqSKVR9d+bWeDYlo120POtaPqisZ4V/y7IVeSa7McvqR3jYIrLXRC9ZNr6hs8dkVrfdBI7 AOKTC+Q0wOZU8sd1x7YuCzouEsgQJZGQ9TSPvJUP2SS7Jnqlx8qN1KvJf7nVdqzwwhVK+fpc1438A uJdq958mH4W/scB4zFxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwuFy-00BtF5-PY; Mon, 13 Dec 2021 22:57:20 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwu9z-00Brox-Oh; Mon, 13 Dec 2021 22:51:09 +0000 Received: by mail-ot1-f42.google.com with SMTP id x19-20020a9d7053000000b0055c8b39420bso19090746otj.1; Mon, 13 Dec 2021 14:51:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TXNuhThSZzYh5dHlQEsy87eUYOOCcMvcopbthlMlzi0=; b=G2jaFwGbAO5ctRjdNDGHY4nWPR1dWjEuNrBheC2I7/3GUNkz/GsHxp9W3osnxCSDUR FnQbBg9lHjuDWCGvvtqyJasijR2wjVqHPJdLIoxOapG1KOrsOi6ijUpSBd2znTRupTuv wQvjDE52ZfzcYWINuRXjeyRgxc7JBPhXdGekcXrP8mVMtiaJ6WjGP46FEJZJ4ZNNyOjN xl/UsLz30lp5Kn6MJAECJcH63e0VagfuFLVzX/hPCTJQgJ7q+2bhcBdAajO2Yvo7Mm1j aac3QWglroOh/mb0Z9kSSAlRGz80gfJP97eLBlr5JAkHcW+4/0mRCBpWCQrVyRgymPfH aD4g== X-Gm-Message-State: AOAM531EIAmzEvIKk6JlHOJLc4HTGncYBdk7y/cW+5CBW+efAgvwUcYd 36yewyxdc68Jo3X1cRYO3w== X-Google-Smtp-Source: ABdhPJxCfZL3SzReunSYLPdv6bxyyePW0yFhigNTzi/mCZehsa7+8nCDGdg/U+lRD5jiU+CUp/zDpg== X-Received: by 2002:a9d:77d1:: with SMTP id w17mr1156068otl.329.1639435867068; Mon, 13 Dec 2021 14:51:07 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e4sm1490630oiy.12.2021.12.13.14.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 14:51:06 -0800 (PST) Received: (nullmailer pid 1725465 invoked by uid 1000); Mon, 13 Dec 2021 22:51:05 -0000 Date: Mon, 13 Dec 2021 16:51:05 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Sandy Huang , David Airlie , Daniel Vetter , - , David Heidelberg , ~okias/devicetree@lists.sr.ht, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI Message-ID: References: <20211206212651.126405-1-david@ixit.cz> <26502781.jAYDHVeSjN@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <26502781.jAYDHVeSjN@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_145107_856350_8D7144DB X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko St=FCbner wrote: > Hi David, > = > Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg: > > Convert into YAML format into format, which can be validated. > > = > > Changes: > > - drop panel from example > = > the patch subject is strange, talking about a "power domain node". > That needs a fix. > = > Some more things below. > = > = > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - rockchip,px30-mipi-dsi > > + - rockchip,rk3288-mipi-dsi > > + - rockchip,rk3399-mipi-dsi > > + - const: snps,dw-mipi-dsi > = > > + - items: > > + - const: rockchip,px30-mipi-dsi > > + - items: > > + - const: rockchip,rk3288-mipi-dsi > > + - items: > > + - const: rockchip,rk3399-mipi-dsi > = > what are these for? > = > I see that px30 uses the dsi without the snps part, but you > can also just add a patch adding that second compatible to px30.dtsi Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful. = But I guess that's more invasive so maybe stick with changing px30. > = > I don't think we need to support both ways. Agreed. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel