From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A924D68 for ; Wed, 15 Dec 2021 15:15:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA9B4C3461A; Wed, 15 Dec 2021 15:15:19 +0000 (UTC) Date: Wed, 15 Dec 2021 15:15:16 +0000 From: Catalin Marinas To: Ard Biesheuvel Cc: Nathan Chancellor , Arnd Bergmann , Linux ARM , Will Deacon , Mark Rutland , llvm@lists.linux.dev Subject: Re: [PATCH v2] arm64/xor: use EOR3 instructions when available Message-ID: References: <20211213140252.2856053-1-ardb@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 14, 2021 at 01:57:47PM +0100, Ard Biesheuvel wrote: > On Tue, 14 Dec 2021 at 12:36, Catalin Marinas wrote: > > On Tue, Dec 14, 2021 at 12:05:34PM +0100, Ard Biesheuvel wrote: > > > On Tue, 14 Dec 2021 at 09:19, Ard Biesheuvel wrote: > > > > On Tue, 14 Dec 2021 at 03:37, Nathan Chancellor wrote: > > > > > On Mon, Dec 13, 2021 at 03:02:52PM +0100, Ard Biesheuvel wrote: > > > > > > Use the EOR3 instruction to implement xor_blocks() if the instruction is > > > > > > available, which is the case if the CPU implements the SHA-3 extension. > > > > > > This is about 20% faster on Apple M1 when using the 5-way version. > > > > > > > > > > > > Signed-off-by: Ard Biesheuvel > > > > > > > > > > Our CI reported that this patch as commit ce9ba49a2460 ("arm64/xor: use > > > > > EOR3 instructions when available") in the arm64 tree breaks > > > > > allyesconfig: > > > > > > > > > > https://github.com/ClangBuiltLinux/continuous-integration2/runs/4514540083?check_suite_focus=true > > > > > > > > > > I also see this when building with GCC 11.2.0: > > > > > > > > > > WARNING: modpost: EXPORT symbol "xor_block_inner_neon" [vmlinux] version ... > > > > > Is "xor_block_inner_neon" prototyped in ? > > > > > aarch64-linux-gnu-ld: arch/arm64/lib/xor-neon.o: relocation R_AARCH64_ABS32 against `__crc_xor_block_inner_neon' can not be used when making a shared object > > > > > > > > I suspect this is another genksyms crash, preventing the > > > > __crc_xor_block_inner_neon symbol from ever being emitted. > > > > > > > > This is a recurring annoyance and I am not sure how to address this > > > > properly. Arnd might have some thoughts on the matter as well. > > > > > > I managed to reproduce this: it's not a crash but definitely a bug in > > > genksyms, as it simply fails to produce the output containing the > > > assignment of __crc_xor_block_inner_neon. > > > > > > Moving the definition of xor_block_inner_neon as below works around the issue. > > > > > > Catalin: would you like me to spin a v3? Or do your prefer to just > > > fold this into the existing one? > > > > I'll fold it in. Thanks. > > The root cause appears to be that genksyms gives up when it encounters > > static inline uint64x2_t eor3(uint64x2_t p, uint64x2_t q, uint64x2_t r) > { > > because the types are not defined. This is because our > asm/neon-intrinsics.h header avoids #include'ing arm-neon.h in the > context of genksyms, as doing so does result in a genksyms crash. > > I have very little motivation to go and figure out why genksyms > crashes in that case, so I think for now, we can stick with the fix I > proposed. Alternatively, we could typedef uint64x2_t to something > arbitrary if __GENKSYMS__ is defined, or use a macro instead of a > static inline for eor3() I'll stick to the fix you proposed (already folded in). If we ever add another EXPORT_SYMBOL after the eor3() function, we better look into fixing genksyms or defining a dummy uint64x2_t. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53C03C4332F for ; Wed, 15 Dec 2021 15:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MwgeEk4a6P6NmY551XT8uye+34jQwsA+4cDzLdkPaUo=; b=nPQsAb3fBLXXeT 87W53tPj0RVugvakBhfwAIQvLKvzzVbG7P0svKGsJkzZyrUeGtVWEMTdoqHw0P8H3Uen1RVnTZpKU F++1zMCJZN3LrRQsCisWQbBIvZYg62tlm4PHxaNjnQFbbG1g8PHWpNarCmE4uu+eeIK6FyMXh43bg IInMm7MTwHmNYCu2BMTReggAEb/0FtMXNH77Sz7YctodK5ikQUtuLXc3L+Ja/IVglojJjKq7Sj511 ykrovfssEljueLDwarUk5slzYfCylxMJOjHEfOh0uaSxApcUFoNBkmG1jBK4/eUfMIBselZNzukXf kqrc/OuZVzdmLmCVRcag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxWPx-001PIv-S8; Wed, 15 Dec 2021 15:42:10 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxWPt-001PHg-8Y for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 15:42:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C40DB82005; Wed, 15 Dec 2021 15:42:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA9B4C3461A; Wed, 15 Dec 2021 15:15:19 +0000 (UTC) Date: Wed, 15 Dec 2021 15:15:16 +0000 From: Catalin Marinas To: Ard Biesheuvel Cc: Nathan Chancellor , Arnd Bergmann , Linux ARM , Will Deacon , Mark Rutland , llvm@lists.linux.dev Subject: Re: [PATCH v2] arm64/xor: use EOR3 instructions when available Message-ID: References: <20211213140252.2856053-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_074205_604359_ABBED242 X-CRM114-Status: GOOD ( 33.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 14, 2021 at 01:57:47PM +0100, Ard Biesheuvel wrote: > On Tue, 14 Dec 2021 at 12:36, Catalin Marinas wrote: > > On Tue, Dec 14, 2021 at 12:05:34PM +0100, Ard Biesheuvel wrote: > > > On Tue, 14 Dec 2021 at 09:19, Ard Biesheuvel wrote: > > > > On Tue, 14 Dec 2021 at 03:37, Nathan Chancellor wrote: > > > > > On Mon, Dec 13, 2021 at 03:02:52PM +0100, Ard Biesheuvel wrote: > > > > > > Use the EOR3 instruction to implement xor_blocks() if the instruction is > > > > > > available, which is the case if the CPU implements the SHA-3 extension. > > > > > > This is about 20% faster on Apple M1 when using the 5-way version. > > > > > > > > > > > > Signed-off-by: Ard Biesheuvel > > > > > > > > > > Our CI reported that this patch as commit ce9ba49a2460 ("arm64/xor: use > > > > > EOR3 instructions when available") in the arm64 tree breaks > > > > > allyesconfig: > > > > > > > > > > https://github.com/ClangBuiltLinux/continuous-integration2/runs/4514540083?check_suite_focus=true > > > > > > > > > > I also see this when building with GCC 11.2.0: > > > > > > > > > > WARNING: modpost: EXPORT symbol "xor_block_inner_neon" [vmlinux] version ... > > > > > Is "xor_block_inner_neon" prototyped in ? > > > > > aarch64-linux-gnu-ld: arch/arm64/lib/xor-neon.o: relocation R_AARCH64_ABS32 against `__crc_xor_block_inner_neon' can not be used when making a shared object > > > > > > > > I suspect this is another genksyms crash, preventing the > > > > __crc_xor_block_inner_neon symbol from ever being emitted. > > > > > > > > This is a recurring annoyance and I am not sure how to address this > > > > properly. Arnd might have some thoughts on the matter as well. > > > > > > I managed to reproduce this: it's not a crash but definitely a bug in > > > genksyms, as it simply fails to produce the output containing the > > > assignment of __crc_xor_block_inner_neon. > > > > > > Moving the definition of xor_block_inner_neon as below works around the issue. > > > > > > Catalin: would you like me to spin a v3? Or do your prefer to just > > > fold this into the existing one? > > > > I'll fold it in. Thanks. > > The root cause appears to be that genksyms gives up when it encounters > > static inline uint64x2_t eor3(uint64x2_t p, uint64x2_t q, uint64x2_t r) > { > > because the types are not defined. This is because our > asm/neon-intrinsics.h header avoids #include'ing arm-neon.h in the > context of genksyms, as doing so does result in a genksyms crash. > > I have very little motivation to go and figure out why genksyms > crashes in that case, so I think for now, we can stick with the fix I > proposed. Alternatively, we could typedef uint64x2_t to something > arbitrary if __GENKSYMS__ is defined, or use a macro instead of a > static inline for eor3() I'll stick to the fix you proposed (already folded in). If we ever add another EXPORT_SYMBOL after the eor3() function, we better look into fixing genksyms or defining a dummy uint64x2_t. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel