From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC847C433EF for ; Wed, 15 Dec 2021 16:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244713AbhLOQiD (ORCPT ); Wed, 15 Dec 2021 11:38:03 -0500 Received: from mail-oi1-f171.google.com ([209.85.167.171]:33397 "EHLO mail-oi1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbhLOQiD (ORCPT ); Wed, 15 Dec 2021 11:38:03 -0500 Received: by mail-oi1-f171.google.com with SMTP id q25so32551333oiw.0 for ; Wed, 15 Dec 2021 08:38:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pyzDEpSOQgdCiOSbwrSV+3W9QMVtWPI913uVY3KbW+g=; b=vcMHS5Sfuii6RnTm1npXgl702ri796zI9Sn6FMubAjKbAl0yBqKmvwkInNr4fzM5rZ Hhrw3r4f7tOC26hlYokyHTP50+GCVIx+a+z6KY8c/It9hAAR7Gdak/9yrVUy7LszlycK RXaiIZdpbCDpYX/51DHLMkasxgXbF4Mfi/njtwAtflRo7GjXwXN/h/ywR+/hUSUw9+fY pJ102WjpQJN7QKAJ8tpd/Ar1KF7CIOkapwhdt659RfrW7hHuVPnY7leFM1w52v3yuF7N im9sKxLWAu1QUXeQJ1iLOQxc/MWhmBafk0CSuNs8GTDNjZXpCMpeyjlaoD2wTf5RZVk+ 3Cag== X-Gm-Message-State: AOAM532RJXxQ98YvTdtHzPcKnD7oCmznh83FQp+tkUk/PNr16y8Ks9GA nx3KgN2Zh4TZiqkinHXMCv4119dI9Q== X-Google-Smtp-Source: ABdhPJwchxUpomWZ84XMD8NECADxpL1WphGhTrDCmu+5xiuED9HghkfnDdHWfY06xUvJVQI/VrKNBA== X-Received: by 2002:aca:581:: with SMTP id 123mr574137oif.13.1639586282530; Wed, 15 Dec 2021 08:38:02 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id h1sm537374oog.26.2021.12.15.08.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:38:01 -0800 (PST) Received: (nullmailer pid 1441302 invoked by uid 1000); Wed, 15 Dec 2021 16:38:01 -0000 Date: Wed, 15 Dec 2021 10:38:01 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 10/18] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20211208151230.3695378-1-s.hauer@pengutronix.de> <20211208151230.3695378-11-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208151230.3695378-11-s.hauer@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 08, 2021 at 04:12:22PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 0000000000000..6533c4ae4ec3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk_vop > + - const: hclk_vop > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port Please describe what the port represents. > + > + assigned-clocks: > + maxItems: 2 > + > + assigned-clock-rates: > + maxItems: 2 > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: port { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0_out_dsi0: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dsi0_in_vp0>; > + }; > + vp0_out_hdmi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hdmi0_in_vp0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6AF7C433F5 for ; Wed, 15 Dec 2021 16:38:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E3D8810E320; Wed, 15 Dec 2021 16:38:04 +0000 (UTC) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id 468A810E278 for ; Wed, 15 Dec 2021 16:38:03 +0000 (UTC) Received: by mail-oi1-f176.google.com with SMTP id bj13so32457966oib.4 for ; Wed, 15 Dec 2021 08:38:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pyzDEpSOQgdCiOSbwrSV+3W9QMVtWPI913uVY3KbW+g=; b=mVzAWEoh4FairScVXBXbUYEt4gT4AbAmL0GJ34Wo6TmJpt1/cMrboMmvhl9U+FsD+t /Ln4KEATm+s+yZbiDDQyJolzViz9jFwPfChxl+ZsgLqgH7VTQNJtpeZpJxEYE2sJvRpN ngLA1RuBUyz9umMdTBcnVGIbVn5bKHdEkvn5mgmCjkLMI21+ofDLGA83wfo/W1RTnTnR IlkvPkdYFBCIZz8pzz1S88C0mwUH1HEMWxkiMMSMMWU6oPBnGCIbqSzKXR4kRx5cMuwH WaMeS7NmWMAJfzHNcNY0XhE08Fen1eTaJseC0+A0YY2UpFenOzDdwit6pm1F1dDty0d1 5BXw== X-Gm-Message-State: AOAM532hvm5+kwwdbO2jNGHZSmO6gDC3dhS8koQi/b3atD84UfzJbDLb bt8x3frU4lrxPOZaYh9J+g== X-Google-Smtp-Source: ABdhPJwchxUpomWZ84XMD8NECADxpL1WphGhTrDCmu+5xiuED9HghkfnDdHWfY06xUvJVQI/VrKNBA== X-Received: by 2002:aca:581:: with SMTP id 123mr574137oif.13.1639586282530; Wed, 15 Dec 2021 08:38:02 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id h1sm537374oog.26.2021.12.15.08.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:38:01 -0800 (PST) Received: (nullmailer pid 1441302 invoked by uid 1000); Wed, 15 Dec 2021 16:38:01 -0000 Date: Wed, 15 Dec 2021 10:38:01 -0600 From: Rob Herring To: Sascha Hauer Subject: Re: [PATCH 10/18] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20211208151230.3695378-1-s.hauer@pengutronix.de> <20211208151230.3695378-11-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208151230.3695378-11-s.hauer@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Dec 08, 2021 at 04:12:22PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 0000000000000..6533c4ae4ec3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk_vop > + - const: hclk_vop > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port Please describe what the port represents. > + > + assigned-clocks: > + maxItems: 2 > + > + assigned-clock-rates: > + maxItems: 2 > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: port { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0_out_dsi0: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dsi0_in_vp0>; > + }; > + vp0_out_hdmi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hdmi0_in_vp0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A32EC433EF for ; Wed, 15 Dec 2021 16:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CLm9xjrDT0Eth4/zDuCYXlPEOST7IbDTYpZ9EEH82ww=; b=eNt5cGt1yCrCfG RtvPDhJWy/rJt78r/0s7d3sd7oX/oDdktVr2rdtyGZddUZ0BOv3EFXipmKR3dJY/s7c+oAUSvTElL QJ0+t+rd/7tO95bwTvdRIhkpPtGN2pwX+ozQslFD2dVy97uHeTpXQILtDWtRw6FlyzYtB7AiA6IvQ WDnq2Fx9A8L2Up+IMqqr/TbPjdt8d7RfQqmAS6n/2qn7nQTV37m7ZYlNGzL5EZoKgV5BE1EcoPbOg a6yrMeNoyUa7J2fS83HJxGrCRjUmSuC0dUzUorKiPqssjusQJFUZQGJgAhTtmXW0qQ9dvhaX16GXH vbqTAgj//KxxND3FBfJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxXd0-001unl-NW; Wed, 15 Dec 2021 16:59:42 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxXI4-001mBW-8v; Wed, 15 Dec 2021 16:38:06 +0000 Received: by mail-oi1-f175.google.com with SMTP id r26so32410440oiw.5; Wed, 15 Dec 2021 08:38:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pyzDEpSOQgdCiOSbwrSV+3W9QMVtWPI913uVY3KbW+g=; b=MrKC0DZrDfAyhViPsMGZIk933NOj+ckvvS+JB3HvGFlYLvDBxTWURvfIo83ON4sy5v PEBFKIoZM7OyX2ylAzUmGA7vbBfI350pORxGN6RNBKaJq3swp2fCsQEB6JQYTQbIeC2g W5lXeCK87tHaGRJKL80BXgNqjxm/dSaLjZK7OdmhzfXXFGxfaXh4zsqxnL/K80uJMzpb wcSl6OtdQLhPYPgulcY1sr8WI67wcOT4sw99VnXIgYyWemhFgMCGzpS2WM4+Bsr8BdxO 7oBOH2Mit4P5h5RQgSgJnRbLB1bxBpnHcETXg+EYc9MKBU6+U2VOMhjIinVgPkEVjdBd JXCQ== X-Gm-Message-State: AOAM532Vm3rg/tZH+Ws5bbJVxQETfXL/aLdlIzDqObG29CXzzOIjXeWt uZa/mfL8P1Hk29RRfb1ygw== X-Google-Smtp-Source: ABdhPJwchxUpomWZ84XMD8NECADxpL1WphGhTrDCmu+5xiuED9HghkfnDdHWfY06xUvJVQI/VrKNBA== X-Received: by 2002:aca:581:: with SMTP id 123mr574137oif.13.1639586282530; Wed, 15 Dec 2021 08:38:02 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id h1sm537374oog.26.2021.12.15.08.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:38:01 -0800 (PST) Received: (nullmailer pid 1441302 invoked by uid 1000); Wed, 15 Dec 2021 16:38:01 -0000 Date: Wed, 15 Dec 2021 10:38:01 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 10/18] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20211208151230.3695378-1-s.hauer@pengutronix.de> <20211208151230.3695378-11-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211208151230.3695378-11-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_083804_394133_C0A9B792 X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Dec 08, 2021 at 04:12:22PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 0000000000000..6533c4ae4ec3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk_vop > + - const: hclk_vop > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port Please describe what the port represents. > + > + assigned-clocks: > + maxItems: 2 > + > + assigned-clock-rates: > + maxItems: 2 > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: port { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0_out_dsi0: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dsi0_in_vp0>; > + }; > + vp0_out_hdmi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hdmi0_in_vp0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46F08C433EF for ; Wed, 15 Dec 2021 17:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xok8eSLwO+oXHaltwx3C6i3DYQFOqjObaFLoT6OIkOs=; b=L5fo0s/5e1rnu4 InRCzn9eEAw8uBlvR0EgIzSI88A+0Lq4oK46I2YNA5RmZXvtpoJD/npWGl2RE3M205lDUH1KVEHa2 wY9PkV+a3/p/sCaGmqMWkX3LtAU7SzWwPpfujLbDwEsPrXD+Cwu9QS/NGm5LsooixVLmT1v1FhY9D gPifcIx8W1bVZ07wUCtY7LYeBIFzu03pjNCuova6INq97QKfONPQHjNygCkzgB8SpRWkty8TBdl7i zCP+mDmqDG6yqoAPhCOK67tBLQeOwVw9P8brpynKJ4iCucB4jDTulQT5WfTmRz/TWd3Iw0EJyU86N pfdW+1aLVV2vGtjgdiug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxXbi-001uFY-Mb; Wed, 15 Dec 2021 16:58:24 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxXI4-001mBW-8v; Wed, 15 Dec 2021 16:38:06 +0000 Received: by mail-oi1-f175.google.com with SMTP id r26so32410440oiw.5; Wed, 15 Dec 2021 08:38:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pyzDEpSOQgdCiOSbwrSV+3W9QMVtWPI913uVY3KbW+g=; b=MrKC0DZrDfAyhViPsMGZIk933NOj+ckvvS+JB3HvGFlYLvDBxTWURvfIo83ON4sy5v PEBFKIoZM7OyX2ylAzUmGA7vbBfI350pORxGN6RNBKaJq3swp2fCsQEB6JQYTQbIeC2g W5lXeCK87tHaGRJKL80BXgNqjxm/dSaLjZK7OdmhzfXXFGxfaXh4zsqxnL/K80uJMzpb wcSl6OtdQLhPYPgulcY1sr8WI67wcOT4sw99VnXIgYyWemhFgMCGzpS2WM4+Bsr8BdxO 7oBOH2Mit4P5h5RQgSgJnRbLB1bxBpnHcETXg+EYc9MKBU6+U2VOMhjIinVgPkEVjdBd JXCQ== X-Gm-Message-State: AOAM532Vm3rg/tZH+Ws5bbJVxQETfXL/aLdlIzDqObG29CXzzOIjXeWt uZa/mfL8P1Hk29RRfb1ygw== X-Google-Smtp-Source: ABdhPJwchxUpomWZ84XMD8NECADxpL1WphGhTrDCmu+5xiuED9HghkfnDdHWfY06xUvJVQI/VrKNBA== X-Received: by 2002:aca:581:: with SMTP id 123mr574137oif.13.1639586282530; Wed, 15 Dec 2021 08:38:02 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id h1sm537374oog.26.2021.12.15.08.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:38:01 -0800 (PST) Received: (nullmailer pid 1441302 invoked by uid 1000); Wed, 15 Dec 2021 16:38:01 -0000 Date: Wed, 15 Dec 2021 10:38:01 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 10/18] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20211208151230.3695378-1-s.hauer@pengutronix.de> <20211208151230.3695378-11-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211208151230.3695378-11-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_083804_394133_C0A9B792 X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 08, 2021 at 04:12:22PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 0000000000000..6533c4ae4ec3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk_vop > + - const: hclk_vop > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port Please describe what the port represents. > + > + assigned-clocks: > + maxItems: 2 > + > + assigned-clock-rates: > + maxItems: 2 > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: port { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0_out_dsi0: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dsi0_in_vp0>; > + }; > + vp0_out_hdmi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hdmi0_in_vp0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel