From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3476C4332F for ; Thu, 30 Dec 2021 10:40:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238638AbhL3Kkn (ORCPT ); Thu, 30 Dec 2021 05:40:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238514AbhL3Kkm (ORCPT ); Thu, 30 Dec 2021 05:40:42 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FA60C061574; Thu, 30 Dec 2021 02:40:42 -0800 (PST) Received: from zn.tnic (dslb-088-067-202-008.088.067.pools.vodafone-ip.de [88.67.202.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CF5641EC04FB; Thu, 30 Dec 2021 11:40:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1640860836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=hMCPTeDnIJ9H9jmkzRtiX1XZPABKFjQELYVZLBGOkB4=; b=aIY2V3d9y9BrUI1nNsTxU5QvqX4XueKqqpzBbQwO68S1IeZtvRneqZXH0DlSQI5B2vI4Ex hdYb7fth4mOeb4TfAX13SLZ0cnW9oAWs3VYRVOmhdXjzVQKFRgBoV3yjAbEemDB+6rOTUs 92CdA3L1MP0CVaH82oAiJ1ypb8xz9OM= Date: Thu, 30 Dec 2021 11:40:38 +0100 From: Borislav Petkov To: "Leizhen (ThunderTown)" Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly Subject: Re: [PATCH v19 01/13] kdump: add helper parse_crashkernel_high_low() Message-ID: References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-2-thunder.leizhen@huawei.com> <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 30, 2021 at 06:14:59PM +0800, Leizhen (ThunderTown) wrote: > > Hi, Dave, Baoquan, Borislav: > What do you think about the introduction of parse_crashkernel_high_low()? If everyone > doesn't object, I'll bring it to the next version. But I'll make some adjustments to the > patches, see below. If there's any objection, I still strongly recommend removing the > parameters "system_ram" and "crash_base" of parse_crashkernel_{high,low}(). > > How about splitting __parse_crashkernel() into two parts? One for parsing > "crashkernel=X[@offset]", another one for parsing "crashkernel=X,{high,low}" and other > suffixes in the future. So the parameter requirements are clear at the lowest level. First of all, please do not top post! Now, I already explained to you what I'd like to see: https://lore.kernel.org/r/Ycs3kpZD/vpoo1AX@zn.tnic yet you still don't get it. So let me make myself clear: in its current form, this is not really an improvement so for all x86 changes: NAKed-by: Borislav Petkov -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8DD5C433F5 for ; Thu, 30 Dec 2021 10:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iGu38JKS2oe1T9Yo6zCAzoEJHAaCLVuNDhNpZnj57F4=; b=VOE8WOX03t1Wrt 5MKxL5JY9U4GxioI0ZmI7rkWWIOa5q5gCjxAK0z3D5BbPssNz62EQ0LtvkdljYT8CKC2CGaVpHAL2 57nnMEiR+ywWKQFAk6Xc3+eSNdawX/f6LJx5CKMuytJ2D6BVK3IN1CCAb9YsPu4bPSzgxs0F4ZRAh QyO7swKIEdLuE1TG7LxcBy8GHTUuu69x/J6V+vc2d9Qn0IGsiS5PXM+gFXa7huaKLEprnzJ5ePIvh PxXJ46ue2aLKNAYIqcVJ5S/KT+iCDudSJcn7l8gs4CEOkuMfsJpjYF+Y7ztR3QKgua0EVq8rNH3CI GnQx713AIg8ppjeSBrvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2srY-004ERU-ST; Thu, 30 Dec 2021 10:40:49 +0000 Received: from mail.skyhub.de ([5.9.137.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2srT-004EQR-VA; Thu, 30 Dec 2021 10:40:45 +0000 Received: from zn.tnic (dslb-088-067-202-008.088.067.pools.vodafone-ip.de [88.67.202.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CF5641EC04FB; Thu, 30 Dec 2021 11:40:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1640860836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=hMCPTeDnIJ9H9jmkzRtiX1XZPABKFjQELYVZLBGOkB4=; b=aIY2V3d9y9BrUI1nNsTxU5QvqX4XueKqqpzBbQwO68S1IeZtvRneqZXH0DlSQI5B2vI4Ex hdYb7fth4mOeb4TfAX13SLZ0cnW9oAWs3VYRVOmhdXjzVQKFRgBoV3yjAbEemDB+6rOTUs 92CdA3L1MP0CVaH82oAiJ1ypb8xz9OM= Date: Thu, 30 Dec 2021 11:40:38 +0100 From: Borislav Petkov To: "Leizhen (ThunderTown)" Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly Subject: Re: [PATCH v19 01/13] kdump: add helper parse_crashkernel_high_low() Message-ID: References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-2-thunder.leizhen@huawei.com> <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_024044_189504_273E1EEF X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 30, 2021 at 06:14:59PM +0800, Leizhen (ThunderTown) wrote: > > Hi, Dave, Baoquan, Borislav: > What do you think about the introduction of parse_crashkernel_high_low()? If everyone > doesn't object, I'll bring it to the next version. But I'll make some adjustments to the > patches, see below. If there's any objection, I still strongly recommend removing the > parameters "system_ram" and "crash_base" of parse_crashkernel_{high,low}(). > > How about splitting __parse_crashkernel() into two parts? One for parsing > "crashkernel=X[@offset]", another one for parsing "crashkernel=X,{high,low}" and other > suffixes in the future. So the parameter requirements are clear at the lowest level. First of all, please do not top post! Now, I already explained to you what I'd like to see: https://lore.kernel.org/r/Ycs3kpZD/vpoo1AX@zn.tnic yet you still don't get it. So let me make myself clear: in its current form, this is not really an improvement so for all x86 changes: NAKed-by: Borislav Petkov -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Thu, 30 Dec 2021 11:40:38 +0100 From: Borislav Petkov Subject: Re: [PATCH v19 01/13] kdump: add helper parse_crashkernel_high_low() Message-ID: References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-2-thunder.leizhen@huawei.com> <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Leizhen (ThunderTown)" Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly On Thu, Dec 30, 2021 at 06:14:59PM +0800, Leizhen (ThunderTown) wrote: > > Hi, Dave, Baoquan, Borislav: > What do you think about the introduction of parse_crashkernel_high_low()? If everyone > doesn't object, I'll bring it to the next version. But I'll make some adjustments to the > patches, see below. If there's any objection, I still strongly recommend removing the > parameters "system_ram" and "crash_base" of parse_crashkernel_{high,low}(). > > How about splitting __parse_crashkernel() into two parts? One for parsing > "crashkernel=X[@offset]", another one for parsing "crashkernel=X,{high,low}" and other > suffixes in the future. So the parameter requirements are clear at the lowest level. First of all, please do not top post! Now, I already explained to you what I'd like to see: https://lore.kernel.org/r/Ycs3kpZD/vpoo1AX@zn.tnic yet you still don't get it. So let me make myself clear: in its current form, this is not really an improvement so for all x86 changes: NAKed-by: Borislav Petkov -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec