From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD74C433F5 for ; Thu, 30 Dec 2021 23:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242333AbhL3XCg (ORCPT ); Thu, 30 Dec 2021 18:02:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhL3XCg (ORCPT ); Thu, 30 Dec 2021 18:02:36 -0500 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42B2C061574; Thu, 30 Dec 2021 15:02:35 -0800 (PST) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n34RM-00G5x6-LO; Thu, 30 Dec 2021 23:02:32 +0000 Date: Thu, 30 Dec 2021 23:02:32 +0000 From: Al Viro To: Jens Axboe Cc: Christian Brauner , Stefan Roesch , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@fb.com, torvalds@linux-foundation.org Subject: Re: [PATCH v10 4/5] io_uring: add fsetxattr and setxattr support Message-ID: References: <20211229203002.4110839-1-shr@fb.com> <20211229203002.4110839-5-shr@fb.com> <20211230101242.j6jzxc4ahmx2plqx@wittgenstein> <20211230180114.vuum3zorhafd2zta@wittgenstein> <5030f5fa-79c3-b3b7-857d-3ac62bf2b982@kernel.dk> <961974f9-5eb4-1289-2724-0e6c3faf0434@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <961974f9-5eb4-1289-2724-0e6c3faf0434@kernel.dk> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Dec 30, 2021 at 02:46:49PM -0800, Jens Axboe wrote: > On 12/30/21 2:24 PM, Al Viro wrote: > > On Thu, Dec 30, 2021 at 11:09:12AM -0800, Jens Axboe wrote: > > > >> For each command, there are two steps: > >> > >> - The prep of it, this happens inline from the system call where the > >> request, or requests, are submitted. The prep phase should ensure that > >> argument structs are stable. Hence a caller can prep a request and > >> have memory on stack, as long as it submits before it becomes invalid. > >> An example of that are iovecs for readv/writev. The caller does not > >> need to have them stable for the duration of the request, just across > >> submit. That's the io_${cmd}_prep() helpers. > >> > >> - The execution of it. May be separate from prep and from an async > >> worker. Where the lower layers don't support a nonblocking attempt, > >> they are always done async. The statx stuff is an example of that. > >> > >> Hence prep needs to copy from userland on the prep side always for the > >> statx family, as execution will happen out-of-line from the submission. > >> > >> Does that explain it? > > > > The actual call chain leading to filename_lookup() is, AFAICS, this: > > io_statx() > > do_statx() > > vfs_statx() > > user_path_at() > > user_path_at_empty() > > filename_lookup() > > > > If you are providing such warranties for the contents of pathname > > arguments, you have a bug in statx in the mainline. If you are not, > > there's no point in doing getname() in getxattr prep. > > Not for the filename lookup, as I said it's for data passed in. There > are no guarantees on filename lookup, that happens when it gets > executed. See mentioned example on iovec and readv/writev. s/filename_lookup/getname_flags/, sorry. Again, statx support does both the copyin and pathname resolution *after* prep, from io_statx(). They are not separated - io_statx() pass the userland pointer to user_path_at_empty(), which does all the work. So if a pathname you'd passed had been in a local array and you return right after submitting a request, you will end up with io_statx() fetching random garbage. This patchset is different - for getxattr you have getname done in prep, with resulting struct filename kept around until the actual work is to be done. That's precisely the reason why the first patch in the series introduces a user_path_at_empty() variant that takes a struct filename, with the pathname contents already copied in. IOW, why is user_path_at_empty() good for statx, but not for getxattr? What's the difference? Do you treat the pathname contents (string in userland memory, that is) same way your writev support treats iovec array (caller may discard it as soon as syscall returns) or the same way it treats the actual data to be written (caller is responsible for keeping it around until the operation reports completion)?