From: Mark Brown <broonie@kernel.org> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner <heiko@sntech.de>, Michael Riesch <michael.riesch@wolfvision.net>, kernel@pengutronix.de, Robin Murphy <robin.murphy@arm.com> Subject: Re: [PATCH 3/4] soc: rockchip: power-domain: Add regulator support Date: Mon, 20 Dec 2021 12:53:58 +0000 [thread overview] Message-ID: <YcB85mzJHrirUEDA@sirena.org.uk> (raw) In-Reply-To: <20211220094435.GU6003@pengutronix.de> [-- Attachment #1.1: Type: text/plain, Size: 1369 bytes --] On Mon, Dec 20, 2021 at 10:44:35AM +0100, Sascha Hauer wrote: > Well, all true and on one specific board the regulator is indeed not > optional. However, on all other power domains that don't need a > regulator and all other boards and all other SoCs this driver is used we > now get: This seems unlikely to be board specific, if the chip requires power the chip requires power. If there are power domains that don't take external supplies then they shouldn't be requesting any regulators and should be fixed. > [ 0.185588] rk-power-domain rk-power-domain.8: supply power not found, using dummy regulator It seems vanishingly unlikely that the SoC takes a single supply called "power" shared by everything in the SoC but that is what the code appears to be requesting - the power domains should be requesting the supplies they actually use, and as ever the supplies should be named such that someone looking at the schematic can hook them up. The general recommendation is to use the names used in the datasheet. > I wonder if devm_regulator_get() is really the right function here. Or > should the message be dropped? No, the issue is that the client driver is badly written and needs to be fixed. In general it's probably better to have error handling than not. If you're getting lots of warnings about problems it's probably due to there being problems. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner <heiko@sntech.de>, Michael Riesch <michael.riesch@wolfvision.net>, kernel@pengutronix.de, Robin Murphy <robin.murphy@arm.com> Subject: Re: [PATCH 3/4] soc: rockchip: power-domain: Add regulator support Date: Mon, 20 Dec 2021 12:53:58 +0000 [thread overview] Message-ID: <YcB85mzJHrirUEDA@sirena.org.uk> (raw) In-Reply-To: <20211220094435.GU6003@pengutronix.de> [-- Attachment #1.1: Type: text/plain, Size: 1369 bytes --] On Mon, Dec 20, 2021 at 10:44:35AM +0100, Sascha Hauer wrote: > Well, all true and on one specific board the regulator is indeed not > optional. However, on all other power domains that don't need a > regulator and all other boards and all other SoCs this driver is used we > now get: This seems unlikely to be board specific, if the chip requires power the chip requires power. If there are power domains that don't take external supplies then they shouldn't be requesting any regulators and should be fixed. > [ 0.185588] rk-power-domain rk-power-domain.8: supply power not found, using dummy regulator It seems vanishingly unlikely that the SoC takes a single supply called "power" shared by everything in the SoC but that is what the code appears to be requesting - the power domains should be requesting the supplies they actually use, and as ever the supplies should be named such that someone looking at the schematic can hook them up. The general recommendation is to use the names used in the datasheet. > I wonder if devm_regulator_get() is really the right function here. Or > should the message be dropped? No, the issue is that the client driver is badly written and needs to be fixed. In general it's probably better to have error handling than not. If you're getting lots of warnings about problems it's probably due to there being problems. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-20 12:54 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-17 13:09 [PATCH 0/4] soc: rockchip: power-domain: Add regulator support Sascha Hauer 2021-12-17 13:09 ` Sascha Hauer 2021-12-17 13:09 ` [PATCH 1/4] soc: rockchip: power-domain: register device for each domain Sascha Hauer 2021-12-17 13:09 ` Sascha Hauer 2021-12-17 13:09 ` [PATCH 2/4] soc: rockchip: power-domain: Use devm_clk_bulk_get_all() Sascha Hauer 2021-12-17 13:09 ` Sascha Hauer 2021-12-17 13:09 ` [PATCH 3/4] soc: rockchip: power-domain: Add regulator support Sascha Hauer 2021-12-17 13:09 ` Sascha Hauer 2021-12-20 9:44 ` Sascha Hauer 2021-12-20 9:44 ` Sascha Hauer 2021-12-20 10:46 ` Robin Murphy 2021-12-20 10:46 ` Robin Murphy 2021-12-20 12:56 ` Mark Brown 2021-12-20 12:56 ` Mark Brown 2021-12-20 12:53 ` Mark Brown [this message] 2021-12-20 12:53 ` Mark Brown 2021-12-22 10:40 ` Sascha Hauer 2021-12-22 10:40 ` Sascha Hauer 2021-12-22 12:54 ` Robin Murphy 2021-12-22 12:54 ` Robin Murphy 2021-12-22 13:00 ` Mark Brown 2021-12-22 13:00 ` Mark Brown 2021-12-22 13:19 ` Robin Murphy 2021-12-22 13:19 ` Robin Murphy 2021-12-22 13:25 ` Mark Brown 2021-12-22 13:25 ` Mark Brown 2021-12-22 13:29 ` Michael Riesch 2021-12-22 13:29 ` Michael Riesch 2021-12-22 13:37 ` Michael Riesch 2021-12-22 13:40 ` Mark Brown 2021-12-22 13:40 ` Mark Brown 2022-02-23 8:51 ` Michael Riesch 2022-02-23 8:51 ` Michael Riesch 2021-12-17 13:09 ` [PATCH 4/4] dt-bindings: power: rockchip: Add power-supply to domain nodes Sascha Hauer 2021-12-17 13:09 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YcB85mzJHrirUEDA@sirena.org.uk \ --to=broonie@kernel.org \ --cc=heiko@sntech.de \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=michael.riesch@wolfvision.net \ --cc=robin.murphy@arm.com \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.