From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B956EC433F5 for ; Mon, 20 Dec 2021 23:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233092AbhLTXmY (ORCPT ); Mon, 20 Dec 2021 18:42:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbhLTXmX (ORCPT ); Mon, 20 Dec 2021 18:42:23 -0500 Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9838BC061574 for ; Mon, 20 Dec 2021 15:42:23 -0800 (PST) Received: by mail-oo1-xc2c.google.com with SMTP id w5-20020a4a2745000000b002c2649b8d5fso3530320oow.10 for ; Mon, 20 Dec 2021 15:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fXyd48HL5YcTwRMzoww9SwKMCubtA4ei6Uf/z8oQfp4=; b=iRt1HjN1A1nyl7nMT+kA2MTBeejr1ApoIV9IiI1uWesGK2AwYegyzKXvni9c1zB765 nUiP77H4xmD0le8Lw2pufiiRtDMKbkAYJK6Tz20GxiDs0+8vg3zno+3TGGaLYrUS5Xpq CD2eu0a9FRhLF5VB6cDDttJAZMsBvIIR8A0TmmqwkaRxE+IdzYcdVI7Nbl1xvNivTIa1 0lxlgxjIsAomn08fto5yhgQtmkRKIFuxKzD6ZcgULARZdqgVMuDMXv5e88AAgnVZ6+ik 8VidKPbaeuidmipgousjH3UL1Y/Ts0Z4OEh3ktJUCM6YxC4EYyoUwIZOaEjaJNN8ys9r ydPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fXyd48HL5YcTwRMzoww9SwKMCubtA4ei6Uf/z8oQfp4=; b=Bl3KZ5EbbYeEwI8ZmGK7ImzL5Cp8408pz12faDSMvtuqs66y3tjyNxs3vuvYWmkBl1 x99Eln9wN4lTqh4TpzBlEn3aiAflOnNFimp5tOtB4MavxRnpupwRnN5soS+JAJyrgvYC xHYVL12YablWOLIwEyRDLBflQ+d89IDNGBfy7Wc1lroJdjwn+D3ewneTO+B4JWNsyTRE KhT6JhdeTawCb9+uwW+zp7ewsKDM7PZbiRYQCJHjo9sI/n/Ez4QPsEkv8cZG5ukzo8c5 XGCGwCVOcgLAe4FpXq/rqX8BF8QXfuJ5+3wq1Rfb8aYIfK9Vp60tQF7IVjveO8ZtX4Zj WWFQ== X-Gm-Message-State: AOAM532l+6N5WfGBCdE00Cdb12FDl2jJr+vQjFrrweT8SfMmlfxxCqxk UsPBOIJr8JrU5YAgzTxuHA4THHXiM+pTgg== X-Google-Smtp-Source: ABdhPJwRDVXCRDJMAtfGL+pL+4iUwEl3wgGD7/CYswUfCpak+pmJgKFfARFDxMz1HxTkzfZwsAFaqw== X-Received: by 2002:a05:6820:1609:: with SMTP id bb9mr307552oob.37.1640043742930; Mon, 20 Dec 2021 15:42:22 -0800 (PST) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n23sm3668243oig.4.2021.12.20.15.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 15:42:22 -0800 (PST) Date: Mon, 20 Dec 2021 15:43:31 -0800 From: Bjorn Andersson To: Loic Poulain Cc: Andy Gross , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Thara Gopinath , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name Message-ID: References: <20210901084732.943248-1-ardb@kernel.org> <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 20 Dec 02:12 PST 2021, Loic Poulain wrote: > > On 9/1/21 4:47 AM, Ard Biesheuvel wrote: > > > Registering an IRQ requires the string buffer containing the name to > > > remain allocated, as the name is not copied into another buffer. > > > > > > So let's add a irq_name field to the data struct instead, which is > > > guaranteed to have the appropriate lifetime. > > > > > > Cc: Thara Gopinath > > > Cc: Bjorn Andersson > > > Cc: Andy Gross > > > Cc: linux-arm-msm@vger.kernel.org > > > Signed-off-by: Ard Biesheuvel > > > > Thanks for the fix. > > > > Reviewed-by: Thara Gopinath > > Seems this patch has been overlooked. Would it be possible to resubmit > it with a 'Fixes' tag? > This was resubmitted by Vladimir and Viresh replied that it's applied, see: https://lore.kernel.org/all/20211125065014.phkfugo2wptosrgv@vireshk-i7/ Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 538B5C433EF for ; Mon, 20 Dec 2021 23:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9OI1Nm9y+Hk8hAARa2lEMh13kaEnjISNr/LHAGh3Noc=; b=qq74XSdGl1KW1d /q1W+qHpxgFhrxvnNx4D5BexBohHBjYPqVaqLdLfrhCzhdwJOJyjkDFFnzkaoZOPDxqfeb3taRSBu B312OJMalwDQfBYuZmIHHGysrvyVLRx/KTBTTvLtY2ROSoL5OUnz6MVRHlVKSx8rk2AYk72Xc1Zkp ctNsJ/3QixnDxYCely71DGxvPDIHqZesYJh38qxgD/UUZcX4sZerqesw900tCOBO4pDgek4vIi8Ta CLFAQuMKnQJQahIbZ66QVLyYOYpkwBDoFjE8PDluKle1WkMerfvaGRBZnHNWLnjqzi/AWOcXMf4/1 LuiFUlD5ZFHW6dVjZvDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzSIV-004xhc-R9; Mon, 20 Dec 2021 23:42:28 +0000 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzSIS-004xgw-JQ for linux-arm-kernel@lists.infradead.org; Mon, 20 Dec 2021 23:42:26 +0000 Received: by mail-oo1-xc2b.google.com with SMTP id d1-20020a4a3c01000000b002c2612c8e1eso3536545ooa.6 for ; Mon, 20 Dec 2021 15:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fXyd48HL5YcTwRMzoww9SwKMCubtA4ei6Uf/z8oQfp4=; b=iRt1HjN1A1nyl7nMT+kA2MTBeejr1ApoIV9IiI1uWesGK2AwYegyzKXvni9c1zB765 nUiP77H4xmD0le8Lw2pufiiRtDMKbkAYJK6Tz20GxiDs0+8vg3zno+3TGGaLYrUS5Xpq CD2eu0a9FRhLF5VB6cDDttJAZMsBvIIR8A0TmmqwkaRxE+IdzYcdVI7Nbl1xvNivTIa1 0lxlgxjIsAomn08fto5yhgQtmkRKIFuxKzD6ZcgULARZdqgVMuDMXv5e88AAgnVZ6+ik 8VidKPbaeuidmipgousjH3UL1Y/Ts0Z4OEh3ktJUCM6YxC4EYyoUwIZOaEjaJNN8ys9r ydPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fXyd48HL5YcTwRMzoww9SwKMCubtA4ei6Uf/z8oQfp4=; b=mKDlf7PlSpMKsLQqwdDxJo+TQfr9v0Mg3oqsyHAnDwzArsHFzlx3fc6DowovQ/xvne 0XsEsK95iNQG89fWzP8gLEXt73afUXCxAERZ2fjZ0CDUUBRKsmNlHOyOX38JPLPy2XkP faxvTLFgtsuaQ99bKuatNIaB9oEJUYqoIVYahHQo0RPtwYllSOtghyKV1ZJHVzkl+8np XD9lojz4ii43h6y/w9rWk01s6z7jf0OYPN2fgpq7D9s+DNbB2lxLdtYnK/JUBKytsVzD 6zMIgt0AgDKWlHiEfAxU0Np/o25yCAh32DTzGo7+oIv+9LhnRJii1RCJXwICJWd2MiF1 34cA== X-Gm-Message-State: AOAM530KJIe2Us82s5XqzZmB1EN8TNrg29HmCg1VzPFbuQo872fSkLlJ 6cxmIo3G2+RK++tQ23Dry4meMw== X-Google-Smtp-Source: ABdhPJwRDVXCRDJMAtfGL+pL+4iUwEl3wgGD7/CYswUfCpak+pmJgKFfARFDxMz1HxTkzfZwsAFaqw== X-Received: by 2002:a05:6820:1609:: with SMTP id bb9mr307552oob.37.1640043742930; Mon, 20 Dec 2021 15:42:22 -0800 (PST) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n23sm3668243oig.4.2021.12.20.15.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 15:42:22 -0800 (PST) Date: Mon, 20 Dec 2021 15:43:31 -0800 From: Bjorn Andersson To: Loic Poulain Cc: Andy Gross , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Thara Gopinath , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name Message-ID: References: <20210901084732.943248-1-ardb@kernel.org> <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_154224_726794_AB8B3BAD X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 20 Dec 02:12 PST 2021, Loic Poulain wrote: > > On 9/1/21 4:47 AM, Ard Biesheuvel wrote: > > > Registering an IRQ requires the string buffer containing the name to > > > remain allocated, as the name is not copied into another buffer. > > > > > > So let's add a irq_name field to the data struct instead, which is > > > guaranteed to have the appropriate lifetime. > > > > > > Cc: Thara Gopinath > > > Cc: Bjorn Andersson > > > Cc: Andy Gross > > > Cc: linux-arm-msm@vger.kernel.org > > > Signed-off-by: Ard Biesheuvel > > > > Thanks for the fix. > > > > Reviewed-by: Thara Gopinath > > Seems this patch has been overlooked. Would it be possible to resubmit > it with a 'Fixes' tag? > This was resubmitted by Vladimir and Viresh replied that it's applied, see: https://lore.kernel.org/all/20211125065014.phkfugo2wptosrgv@vireshk-i7/ Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel