All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 1/3] lib: add functions to adjust oom score
Date: Tue, 21 Dec 2021 11:44:28 +0100	[thread overview]
Message-ID: <YcGwDKmi+iQuw3fS@pevik> (raw)
In-Reply-To: <YcGuIJql99Row3o9@yuki>

> Hi!
> > So, I will push (the improved) code like below, after getting
> > Petr and you ack again:

> > +static void set_oom_score_adj(pid_t pid, int value)
> > +{
> > +       int val;
> > +       char score_path[64];
> > +
> > +       if (access("/proc/self/oom_score_adj", F_OK) == -1) {
> > +               tst_res(TINFO, "Warning: oom_score_adj does not exist,
> > +                               skipping the adjustement");

> I'm not sure about the "Warning:" in this message, I would just dully
> informed the user that the interface is not available.

I'd also prefer not having to print "Warning:" in TINFO message
(I know TWARN exit non-zero).

Kind regards,
Petr


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-12-21 10:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  9:54 [LTP] [PATCH v3 1/3] lib: add functions to adjust oom score Li Wang
2021-12-20  9:54 ` [LTP] [PATCH v3 2/3] lib: enable OOM protection for ltp lib process Li Wang
2021-12-20 13:26   ` Cyril Hrubis
2021-12-20  9:54 ` [LTP] [PATCH v3 3/3] oom: enable OOM protection for mem " Li Wang
2021-12-20 13:27   ` Cyril Hrubis
2021-12-20 13:26 ` [LTP] [PATCH v3 1/3] lib: add functions to adjust oom score Cyril Hrubis
2021-12-20 18:13 ` Petr Vorel
2021-12-20 18:34 ` Petr Vorel
2021-12-21  2:50   ` Li Wang
2021-12-21  8:33     ` Petr Vorel
2021-12-21  9:18     ` Cyril Hrubis
2021-12-21  9:23       ` Li Wang
2021-12-21  9:40         ` Li Wang
2021-12-21  9:59         ` Cyril Hrubis
2021-12-21 10:12           ` Li Wang
2021-12-21 10:36             ` Cyril Hrubis
2021-12-21 10:44               ` Petr Vorel [this message]
2021-12-21 11:32                 ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcGwDKmi+iQuw3fS@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.