From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C223C433F5 for ; Tue, 21 Dec 2021 12:02:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237367AbhLUMCt (ORCPT ); Tue, 21 Dec 2021 07:02:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230184AbhLUMCt (ORCPT ); Tue, 21 Dec 2021 07:02:49 -0500 Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5245C061574 for ; Tue, 21 Dec 2021 04:02:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=xDvkLmsylauU8pkMsOWZqPmQJeKjQ+iJ/UszCpoHk/Q=; b=yqRc1 jwqEMx5GuHmRDlBQE3zkuVc/eaWMXi4WNwNe6Ut9YJFiPXB/OOmgTyF9ElqQcxZbtldA7ztoRqb6o GNb3UU5mqLWyNpvwtwfYFeYMFMNZiRwtpYzsWcdxBVbi8KDxmhVWvjGxtktUE8OrBAb57uADkOa/o aYt1FWjeI8Fy2ML0O06X31hiLgvoBX2X9vZL/hvj/FOip8FihBK6xLVa+Mq640YcW2ocDz/zjHhv6 8EdciZmHSWaOomhe2XWA1gnWovrFUo2ERihJ3sL41x2hfFYx/IbM/doogLu+ssIunvV9rS3QXL2A9 rijyFLZ6kZgTF8XUXsmNHf3KY3Zkg==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mzdqw-0002GB-7q; Tue, 21 Dec 2021 12:02:46 +0000 Date: Tue, 21 Dec 2021 12:02:44 +0000 From: John Keeping To: Pavel Hofman Cc: linux-usb@vger.kernel.org, Ruslan Bilovol , Felipe Balbi , Jerome Brunet , Julian Scheel , Greg Kroah-Hartman Subject: Re: [PATCH v2 05/11] usb: gadget: f_uac2: Renaming Clock Sources to fixed names Message-ID: References: <20211220211130.88590-1-pavel.hofman@ivitera.com> <20211220211130.88590-6-pavel.hofman@ivitera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211220211130.88590-6-pavel.hofman@ivitera.com> X-Authenticated: YES Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The subject should be "Rename ...". On Mon, Dec 20, 2021 at 10:11:24PM +0100, Pavel Hofman wrote: > From: Julian Scheel > > The gadget no longer supports only one frequency. Therefore USB strings > corresponding to the clock sources are renamed from specific Hz value to > general names Input clock/Output clock. > > Signed-off-by: Julian Scheel > Signed-off-by: Pavel Hofman > --- > drivers/usb/gadget/function/f_uac2.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c > index 74e32bb146c7..ef8e39e80523 100644 > --- a/drivers/usb/gadget/function/f_uac2.c > +++ b/drivers/usb/gadget/function/f_uac2.c > @@ -105,14 +105,11 @@ enum { > STR_AS_IN_ALT1, > }; > > -static char clksrc_in[8]; > -static char clksrc_out[8]; > - > static struct usb_string strings_fn[] = { > [STR_ASSOC].s = "Source/Sink", > [STR_IF_CTRL].s = "Topology Control", > - [STR_CLKSRC_IN].s = clksrc_in, > - [STR_CLKSRC_OUT].s = clksrc_out, > + [STR_CLKSRC_IN].s = "Input clock", > + [STR_CLKSRC_OUT].s = "Output clock", Other values here use title case, so "Input Clock", "Output Clock". > [STR_USB_IT].s = "USBH Out", > [STR_IO_IT].s = "USBD Out", > [STR_USB_OT].s = "USBH In", > @@ -1058,9 +1055,6 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn) > *bma = cpu_to_le32(control); > } > > - snprintf(clksrc_in, sizeof(clksrc_in), "%uHz", uac2_opts->p_srate); > - snprintf(clksrc_out, sizeof(clksrc_out), "%uHz", uac2_opts->c_srate); > - > ret = usb_interface_id(cfg, fn); > if (ret < 0) { > dev_err(dev, "%s:%d Error!\n", __func__, __LINE__); > -- > 2.25.1 >