All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Kelvin Zhang <zhangkelvin@google.com>
Cc: Miao Xie <miaoxie@huawei.com>,
	linux-erofs mailing list <linux-erofs@lists.ozlabs.org>
Subject: Re: [PATCH v1 2/2] Add API to get on disk size of an inode
Date: Wed, 22 Dec 2021 09:50:33 +0800	[thread overview]
Message-ID: <YcKEafQ+nJJ/xQYZ@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <CAOSmRzi5rinyzyY84ywF=Yepg2vrHMFY2JvoWQU9WRpVzdjcOQ@mail.gmail.com>

On Tue, Dec 21, 2021 at 08:46:58PM -0500, Kelvin Zhang wrote:
> Not really, dump_get_occupied_size() contains some custom logic for
> counting stats.
> 

Ok, thanks. maybe it would be better to rename as
erofsdump_get_occupied_size().
Also we could "static inline" such API since it's simple.

Thanks,
Gao Xiang

  reply	other threads:[~2021-12-22  1:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 14:28 [PATCH v1 1/2] Add some comments about const-ness around iterate API Kelvin Zhang via Linux-erofs
2021-12-21 14:28 ` [PATCH v1 2/2] Add API to get on disk size of an inode Kelvin Zhang via Linux-erofs
2021-12-22  1:46   ` Gao Xiang
2021-12-22  1:46     ` Kelvin Zhang via Linux-erofs
2021-12-22  1:50       ` Gao Xiang [this message]
2021-12-22  1:54         ` [PATCH v3 1/2] erofs-utils: lib: Add some comments about const-ness around iterate API Kelvin Zhang via Linux-erofs
2021-12-22  1:54           ` [PATCH v3 2/2] erofs-utils: lib: Add API to get on disk size of an inode Kelvin Zhang via Linux-erofs
2021-12-22  1:44 ` [PATCH v1 1/2] Add some comments about const-ness around iterate API Gao Xiang
2021-12-22  1:49   ` [PATCH v2 1/3] erofs-utils: lib: " Kelvin Zhang via Linux-erofs
2021-12-22  1:49     ` [PATCH v2 2/3] erofs-utils: lib: Add API to get on disk size of an inode Kelvin Zhang via Linux-erofs
2022-01-04 23:37     ` [PATCH v2 1/3] erofs-utils: lib: Add some comments about const-ness around iterate API Kelvin Zhang via Linux-erofs
2022-01-05  0:23       ` Gao Xiang
2022-01-05  0:24         ` Kelvin Zhang via Linux-erofs
2022-01-05  0:51       ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcKEafQ+nJJ/xQYZ@B-P7TQMD6M-0146.local \
    --to=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=miaoxie@huawei.com \
    --cc=zhangkelvin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.