From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB943C433FE for ; Wed, 22 Dec 2021 09:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244029AbhLVJt7 (ORCPT ); Wed, 22 Dec 2021 04:49:59 -0500 Received: from www.zeus03.de ([194.117.254.33]:35712 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244021AbhLVJt6 (ORCPT ); Wed, 22 Dec 2021 04:49:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=EJkolah8Mx37t5ori5JgQfX7iPuH YlTj6iZGbhM2QEc=; b=qoMgW0s9Fqj4GnsdVnt9A7PPqK5SxqmTbzpcVqOwOg9s f1P1uW2Mqpk9KqBM0Hq3P2ZU5xcYUe/RYlHZP+GfS/bLzCALHpbG6HCAopJasFXr QmE03Hb9M2Mpdhuwh/7EvHiupdZas0aG0hsiXQlJdJyJjgkqrk6Vv38mQ83gr2s= Received: (qmail 1700184 invoked from network); 22 Dec 2021 10:49:56 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 22 Dec 2021 10:49:56 +0100 X-UD-Smtp-Session: l3s3148p1@xGE2C7nTwrUgAQnoAFCUAc+q0T6Ni/m/ Date: Wed, 22 Dec 2021 10:49:53 +0100 From: Wolfram Sang To: Lad Prabhakar Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Chris Brandt , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakarprabhakar.csengg@gmail.com Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt Message-ID: Mail-Followup-To: Wolfram Sang , Lad Prabhakar , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Chris Brandt , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakarprabhakar.csengg@gmail.com References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tiR5Eds0Az0bZhMg" Content-Disposition: inline In-Reply-To: <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tiR5Eds0Az0bZhMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 21, 2021 at 05:53:21PM +0000, Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. >=20 > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq_optional() for DT users only. >=20 > Signed-off-by: Lad Prabhakar Tested on a Renesas R-Car Gen3 SoC (M3-W) and IIC port still works and no false positive printouts in the kernel log: Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --tiR5Eds0Az0bZhMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmHC9L4ACgkQFA3kzBSg KbbDFQ/9GPOCfr19hOXCepCCX0YK9KTMA6Ra6T6hof3Jrtb4HkxSbWixuLYQ8niR 5yVLDRgVoiIIboJacRCNR/+W24pajz7dRd6WXODpnaMAKlIAvfeLQ/EXDOH9hjX5 mcuYNd/KdjZ97y7FbotILTE6DZDBBO3vGDUtR2SpTQnVP00bqKXr72xnuCkkmP5j XZuaxaVktcP8xpNDPqNab/okpDx6kTIr4noNl5aldFH2b1JQIQJQb5PNFGIGrKA+ tHW4B3mp4dHVwQ/0OT3zUZDW632VdLwLy8Xn2bQEMrJiiorb0cNm4LHA92smB1lK qO/yMpJTgkQnVpuL3GTiLs/zshNnezjO7y6Xs5FLCsSRTWMWwTYBOM/ln4BmtFHJ PxRaSAHVzKBsd8kjrV6SMt31n09iT4VYMG+twhz1BPLarRvdZOOpNPaJ4s0dNVdh XwMHHlnFKPFxx3a5H04f4wl0ozwV5nPdTNjPlxOUrGy2LPs2VhRPQfg2KtFmyRfj d2Zua70Pm/p32Mx2FN1Vss8oirIXQFfKYXxS48GPUNXGPJviRi7/U0sSrwOwzX5s JxE8yjlEKrGZp0ymG7jU4h8xTaXgIUMHPbD4efwlc6ZdWbVPBHfRfQ30M6xsUdya GmIkNjXWeLsTMp9L20pmypnAUOjkKItg5RVsHkF5u8sP+5fckyE= =zGXh -----END PGP SIGNATURE----- --tiR5Eds0Az0bZhMg-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F20DC433F5 for ; Wed, 22 Dec 2021 09:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zqdOzX1Y1xh5OWcWGk4FrELTNRN7c5ibz7SRA+7aUsk=; b=Jyjt9oILZPUjhvZB/gRR60BmYh imtk5aTpAQaFChM8FfU6dEFG9yyQJpCuVDVal0eQOFUWvJ0ihPizIRsO8F9SUC1TUYrBGrwJK17Yb CQNG8bpwYwcFhSF7u1pejqOzN1NSUNClxOLByA0xnfn6TmEmaobndOe77+Cj1dZ04hb8xPEXidDOJ 7Hf90dAnJqTP9wcwzc7Mm1QOHZM6hJtldin7y8HOQMRwe07iX+pZX+Edw46BwyTPn1QBVoRbz63vI pskp8K+0gf4F7nK+/D5NeGdGZ6Waxma787R0RuZBULO8/L+J4xwX+FcixZnbfxRnQ0zc9+KQRIesz 8jbBwToA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzyG9-009v87-2K; Wed, 22 Dec 2021 09:50:09 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzyG5-009v6m-AH for linux-arm-kernel@lists.infradead.org; Wed, 22 Dec 2021 09:50:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=EJkolah8Mx37t5ori5JgQfX7iPuH YlTj6iZGbhM2QEc=; b=qoMgW0s9Fqj4GnsdVnt9A7PPqK5SxqmTbzpcVqOwOg9s f1P1uW2Mqpk9KqBM0Hq3P2ZU5xcYUe/RYlHZP+GfS/bLzCALHpbG6HCAopJasFXr QmE03Hb9M2Mpdhuwh/7EvHiupdZas0aG0hsiXQlJdJyJjgkqrk6Vv38mQ83gr2s= Received: (qmail 1700184 invoked from network); 22 Dec 2021 10:49:56 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 22 Dec 2021 10:49:56 +0100 X-UD-Smtp-Session: l3s3148p1@xGE2C7nTwrUgAQnoAFCUAc+q0T6Ni/m/ Date: Wed, 22 Dec 2021 10:49:53 +0100 From: Wolfram Sang To: Lad Prabhakar Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Chris Brandt , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakarprabhakar.csengg@gmail.com Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt Message-ID: Mail-Followup-To: Wolfram Sang , Lad Prabhakar , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Chris Brandt , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakarprabhakar.csengg@gmail.com References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 In-Reply-To: <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_015005_693403_FB1D9D5D X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8357319820315528630==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8357319820315528630== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tiR5Eds0Az0bZhMg" Content-Disposition: inline --tiR5Eds0Az0bZhMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 21, 2021 at 05:53:21PM +0000, Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. >=20 > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq_optional() for DT users only. >=20 > Signed-off-by: Lad Prabhakar Tested on a Renesas R-Car Gen3 SoC (M3-W) and IIC port still works and no false positive printouts in the kernel log: Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --tiR5Eds0Az0bZhMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmHC9L4ACgkQFA3kzBSg KbbDFQ/9GPOCfr19hOXCepCCX0YK9KTMA6Ra6T6hof3Jrtb4HkxSbWixuLYQ8niR 5yVLDRgVoiIIboJacRCNR/+W24pajz7dRd6WXODpnaMAKlIAvfeLQ/EXDOH9hjX5 mcuYNd/KdjZ97y7FbotILTE6DZDBBO3vGDUtR2SpTQnVP00bqKXr72xnuCkkmP5j XZuaxaVktcP8xpNDPqNab/okpDx6kTIr4noNl5aldFH2b1JQIQJQb5PNFGIGrKA+ tHW4B3mp4dHVwQ/0OT3zUZDW632VdLwLy8Xn2bQEMrJiiorb0cNm4LHA92smB1lK qO/yMpJTgkQnVpuL3GTiLs/zshNnezjO7y6Xs5FLCsSRTWMWwTYBOM/ln4BmtFHJ PxRaSAHVzKBsd8kjrV6SMt31n09iT4VYMG+twhz1BPLarRvdZOOpNPaJ4s0dNVdh XwMHHlnFKPFxx3a5H04f4wl0ozwV5nPdTNjPlxOUrGy2LPs2VhRPQfg2KtFmyRfj d2Zua70Pm/p32Mx2FN1Vss8oirIXQFfKYXxS48GPUNXGPJviRi7/U0sSrwOwzX5s JxE8yjlEKrGZp0ymG7jU4h8xTaXgIUMHPbD4efwlc6ZdWbVPBHfRfQ30M6xsUdya GmIkNjXWeLsTMp9L20pmypnAUOjkKItg5RVsHkF5u8sP+5fckyE= =zGXh -----END PGP SIGNATURE----- --tiR5Eds0Az0bZhMg-- --===============8357319820315528630== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8357319820315528630==--