From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 5/6] drm/i915/bios: Nuke DEVICE_TYPE_DP_DUAL_MODE_BITS
Date: Wed, 22 Dec 2021 14:53:34 +0200 [thread overview]
Message-ID: <YcMfzuqWKGPPilNo@intel.com> (raw)
In-Reply-To: <8735mlyoco.fsf@intel.com>
On Wed, Dec 22, 2021 at 11:34:47AM +0200, Jani Nikula wrote:
> On Fri, 17 Dec 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Replace the DEVICE_TYPE_DP_DUAL_MODE_BITS stuff with just
> > a DP+HDMI check. The rest of the bits shouldn't really
> > matter anyway.
> >
> > The slight change in behaviour here is that now we do look at
> > the DEVICE_TYPE_NOT_HDMI_OUTPUT bit (via
> > intel_bios_encoder_supports_hdmi()) when we previously ignored it.
> > The one platform we know that has problems with that bit is VLV.
> > But IIRC the problem was always that buggy VBTs basically never
> > set that bit. So that should be OK since all it would do is make
> > all DVI ports look like HDMI ports instead. Also can't imagine
> > there are many VLV machines with actual DVI ports in existence.
>
> One other thing is dropping the requirement for
> DEVICE_TYPE_DIGITAL_OUTPUT. I don't know if that should be part of
> intel_bios_encoder_supports_{hdmi,dp}(). *shrug*
Windows doesn't seem to look at that, so probably we shouldn't
either.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-12-22 12:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:53 [Intel-gfx] [PATCH 0/6] drm/i915: Extend parse_ddi_port() to all g4x+ platforms Ville Syrjala
2021-12-17 15:53 ` [Intel-gfx] [PATCH 1/6] drm/i915/bios: Introduce has_ddi_port_info() Ville Syrjala
2021-12-22 8:48 ` Jani Nikula
2021-12-17 15:53 ` [Intel-gfx] [PATCH 2/6] drm/i915/bios: Use i915->vbt.ports[] on CHV Ville Syrjala
2021-12-22 9:05 ` Jani Nikula
2021-12-22 12:49 ` Ville Syrjälä
2021-12-22 9:13 ` Jani Nikula
2021-12-17 15:54 ` [Intel-gfx] [PATCH 3/6] drm/i915/bios: Use i915->vbt.ports[] for all g4x+ Ville Syrjala
2021-12-22 9:19 ` Jani Nikula
2021-12-17 15:54 ` [Intel-gfx] [PATCH 4/6] drm/i915/bios: Throw out the !has_ddi_port_info() codepaths Ville Syrjala
2021-12-22 9:25 ` Jani Nikula
2021-12-17 15:54 ` [Intel-gfx] [PATCH 5/6] drm/i915/bios: Nuke DEVICE_TYPE_DP_DUAL_MODE_BITS Ville Syrjala
2021-12-22 9:34 ` Jani Nikula
2021-12-22 12:53 ` Ville Syrjälä [this message]
2021-12-17 15:54 ` [Intel-gfx] [PATCH 6/6] drm/i915/hdmi: Ignore DP++ TMDS clock limit for native HDMI ports Ville Syrjala
2021-12-22 9:47 ` Jani Nikula
2021-12-22 12:46 ` Ville Syrjälä
2021-12-22 15:38 ` Ville Syrjälä
2021-12-22 16:17 ` [Intel-gfx] [PATCH v2 " Ville Syrjala
2021-12-17 17:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Extend parse_ddi_port() to all g4x+ platforms Patchwork
2021-12-17 19:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-22 17:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Extend parse_ddi_port() to all g4x+ platforms (rev2) Patchwork
2021-12-22 20:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-01-19 22:21 ` [Intel-gfx] [PATCH 0/6] drm/i915: Extend parse_ddi_port() to all g4x+ platforms Ville Syrjälä
2022-01-20 10:14 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcMfzuqWKGPPilNo@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.