[PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/kvm/arm_vgic.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
index e602d848fc1a..bb30a6803d9f 100644
--- a/include/kvm/arm_vgic.h
+++ b/include/kvm/arm_vgic.h
@@ -5,9 +5,11 @@
 #ifndef __KVM_ARM_VGIC_H
 #define __KVM_ARM_VGIC_H
 
-#include <linux/kernel.h>
+#include <linux/bits.h>
 #include <linux/kvm.h>
 #include <linux/irqreturn.h>
+#include <linux/kref.h>
+#include <linux/mutex.h>
 #include <linux/spinlock.h>
 #include <linux/static_key.h>
 #include <linux/types.h>
-- 
2.34.1

[PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/kvm/arm_vgic.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
index e602d848fc1a..bb30a6803d9f 100644
--- a/include/kvm/arm_vgic.h
+++ b/include/kvm/arm_vgic.h
@@ -5,9 +5,11 @@
 #ifndef __KVM_ARM_VGIC_H
 #define __KVM_ARM_VGIC_H
 
-#include <linux/kernel.h>
+#include <linux/bits.h>
 #include <linux/kvm.h>
 #include <linux/irqreturn.h>
+#include <linux/kref.h>
+#include <linux/mutex.h>
 #include <linux/spinlock.h>
 #include <linux/static_key.h>
 #include <linux/types.h>
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/kvm/arm_vgic.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
index e602d848fc1a..bb30a6803d9f 100644
--- a/include/kvm/arm_vgic.h
+++ b/include/kvm/arm_vgic.h
@@ -5,9 +5,11 @@
 #ifndef __KVM_ARM_VGIC_H
 #define __KVM_ARM_VGIC_H
 
-#include <linux/kernel.h>
+#include <linux/bits.h>
 #include <linux/kvm.h>
 #include <linux/irqreturn.h>
+#include <linux/kref.h>
+#include <linux/mutex.h>
 #include <linux/spinlock.h>
 #include <linux/static_key.h>
 #include <linux/types.h>
-- 
2.34.1

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Marc Zyngier]

On Wed, 22 Dec 2021 16:55:52 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.

Which circular dependencies? What problem are you solving?

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Marc Zyngier]

On Wed, 22 Dec 2021 16:55:52 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.

Which circular dependencies? What problem are you solving?

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Marc Zyngier]

On Wed, 22 Dec 2021 16:55:52 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.

Which circular dependencies? What problem are you solving?

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 16:55:52 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > 
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> 
> Which circular dependencies? What problem are you solving?

In particular moving bitmap_*alloc() APIs to the headers.

But this may be a side effect of what I realized during the attempts
of solving that issue. In any case there is no need to take entire
mess of kernel.h in another header.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 16:55:52 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > 
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> 
> Which circular dependencies? What problem are you solving?

In particular moving bitmap_*alloc() APIs to the headers.

But this may be a side effect of what I realized during the attempts
of solving that issue. In any case there is no need to take entire
mess of kernel.h in another header.

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 16:55:52 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > 
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> 
> Which circular dependencies? What problem are you solving?

In particular moving bitmap_*alloc() APIs to the headers.

But this may be a side effect of what I realized during the attempts
of solving that issue. In any case there is no need to take entire
mess of kernel.h in another header.

-- 
With Best Regards,
Andy Shevchenko


_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > On Wed, 22 Dec 2021 16:55:52 +0000,
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > 
> > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > especially when there are circular dependencies are involved.
> > 
> > Which circular dependencies? What problem are you solving?
> 
> In particular moving bitmap_*alloc() APIs to the headers.
> 
> But this may be a side effect of what I realized during the attempts
> of solving that issue. In any case there is no need to take entire
> mess of kernel.h in another header.

For the record  `make headerdep` doesn't make any difference with
or without this patch. But I consider it's better not to use kernel.h
in the headers due to a full mess behind it.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > On Wed, 22 Dec 2021 16:55:52 +0000,
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > 
> > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > especially when there are circular dependencies are involved.
> > 
> > Which circular dependencies? What problem are you solving?
> 
> In particular moving bitmap_*alloc() APIs to the headers.
> 
> But this may be a side effect of what I realized during the attempts
> of solving that issue. In any case there is no need to take entire
> mess of kernel.h in another header.

For the record  `make headerdep` doesn't make any difference with
or without this patch. But I consider it's better not to use kernel.h
in the headers due to a full mess behind it.

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > On Wed, 22 Dec 2021 16:55:52 +0000,
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > 
> > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > especially when there are circular dependencies are involved.
> > 
> > Which circular dependencies? What problem are you solving?
> 
> In particular moving bitmap_*alloc() APIs to the headers.
> 
> But this may be a side effect of what I realized during the attempts
> of solving that issue. In any case there is no need to take entire
> mess of kernel.h in another header.

For the record  `make headerdep` doesn't make any difference with
or without this patch. But I consider it's better not to use kernel.h
in the headers due to a full mess behind it.

-- 
With Best Regards,
Andy Shevchenko


_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Marc Zyngier]

On Wed, 22 Dec 2021 19:14:28 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > 
> > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > especially when there are circular dependencies are involved.
> > > 
> > > Which circular dependencies? What problem are you solving?
> > 
> > In particular moving bitmap_*alloc() APIs to the headers.
> > 
> > But this may be a side effect of what I realized during the attempts
> > of solving that issue. In any case there is no need to take entire
> > mess of kernel.h in another header.
> 
> For the record  `make headerdep` doesn't make any difference with
> or without this patch. But I consider it's better not to use kernel.h
> in the headers due to a full mess behind it.

Can you then please write a commit message that matches what this is
actually doing instead of mentioning a problem that doesn't seem to
exist?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Marc Zyngier]

On Wed, 22 Dec 2021 19:14:28 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > 
> > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > especially when there are circular dependencies are involved.
> > > 
> > > Which circular dependencies? What problem are you solving?
> > 
> > In particular moving bitmap_*alloc() APIs to the headers.
> > 
> > But this may be a side effect of what I realized during the attempts
> > of solving that issue. In any case there is no need to take entire
> > mess of kernel.h in another header.
> 
> For the record  `make headerdep` doesn't make any difference with
> or without this patch. But I consider it's better not to use kernel.h
> in the headers due to a full mess behind it.

Can you then please write a commit message that matches what this is
actually doing instead of mentioning a problem that doesn't seem to
exist?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Marc Zyngier]

On Wed, 22 Dec 2021 19:14:28 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > 
> > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > especially when there are circular dependencies are involved.
> > > 
> > > Which circular dependencies? What problem are you solving?
> > 
> > In particular moving bitmap_*alloc() APIs to the headers.
> > 
> > But this may be a side effect of what I realized during the attempts
> > of solving that issue. In any case there is no need to take entire
> > mess of kernel.h in another header.
> 
> For the record  `make headerdep` doesn't make any difference with
> or without this patch. But I consider it's better not to use kernel.h
> in the headers due to a full mess behind it.

Can you then please write a commit message that matches what this is
actually doing instead of mentioning a problem that doesn't seem to
exist?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Tue, Jan 04, 2022 at 01:44:31PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 19:14:28 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > > 
> > > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > > especially when there are circular dependencies are involved.
> > > > 
> > > > Which circular dependencies? What problem are you solving?
> > > 
> > > In particular moving bitmap_*alloc() APIs to the headers.
> > > 
> > > But this may be a side effect of what I realized during the attempts
> > > of solving that issue. In any case there is no need to take entire
> > > mess of kernel.h in another header.
> > 
> > For the record  `make headerdep` doesn't make any difference with
> > or without this patch. But I consider it's better not to use kernel.h
> > in the headers due to a full mess behind it.
> 
> Can you then please write a commit message that matches what this is
> actually doing instead of mentioning a problem that doesn't seem to
> exist?

Sure, thanks for review!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Tue, Jan 04, 2022 at 01:44:31PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 19:14:28 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > > 
> > > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > > especially when there are circular dependencies are involved.
> > > > 
> > > > Which circular dependencies? What problem are you solving?
> > > 
> > > In particular moving bitmap_*alloc() APIs to the headers.
> > > 
> > > But this may be a side effect of what I realized during the attempts
> > > of solving that issue. In any case there is no need to take entire
> > > mess of kernel.h in another header.
> > 
> > For the record  `make headerdep` doesn't make any difference with
> > or without this patch. But I consider it's better not to use kernel.h
> > in the headers due to a full mess behind it.
> 
> Can you then please write a commit message that matches what this is
> actually doing instead of mentioning a problem that doesn't seem to
> exist?

Sure, thanks for review!

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

[Andy Shevchenko]

On Tue, Jan 04, 2022 at 01:44:31PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 19:14:28 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > > 
> > > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > > especially when there are circular dependencies are involved.
> > > > 
> > > > Which circular dependencies? What problem are you solving?
> > > 
> > > In particular moving bitmap_*alloc() APIs to the headers.
> > > 
> > > But this may be a side effect of what I realized during the attempts
> > > of solving that issue. In any case there is no need to take entire
> > > mess of kernel.h in another header.
> > 
> > For the record  `make headerdep` doesn't make any difference with
> > or without this patch. But I consider it's better not to use kernel.h
> > in the headers due to a full mess behind it.
> 
> Can you then please write a commit message that matches what this is
> actually doing instead of mentioning a problem that doesn't seem to
> exist?

Sure, thanks for review!

-- 
With Best Regards,
Andy Shevchenko


_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm