From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA764C433F5 for ; Wed, 22 Dec 2021 18:27:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344696AbhLVS1L (ORCPT ); Wed, 22 Dec 2021 13:27:11 -0500 Received: from mga12.intel.com ([192.55.52.136]:33504 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344690AbhLVS1K (ORCPT ); Wed, 22 Dec 2021 13:27:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640197630; x=1671733630; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uN531P6eAKoDlmobwFM1DNbNSTwy3I5gzy72Rjv6Q/8=; b=ZS7MZWfwKbvKrOpxFSzWZg49+LrFdtx4NENBaCQLvY+dfJ9efZBIBArm wAMZoJW6SGF68TjCxgc2pKZcgLz/zfy7dGy26RNVPF/pTNffOL7y9ZQW5 TiDGhOWuCUJxYaWuJQ8qf8DTXaCt6fB9kiO6yxKQwfrcIj+ts87ik4FnZ pNFrMcvDyGxYHtJOxuls0HoxKjTgVlXqPFr4upNZi2kWpCjfIIXokY1d/ ht1aD029n75kAy9x21T2KIE6qjNNoQCR6tAliMIbfQ+2ikgbSO3TBy9Xw 2ZVxijTKRkBEZ2S720eQMPXZQW9ccczcqZypmr0HQW7yJ/EYPaOyvL4eP Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10206"; a="220697807" X-IronPort-AV: E=Sophos;i="5.88,227,1635231600"; d="scan'208";a="220697807" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 10:27:09 -0800 X-IronPort-AV: E=Sophos;i="5.88,227,1635231600"; d="scan'208";a="587098653" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 10:27:08 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1n06J5-000uwc-2x; Wed, 22 Dec 2021 20:25:43 +0200 Date: Wed, 22 Dec 2021 20:25:42 +0200 From: Andy Shevchenko To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, James Morse , Alexandru Elisei , Suzuki K Poulose Subject: Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions Message-ID: References: <20211222165552.69288-1-andriy.shevchenko@linux.intel.com> <8735mk1pgt.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735mk1pgt.wl-maz@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote: > On Wed, 22 Dec 2021 16:55:52 +0000, > Andy Shevchenko wrote: > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > Which circular dependencies? What problem are you solving? In particular moving bitmap_*alloc() APIs to the headers. But this may be a side effect of what I realized during the attempts of solving that issue. In any case there is no need to take entire mess of kernel.h in another header. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B143FC433EF for ; Wed, 22 Dec 2021 18:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mhcp3QGao/y3VD+YVzpkqBamZOF9puyaNeZ2LJbxzsY=; b=jjzY6pVFU/FtsU yrFC1RZAkRlUOjdawhUCbdKjDrD/0T6JVO7r244qHZgaufv9iExn1tL8sujpvUsKf+p8Bd3xC4zNZ LzPumEXZb5exx7BBksqvV/BJSyNi6aiU4+SGeh7/pU4sDjixi+gDBHF33q5v5YmpnUfoFiaimEBGn Ix77EDSzxukKUh5yVrCOwnyXw5WNqWb7OIthUMK9UZO1f7yaHsA2vXoUuo+skbWL+BWzC1oe+ZM1v iZwGHj+h7isGKTxHxuKSwzr+Ap6hsRT7F8fjs1Okj8ZwjJPVFOYCzD1yfxMfOh3PmkE4R4b5ThDGP +N38XwWektZVPCj2aDUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n06KY-00B7KY-UK; Wed, 22 Dec 2021 18:27:15 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n06KV-00B7Jg-Jf for linux-arm-kernel@lists.infradead.org; Wed, 22 Dec 2021 18:27:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640197631; x=1671733631; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uN531P6eAKoDlmobwFM1DNbNSTwy3I5gzy72Rjv6Q/8=; b=ky2Ej+TBcTK3+x/AEls30ELg9nFFWW06SpZpd4OUz8lpELNOnDIXJmzj XoS7NKhRdcP63hQ+hncK0mtKSXNF0WT15aLUqypqPeAbGt1zVch5i8iQ4 Up+pegXKTuahVoMsnNXDClmSC5DtkyvqfCUc7aoXbTZBaKdww5YgTnekO zhZVEYendn3ywoDkkQouUWz9dopS4tBnkrJfoBEHLYwVUpIbzW108wySg SwDK1KiuDi4ZteWUGLDCmBAyQeNJJyUn8EyUxCFRRLhiZMRjPYmUyy6Su CYWtjNNtmR2sfdaIUF2FK8Mbl+TY/1aamPAyiPfLZ19BtLECV8cJeze2+ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10206"; a="304056011" X-IronPort-AV: E=Sophos;i="5.88,227,1635231600"; d="scan'208";a="304056011" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 10:27:10 -0800 X-IronPort-AV: E=Sophos;i="5.88,227,1635231600"; d="scan'208";a="587098653" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 10:27:08 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1n06J5-000uwc-2x; Wed, 22 Dec 2021 20:25:43 +0200 Date: Wed, 22 Dec 2021 20:25:42 +0200 From: Andy Shevchenko To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, James Morse , Alexandru Elisei , Suzuki K Poulose Subject: Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions Message-ID: References: <20211222165552.69288-1-andriy.shevchenko@linux.intel.com> <8735mk1pgt.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8735mk1pgt.wl-maz@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_102711_723578_33C02A88 X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote: > On Wed, 22 Dec 2021 16:55:52 +0000, > Andy Shevchenko wrote: > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > Which circular dependencies? What problem are you solving? In particular moving bitmap_*alloc() APIs to the headers. But this may be a side effect of what I realized during the attempts of solving that issue. In any case there is no need to take entire mess of kernel.h in another header. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88347C433EF for ; Wed, 22 Dec 2021 20:07:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1AC8640C67; Wed, 22 Dec 2021 15:07:46 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@intel.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bem6dAIVeaOe; Wed, 22 Dec 2021 15:07:44 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7AFE640D74; Wed, 22 Dec 2021 15:07:43 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2AAC040C52 for ; Wed, 22 Dec 2021 13:27:13 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tlfMDtc-zVjD for ; Wed, 22 Dec 2021 13:27:11 -0500 (EST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 7CFEB40BBE for ; Wed, 22 Dec 2021 13:27:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640197631; x=1671733631; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uN531P6eAKoDlmobwFM1DNbNSTwy3I5gzy72Rjv6Q/8=; b=ky2Ej+TBcTK3+x/AEls30ELg9nFFWW06SpZpd4OUz8lpELNOnDIXJmzj XoS7NKhRdcP63hQ+hncK0mtKSXNF0WT15aLUqypqPeAbGt1zVch5i8iQ4 Up+pegXKTuahVoMsnNXDClmSC5DtkyvqfCUc7aoXbTZBaKdww5YgTnekO zhZVEYendn3ywoDkkQouUWz9dopS4tBnkrJfoBEHLYwVUpIbzW108wySg SwDK1KiuDi4ZteWUGLDCmBAyQeNJJyUn8EyUxCFRRLhiZMRjPYmUyy6Su CYWtjNNtmR2sfdaIUF2FK8Mbl+TY/1aamPAyiPfLZ19BtLECV8cJeze2+ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10206"; a="304056010" X-IronPort-AV: E=Sophos;i="5.88,227,1635231600"; d="scan'208";a="304056010" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 10:27:10 -0800 X-IronPort-AV: E=Sophos;i="5.88,227,1635231600"; d="scan'208";a="587098653" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 10:27:08 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1n06J5-000uwc-2x; Wed, 22 Dec 2021 20:25:43 +0200 Date: Wed, 22 Dec 2021 20:25:42 +0200 From: Andy Shevchenko To: Marc Zyngier Subject: Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions Message-ID: References: <20211222165552.69288-1-andriy.shevchenko@linux.intel.com> <8735mk1pgt.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8735mk1pgt.wl-maz@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Mailman-Approved-At: Wed, 22 Dec 2021 15:07:42 -0500 Cc: linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote: > On Wed, 22 Dec 2021 16:55:52 +0000, > Andy Shevchenko wrote: > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > Which circular dependencies? What problem are you solving? In particular moving bitmap_*alloc() APIs to the headers. But this may be a side effect of what I realized during the attempts of solving that issue. In any case there is no need to take entire mess of kernel.h in another header. -- With Best Regards, Andy Shevchenko _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm