From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Maor Gottlieb <maorg@nvidia.com>,
alaa@nvidia.com, chuck.lever@oracle.com,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
tonylu@linux.alibaba.com
Subject: Re: [PATCH rdma-rc] Revert "RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow"
Date: Fri, 24 Dec 2021 08:00:55 +0200 [thread overview]
Message-ID: <YcViF8yyTfuedh38@unreal> (raw)
In-Reply-To: <20211224025145.GE1779224@nvidia.com>
On Thu, Dec 23, 2021 at 10:51:45PM -0400, Jason Gunthorpe wrote:
> On Wed, Dec 22, 2021 at 12:13:12PM +0200, Maor Gottlieb wrote:
> > This patch is not the full fix and still causes to call traces
> > during mlx5_ib_dereg_mr().
> >
> > This reverts commit f0ae4afe3d35e67db042c58a52909e06262b740f.
> >
> > Fixes: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
> > Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
> > ---
> > drivers/infiniband/hw/mlx5/mlx5_ib.h | 6 +++---
> > drivers/infiniband/hw/mlx5/mr.c | 26 ++++++++++++++------------
> > 2 files changed, 17 insertions(+), 15 deletions(-)
>
> Huh? Why is this such a problem to fix the missing udatas?
Because of internal structure of Nvidia/Mellanox, we are having very
hard time to properly test any fix in ULP area.
In addition, the vacation season doesn't help either.
Feel free to approach me or Maor offline and we will explain you the
non-technical details behind this revert.
Thanks
>
> Jason
next prev parent reply other threads:[~2021-12-24 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 10:13 [PATCH rdma-rc] Revert "RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow" Maor Gottlieb
2021-12-23 9:36 ` Leon Romanovsky
2021-12-24 2:51 ` Jason Gunthorpe
2021-12-24 6:00 ` Leon Romanovsky [this message]
2021-12-29 13:10 ` Timo Rothenpieler
2021-12-30 11:08 ` Leon Romanovsky
2022-01-05 17:00 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcViF8yyTfuedh38@unreal \
--to=leon@kernel.org \
--cc=alaa@nvidia.com \
--cc=chuck.lever@oracle.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.