From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: "Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 1/6] migration: All this fields are unsigned
Date: Fri, 24 Dec 2021 15:12:46 +0800 [thread overview]
Message-ID: <YcVy7mu1GVyLvV/n@xz-m1.local> (raw)
In-Reply-To: <20211221125235.67414-2-quintela@redhat.com>
On Tue, Dec 21, 2021 at 01:52:30PM +0100, Juan Quintela wrote:
> So printing it as %d is wrong. Notice that for the channel id, that
> is an uint8_t, but I changed it anyways for consistency.
Just curious: uint_8 can always correctly converted to a int, so the patch
shouldn't have a functional change, right?
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-12-24 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 12:52 [PATCH v2 0/6] migration: misc cleanups Juan Quintela
2021-12-21 12:52 ` [PATCH v2 1/6] migration: All this fields are unsigned Juan Quintela
2021-12-24 7:12 ` Peter Xu [this message]
2021-12-24 16:38 ` Juan Quintela
2021-12-21 12:52 ` [PATCH v2 2/6] migration: We only need last_stage in two places Juan Quintela
2021-12-24 7:22 ` Peter Xu
2021-12-21 12:52 ` [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page as argument Juan Quintela
2021-12-24 7:24 ` Peter Xu
2021-12-21 12:52 ` [PATCH v2 4/6] migration: Remove masking for compression Juan Quintela
2021-12-21 12:52 ` [PATCH v2 5/6] migration: simplify do_compress_ram_page Juan Quintela
2021-12-21 13:29 ` Philippe Mathieu-Daudé
2021-12-24 7:28 ` Peter Xu
2021-12-21 12:52 ` [PATCH v2 6/6] migration: Move ram_release_pages() call to save_zero_page_to_file() Juan Quintela
2021-12-24 7:35 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcVy7mu1GVyLvV/n@xz-m1.local \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=leobras@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.