From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B0B5C433EF for ; Fri, 24 Dec 2021 08:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351985AbhLXIcy (ORCPT ); Fri, 24 Dec 2021 03:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343611AbhLXIcx (ORCPT ); Fri, 24 Dec 2021 03:32:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59E67C061401; Fri, 24 Dec 2021 00:32:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 698B1B82234; Fri, 24 Dec 2021 08:32:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7584DC36AE5; Fri, 24 Dec 2021 08:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1640334770; bh=oAGJa1eQZdR4k8gaHp+oWjXb51Y31FZ01er7yJKkMOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eUv9EiLyLp7rAXeV2DY3PM6Ci3kQf/LPxlARr3ea+c4lU8gY7hDvWmUxS0p6/3XWm q4w4vwFGH6Rk/InS30d/o3V5XGw7C0s4P7lCU8xHnsO65KgGJFTpUrCUndyg6YFy/1 lmHAOe6plivc/xHjQWNEqw7aYRNmmztia9FBkrXU= Date: Fri, 24 Dec 2021 09:32:44 +0100 From: Greg Kroah-Hartman To: Quan Nguyen Cc: Joel Stanley , Andrew Jeffery , Jean Delvare , Guenter Roeck , Rob Herring , Lee Jones , Jonathan Corbet , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Mark Brown , "Rafael J . Wysocki" , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Gustavo Pimentel , Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: Re: [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Message-ID: References: <20211224041352.29405-1-quan@os.amperecomputing.com> <20211224041352.29405-7-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211224041352.29405-7-quan@os.amperecomputing.com> Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, Dec 24, 2021 at 11:13:49AM +0700, Quan Nguyen wrote: > This commit adds Ampere's SMpro error monitor driver for monitoring > and reporting RAS-related errors as reported by SMpro co-processor > found on Ampere's Altra processor family. > > Signed-off-by: Quan Nguyen > --- > Change in v6: > + First introduced in v6 [Quan] > > drivers/mfd/smpro-mfd.c | 1 + > drivers/misc/Kconfig | 7 + > drivers/misc/Makefile | 1 + > drivers/misc/smpro-errmon.c | 571 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 580 insertions(+) > create mode 100644 drivers/misc/smpro-errmon.c You need Documentation/ABI/ updates when you add sysfs files. Please do that for your next version of this patch. Also remember that sysfs is only "one value per file", this driver seems to violate that in huge ways and is not ok. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D255C433EF for ; Fri, 24 Dec 2021 08:33:40 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JL0hL6dRvz2ynK for ; Fri, 24 Dec 2021 19:33:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=eUv9EiLy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=eUv9EiLy; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JL0gX08wJz2xtL; Fri, 24 Dec 2021 19:32:54 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0335461FE8; Fri, 24 Dec 2021 08:32:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7584DC36AE5; Fri, 24 Dec 2021 08:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1640334770; bh=oAGJa1eQZdR4k8gaHp+oWjXb51Y31FZ01er7yJKkMOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eUv9EiLyLp7rAXeV2DY3PM6Ci3kQf/LPxlARr3ea+c4lU8gY7hDvWmUxS0p6/3XWm q4w4vwFGH6Rk/InS30d/o3V5XGw7C0s4P7lCU8xHnsO65KgGJFTpUrCUndyg6YFy/1 lmHAOe6plivc/xHjQWNEqw7aYRNmmztia9FBkrXU= Date: Fri, 24 Dec 2021 09:32:44 +0100 From: Greg Kroah-Hartman To: Quan Nguyen Subject: Re: [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Message-ID: References: <20211224041352.29405-1-quan@os.amperecomputing.com> <20211224041352.29405-7-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211224041352.29405-7-quan@os.amperecomputing.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, linux-doc@vger.kernel.org, Dragan Cvetic , Phong Vo , Lee Jones , Jonathan Corbet , openbmc@lists.ozlabs.org, "Rafael J . Wysocki" , Derek Kiernan , Guenter Roeck , devicetree@vger.kernel.org, Jean Delvare , Arnd Bergmann , "Thang Q . Nguyen" , Rob Herring , Open Source Submission , linux-hwmon@vger.kernel.org, Andrew Jeffery , Gustavo Pimentel , linux-kernel@vger.kernel.org, Mark Brown Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, Dec 24, 2021 at 11:13:49AM +0700, Quan Nguyen wrote: > This commit adds Ampere's SMpro error monitor driver for monitoring > and reporting RAS-related errors as reported by SMpro co-processor > found on Ampere's Altra processor family. > > Signed-off-by: Quan Nguyen > --- > Change in v6: > + First introduced in v6 [Quan] > > drivers/mfd/smpro-mfd.c | 1 + > drivers/misc/Kconfig | 7 + > drivers/misc/Makefile | 1 + > drivers/misc/smpro-errmon.c | 571 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 580 insertions(+) > create mode 100644 drivers/misc/smpro-errmon.c You need Documentation/ABI/ updates when you add sysfs files. Please do that for your next version of this patch. Also remember that sysfs is only "one value per file", this driver seems to violate that in huge ways and is not ok. thanks, greg k-h