From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CF7C433F5 for ; Wed, 29 Dec 2021 06:20:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238904AbhL2GUK (ORCPT ); Wed, 29 Dec 2021 01:20:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238893AbhL2GUJ (ORCPT ); Wed, 29 Dec 2021 01:20:09 -0500 X-Greylist: delayed 1137 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 28 Dec 2021 22:20:08 PST Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F11B6C061574 for ; Tue, 28 Dec 2021 22:20:08 -0800 (PST) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2S1A-00FYol-8j; Wed, 29 Dec 2021 06:00:56 +0000 Date: Wed, 29 Dec 2021 06:00:56 +0000 From: Al Viro To: Peter Zijlstra Cc: Eric Dumazet , kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org, Alexander Duyck , linux-um@lists.infradead.org Subject: Re: [tip:x86/core 1/1] arch/x86/um/../lib/csum-partial_64.c:98:12: error: implicit declaration of function 'load_unaligned_zeropad' Message-ID: References: <202111180219.YkyoBMpf-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 18, 2021 at 05:00:58PM +0100, Peter Zijlstra wrote: > Dear um folks, is this indeed the best solution? It's a bit sad to have > to add this to x86_64, but if that's the way it is... Something like this, perhaps? (absolutely untested) diff --git a/arch/um/include/asm/Kbuild b/arch/um/include/asm/Kbuild index e5a7b552bb384..a58b67ec8119d 100644 --- a/arch/um/include/asm/Kbuild +++ b/arch/um/include/asm/Kbuild @@ -23,7 +23,6 @@ generic-y += softirq_stack.h generic-y += switch_to.h generic-y += topology.h generic-y += trace_clock.h -generic-y += word-at-a-time.h generic-y += kprobes.h generic-y += mm_hooks.h generic-y += vga.h diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig index 95d26a69088b1..a812cc35092c6 100644 --- a/arch/x86/um/Kconfig +++ b/arch/x86/um/Kconfig @@ -9,6 +9,7 @@ endmenu config UML_X86 def_bool y select GENERIC_FIND_FIRST_BIT + select DCACHE_WORD_ACCESS config 64BIT bool "64-bit kernel" if "$(SUBARCH)" = "x86" From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1931192021345225038==" MIME-Version: 1.0 From: Al Viro To: kbuild-all@lists.01.org Subject: Re: [tip:x86/core 1/1] arch/x86/um/../lib/csum-partial_64.c:98:12: error: implicit declaration of function 'load_unaligned_zeropad' Date: Wed, 29 Dec 2021 06:00:56 +0000 Message-ID: In-Reply-To: List-Id: --===============1931192021345225038== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Nov 18, 2021 at 05:00:58PM +0100, Peter Zijlstra wrote: > Dear um folks, is this indeed the best solution? It's a bit sad to have > to add this to x86_64, but if that's the way it is... Something like this, perhaps? (absolutely untested) diff --git a/arch/um/include/asm/Kbuild b/arch/um/include/asm/Kbuild index e5a7b552bb384..a58b67ec8119d 100644 --- a/arch/um/include/asm/Kbuild +++ b/arch/um/include/asm/Kbuild @@ -23,7 +23,6 @@ generic-y +=3D softirq_stack.h generic-y +=3D switch_to.h generic-y +=3D topology.h generic-y +=3D trace_clock.h -generic-y +=3D word-at-a-time.h generic-y +=3D kprobes.h generic-y +=3D mm_hooks.h generic-y +=3D vga.h diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig index 95d26a69088b1..a812cc35092c6 100644 --- a/arch/x86/um/Kconfig +++ b/arch/x86/um/Kconfig @@ -9,6 +9,7 @@ endmenu config UML_X86 def_bool y select GENERIC_FIND_FIRST_BIT + select DCACHE_WORD_ACCESS = config 64BIT bool "64-bit kernel" if "$(SUBARCH)" =3D "x86" --===============1931192021345225038==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv-ca.linux.org.uk ([2607:5300:60:148a::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2S1S-002Jlf-AI for linux-um@lists.infradead.org; Wed, 29 Dec 2021 06:01:15 +0000 Date: Wed, 29 Dec 2021 06:00:56 +0000 From: Al Viro Subject: Re: [tip:x86/core 1/1] arch/x86/um/../lib/csum-partial_64.c:98:12: error: implicit declaration of function 'load_unaligned_zeropad' Message-ID: References: <202111180219.YkyoBMpf-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Peter Zijlstra Cc: Eric Dumazet , kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org, Alexander Duyck , linux-um@lists.infradead.org On Thu, Nov 18, 2021 at 05:00:58PM +0100, Peter Zijlstra wrote: > Dear um folks, is this indeed the best solution? It's a bit sad to have > to add this to x86_64, but if that's the way it is... Something like this, perhaps? (absolutely untested) diff --git a/arch/um/include/asm/Kbuild b/arch/um/include/asm/Kbuild index e5a7b552bb384..a58b67ec8119d 100644 --- a/arch/um/include/asm/Kbuild +++ b/arch/um/include/asm/Kbuild @@ -23,7 +23,6 @@ generic-y += softirq_stack.h generic-y += switch_to.h generic-y += topology.h generic-y += trace_clock.h -generic-y += word-at-a-time.h generic-y += kprobes.h generic-y += mm_hooks.h generic-y += vga.h diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig index 95d26a69088b1..a812cc35092c6 100644 --- a/arch/x86/um/Kconfig +++ b/arch/x86/um/Kconfig @@ -9,6 +9,7 @@ endmenu config UML_X86 def_bool y select GENERIC_FIND_FIRST_BIT + select DCACHE_WORD_ACCESS config 64BIT bool "64-bit kernel" if "$(SUBARCH)" = "x86" _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um