From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D5B8C433F5 for ; Wed, 29 Dec 2021 10:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239771AbhL2KjI (ORCPT ); Wed, 29 Dec 2021 05:39:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24288 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235553AbhL2KjH (ORCPT ); Wed, 29 Dec 2021 05:39:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640774347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gQ3Cw+k3UMeBdiHPh9g0eM12SBQJLgdBY7UIBnA37XI=; b=MLZrw7vMFKPqBXrQQsDPZ+BZ0HR+aG/ED0jd7hw2bqcoYDlc9JuKPHvrY+ls839dt6JGez hN4+DsNHc8qu4wwc4F0mTWCKRjSwRh5kucVa03aDwrqBOgPfmYrZ4Im3qUUm3j8RFkBsCM jd0b2VHfkC97JSgm29l+IZgKgDOKRt8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-344-UEvHSK6OPI6jXkgkAr38Fw-1; Wed, 29 Dec 2021 05:39:03 -0500 X-MC-Unique: UEvHSK6OPI6jXkgkAr38Fw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FF581853028; Wed, 29 Dec 2021 10:39:01 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-131.pek2.redhat.com [10.72.12.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9634C6F11D; Wed, 29 Dec 2021 10:38:46 +0000 (UTC) Date: Wed, 29 Dec 2021 18:38:43 +0800 From: Dave Young To: Borislav Petkov Cc: "Leizhen (ThunderTown)" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly Subject: Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code Message-ID: References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-3-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/29/21 at 11:11am, Borislav Petkov wrote: > On Wed, Dec 29, 2021 at 03:45:12PM +0800, Dave Young wrote: > > BTW, I would suggest to wait for reviewers to response (eg. one week at > > least, or more due to the holidays) before updating another version > > > > Do not worry to miss the 5.17. I would say take it easy if it will > > miss then let's just leave with it and continue to work on the future > > improvements. I think one reason this issue takes too long time is that it was > > discussed some time but no followup and later people need to warm up > > again. Just keep it warm and continue to engage in the improvements, do > > not hurry for the specific mainline release. > > Can you tell this to *all* patch submitters please? I appreciate you further explanation below to describe the situation. I do not see how can I tell this to *all* submitters, but I am and I will try to do this as far as I can. Maintainers and patch submitters, it would help for both parties show sympathy with each other, some soft reminders will help people to understand each other, especially for new comers. > > I can't count the times where people simply hurry to send the new > revision just to get it in the next kernel, and make silly mistakes > while doing so. Or not think things straight and misdesign it all. > > And what this causes is the opposite of what they wanna achieve - pissed > maintainers and ignored threads. > > And they all *know* that the next kernel is around the corner. So why > the hell does it even matter when? > > What most submitters fail to realize is, the moment your code hits > upstream, it becomes the maintainers' problem and submitters can relax. > > But maintainers get to deal with this code forever. So after a while > maintainers learn that they either accept ready code and it all just > works or they make the mistake to take half-baked crap in and then they > themselves get to clean it up and fix it. > > So maintainers learn quickly to push back. > > But it is annoying and it would help immensely if submitters would > consider this and stop hurrying the code in but try to do a *good* job > first, design-wise and code-wise by thinking hard about what they're > trying to do. > > Yeah, things could be a lot simpler and easier - it only takes a little > bit of effort... > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette > Thanks Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85639C433F5 for ; Wed, 29 Dec 2021 10:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nA/bxXkO8VUQU6MXPzTk/cOIkNmza8e4UJioiUptpDo=; b=ai5gX0+xkiGDZF POt5O9PM5lrYnKKE7eM92KEAezqJriEYM7zb0xYuHGd73pmgzjxbiYDEm1L+KIDCOWBpN7Q7GF6Jg AHIVDRNLM7iwe4pvZaYiYG2tehD9JS897KGQGANJWNyROoEZRGgEWug+YtBvMRmz1RCq4+v7jQC1b /kZSlhS1hl15Fxea9dgJU9leQPo3rTSD+go8gTVLqgtyDUXnRwZgTuxCdZjrWwbN8Pe6ctmUTe6QK aVt5MGq4V3DKf3j/zN3hkuf3DAzI+inA3z00NfXVF44LZr2FTG579Yg0Ae2XUX/BUVqgiNxvDoGFq QpWJnHZAsa7wICRrCttA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2WMP-002dL9-Rd; Wed, 29 Dec 2021 10:39:10 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2WMM-002dK2-7a for linux-arm-kernel@lists.infradead.org; Wed, 29 Dec 2021 10:39:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640774345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gQ3Cw+k3UMeBdiHPh9g0eM12SBQJLgdBY7UIBnA37XI=; b=fmSTeAxAJA25uQyS+AHspZr+e68hrzbAfGtJ329XO+zlxywMUn9rrb0hj/2fk5spmvcf5Y uN7XSVFI2CeIoNIJX0FXDdXDSub5VtLY1Uc3BBjTwcSZDk9ZPYF5FxJ4T7ychyPc65zMRU i5bph84UBeHW5ez5eQQJBMaJg9yN/HI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-344-UEvHSK6OPI6jXkgkAr38Fw-1; Wed, 29 Dec 2021 05:39:03 -0500 X-MC-Unique: UEvHSK6OPI6jXkgkAr38Fw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FF581853028; Wed, 29 Dec 2021 10:39:01 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-131.pek2.redhat.com [10.72.12.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9634C6F11D; Wed, 29 Dec 2021 10:38:46 +0000 (UTC) Date: Wed, 29 Dec 2021 18:38:43 +0800 From: Dave Young To: Borislav Petkov Cc: "Leizhen (ThunderTown)" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly Subject: Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code Message-ID: References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-3-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211229_023906_483476_1E001B6E X-CRM114-Status: GOOD ( 34.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/29/21 at 11:11am, Borislav Petkov wrote: > On Wed, Dec 29, 2021 at 03:45:12PM +0800, Dave Young wrote: > > BTW, I would suggest to wait for reviewers to response (eg. one week at > > least, or more due to the holidays) before updating another version > > > > Do not worry to miss the 5.17. I would say take it easy if it will > > miss then let's just leave with it and continue to work on the future > > improvements. I think one reason this issue takes too long time is that it was > > discussed some time but no followup and later people need to warm up > > again. Just keep it warm and continue to engage in the improvements, do > > not hurry for the specific mainline release. > > Can you tell this to *all* patch submitters please? I appreciate you further explanation below to describe the situation. I do not see how can I tell this to *all* submitters, but I am and I will try to do this as far as I can. Maintainers and patch submitters, it would help for both parties show sympathy with each other, some soft reminders will help people to understand each other, especially for new comers. > > I can't count the times where people simply hurry to send the new > revision just to get it in the next kernel, and make silly mistakes > while doing so. Or not think things straight and misdesign it all. > > And what this causes is the opposite of what they wanna achieve - pissed > maintainers and ignored threads. > > And they all *know* that the next kernel is around the corner. So why > the hell does it even matter when? > > What most submitters fail to realize is, the moment your code hits > upstream, it becomes the maintainers' problem and submitters can relax. > > But maintainers get to deal with this code forever. So after a while > maintainers learn that they either accept ready code and it all just > works or they make the mistake to take half-baked crap in and then they > themselves get to clean it up and fix it. > > So maintainers learn quickly to push back. > > But it is annoying and it would help immensely if submitters would > consider this and stop hurrying the code in but try to do a *good* job > first, design-wise and code-wise by thinking hard about what they're > trying to do. > > Yeah, things could be a lot simpler and easier - it only takes a little > bit of effort... > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette > Thanks Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2WMN-002dKL-UR for kexec@lists.infradead.org; Wed, 29 Dec 2021 10:39:09 +0000 Date: Wed, 29 Dec 2021 18:38:43 +0800 From: Dave Young Subject: Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code Message-ID: References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-3-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Borislav Petkov Cc: "Leizhen (ThunderTown)" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly On 12/29/21 at 11:11am, Borislav Petkov wrote: > On Wed, Dec 29, 2021 at 03:45:12PM +0800, Dave Young wrote: > > BTW, I would suggest to wait for reviewers to response (eg. one week at > > least, or more due to the holidays) before updating another version > > > > Do not worry to miss the 5.17. I would say take it easy if it will > > miss then let's just leave with it and continue to work on the future > > improvements. I think one reason this issue takes too long time is that it was > > discussed some time but no followup and later people need to warm up > > again. Just keep it warm and continue to engage in the improvements, do > > not hurry for the specific mainline release. > > Can you tell this to *all* patch submitters please? I appreciate you further explanation below to describe the situation. I do not see how can I tell this to *all* submitters, but I am and I will try to do this as far as I can. Maintainers and patch submitters, it would help for both parties show sympathy with each other, some soft reminders will help people to understand each other, especially for new comers. > > I can't count the times where people simply hurry to send the new > revision just to get it in the next kernel, and make silly mistakes > while doing so. Or not think things straight and misdesign it all. > > And what this causes is the opposite of what they wanna achieve - pissed > maintainers and ignored threads. > > And they all *know* that the next kernel is around the corner. So why > the hell does it even matter when? > > What most submitters fail to realize is, the moment your code hits > upstream, it becomes the maintainers' problem and submitters can relax. > > But maintainers get to deal with this code forever. So after a while > maintainers learn that they either accept ready code and it all just > works or they make the mistake to take half-baked crap in and then they > themselves get to clean it up and fix it. > > So maintainers learn quickly to push back. > > But it is annoying and it would help immensely if submitters would > consider this and stop hurrying the code in but try to do a *good* job > first, design-wise and code-wise by thinking hard about what they're > trying to do. > > Yeah, things could be a lot simpler and easier - it only takes a little > bit of effort... > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette > Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec