From: John Keeping <john@metanate.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] mmc: dwmmc: return a proper error code when busy
Date: Wed, 12 Jan 2022 11:11:51 +0000 [thread overview]
Message-ID: <Yd63d1hRttlMqc79@donbot> (raw)
In-Reply-To: <65f26a03-4ca8-e75d-c737-79dd08ead939@samsung.com>
On Wed, Jan 12, 2022 at 08:38:01AM +0900, Jaehoon Chung wrote:
> On 1/12/22 7:12 AM, Jaehoon Chung wrote:
> > On 1/12/22 1:15 AM, John Keeping wrote:
> >> When failing to send a command because the hardware is busy, return
> >> EBUSY to indicate the cause instead of just -1.
>
> Is this patch same?
>
> https://patchwork.ozlabs.org/project/uboot/patch/20211207160935.404395-1-john@metanate.com/
Yes, sorry - I still had the patch file lying around and passed the
wrong filename to git send-email!
> >>
> >> Signed-off-by: John Keeping <john@metanate.com>
> >
> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>>
> > Best Regards,
> > Jaehoon Chung
> >
> >> ---
> >> drivers/mmc/dw_mmc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> >> index a949dad574..4232c5eb8c 100644
> >> --- a/drivers/mmc/dw_mmc.c
> >> +++ b/drivers/mmc/dw_mmc.c
> >> @@ -301,7 +301,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> >> flags = dwmci_set_transfer_mode(host, data);
> >>
> >> if ((cmd->resp_type & MMC_RSP_136) && (cmd->resp_type & MMC_RSP_BUSY))
> >> - return -1;
> >> + return -EBUSY;
> >>
> >> if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION)
> >> flags |= DWMCI_CMD_ABORT_STOP;
> >>
> >
> >
>
next prev parent reply other threads:[~2022-01-12 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220111161540epcas1p2e4b932a2f4811faa231669f70880f3dc@epcas1p2.samsung.com>
2022-01-11 16:15 ` [PATCH] mmc: dwmmc: return a proper error code when busy John Keeping
2022-01-11 22:12 ` Jaehoon Chung
2022-01-11 23:38 ` Jaehoon Chung
2022-01-12 11:11 ` John Keeping [this message]
2022-01-12 23:42 ` Jaehoon Chung
[not found] <CGME20211207160950epcas1p1226e9983967c0baf413d1b7a1530daa3@epcas1p1.samsung.com>
2021-12-07 16:09 ` John Keeping
2021-12-07 23:55 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd63d1hRttlMqc79@donbot \
--to=john@metanate.com \
--cc=jh80.chung@samsung.com \
--cc=peng.fan@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.