From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73C4C433FE for ; Wed, 12 Jan 2022 20:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357780AbiALUvq (ORCPT ); Wed, 12 Jan 2022 15:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357756AbiALUvo (ORCPT ); Wed, 12 Jan 2022 15:51:44 -0500 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F2BFC061748 for ; Wed, 12 Jan 2022 12:51:44 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id l15so5986628pls.7 for ; Wed, 12 Jan 2022 12:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oP2xECK3jqBdvkGX0hGsK3lqWf4wO8IHTIIQlzl9xV0=; b=go0VIqj3WoGgVNblUj4B4WLTzg0PxEjFmQwtbzqnMOJC/F9Bo/wFDWoyLE0dbsjdHB coldoa/fGsktjsQjiCKnHHJE+EiXAfz3OCArE7wRQTF8YQfx0bvJzyr1K7D/yk8KjGXe rya2Zi8dKNG+opPse71wY+dyqIsh7bczGHRPo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oP2xECK3jqBdvkGX0hGsK3lqWf4wO8IHTIIQlzl9xV0=; b=pt8PIgfVrRrXpBULdzvnoWbnKhcMrj3YxBt3txD/lotN4g7HL8hMNV/tMKU6qWa3Ut X9FU/aXOJ+eDiN4B9fvhZg7KlT9CIwPU27g4I4QMCAPZ0244B3zSTNfgPLNmgkNYXGyD GvxNOJnX7ciDXCnwuQDT6at4OOHj0kq1bdNo6btq3I8nNLavINwsbl3u5NMOGqXXt84I wtkJ87/cdmWAc2rXhqwtswIrQD0LdSe9MigRdXFZvQnnCzAFFtbg+H/JDC341Q9F9LeC PO48hRjoO85FIMvlcsYdSH4p7Q2o23o3fv79gNxgwuFrwBcej0W6OaxWA0e67KwntEsj JJ5w== X-Gm-Message-State: AOAM5335mklKmsDRVQ2fh1Is6leUSLblMQl4Dg9SxBgRbJwUkL7/4kbB 9C0uPzVetJk4EQ1J5vvoZypRww== X-Google-Smtp-Source: ABdhPJxnNSOW9L3MOKWhvTl5dDqgf06igl93+P7KOL/G2UMdszRHDjsCTcZlPgKLzKrTN0wPIapNjQ== X-Received: by 2002:a65:6114:: with SMTP id z20mr1259114pgu.438.1642020703986; Wed, 12 Jan 2022 12:51:43 -0800 (PST) Received: from localhost ([2620:15c:202:201:f6eb:5b26:28c:1ca5]) by smtp.gmail.com with UTF8SMTPSA id gt22sm490651pjb.35.2022.01.12.12.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 12:51:43 -0800 (PST) Date: Wed, 12 Jan 2022 12:51:41 -0800 From: Matthias Kaehlcke To: Stephen Boyd Cc: Alan Stern , Felipe Balbi , Frank Rowand , Greg Kroah-Hartman , Mathias Nyman , Rob Herring , Bastien Nocera , Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Roger Quadros , Michal Simek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v19 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Message-ID: References: <20220112191048.837236-1-mka@chromium.org> <20220112111028.v19.5.Ie0d2c1214b767bb5551dd4cad38398bd40e4466f@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jan 12, 2022 at 12:47:15PM -0800, Stephen Boyd wrote: > Quoting Matthias Kaehlcke (2022-01-12 11:10:48) > > Add nodes for the onboard USB hub on trogdor devices. Remove the > > 'always-on' property from the hub regulator, since the regulator > > is now managed by the onboard_usb_hub driver. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > One question below > > Reviewed-by: Stephen Boyd Thanks! > > .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 ++++++++----------- > > .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +++++------- > > .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 11 ++++------- > > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 ++++++++----------- > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 ++++++++++++++++++- > > 5 files changed, 43 insertions(+), 37 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > index d4f4441179fc..cd31460b3bd6 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > @@ -202,7 +202,6 @@ pp3300_hub: pp3300-hub { > > pinctrl-names = "default"; > > pinctrl-0 = <&en_pp3300_hub>; > > > > - regulator-always-on; > > regulator-boot-on; > > Is regulator-boot-on necessary? It tells the kernel that the regulator is already on at boot, and avoids an off-on cycle that would happen otherwise (internal reference: b/185972336).