From: David Vernet <void@manifault.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Aaron Tomlin <atomlin@redhat.com>,
mcgrof@kernel.org, cl@linux.com, mbenes@suse.cz,
akpm@linux-foundation.org, jeyu@kernel.org,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
atomlin@atomlin.com, ghalat@redhat.com, allen.lkml@gmail.com,
live-patching@vger.kernel.org
Subject: Re: [RFC PATCH v2 03/13] module: Move livepatch support to a separate file
Date: Wed, 12 Jan 2022 10:40:01 -0800 [thread overview]
Message-ID: <Yd8ggcNEWgqAwmcD@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <Yd8HpK44aWhhNI/Q@alley>
Petr Mladek <pmladek@suse.com> wrote on Wed [2022-Jan-12 17:53:56 +0100]:
> It would be better to have the two variants close each other. I mean
> to have it somewhere like:
>
> #ifdef CONFIG_LIVEPATCH
>
> variant A
>
> #else
>
> variant B
>
> #endif
>
<snip>
> #ifdef CONFIG_LIVEPATCH
> static inline bool set_livepatch_module(struct module *mod)
> {
> mod->klp = true;
> return true;
> }
> #else /* !CONFIG_LIVEPATCH */
> static inline bool set_livepatch_module(struct module *mod)
> {
> return false;
> }
> #endif /* CONFIG_LIVEPATCH */
>
>
> Well, it might be matter of taste. Others might prefer another solution.
> Adding live-patching mailing list into Cc.
+1 -- this seems like a cleaner approach.
- David
next prev parent reply other threads:[~2022-01-12 18:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 23:43 [RFC PATCH v2 00/13] module: core code clean up Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 01/13] module: Move all into module/ Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 02/13] module: Simple refactor in preparation for split Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 03/13] module: Move livepatch support to a separate file Aaron Tomlin
2022-01-12 16:53 ` Petr Mladek
2022-01-12 18:40 ` David Vernet [this message]
2022-01-14 9:14 ` Aaron Tomlin
2022-01-12 18:54 ` David Vernet
2022-01-13 10:35 ` Aaron Tomlin
2022-01-13 14:16 ` David Vernet
2022-01-13 15:12 ` Luis Chamberlain
2022-01-06 23:43 ` [RFC PATCH v2 04/13] module: Move latched RB-tree " Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 05/13] module: Move arch strict rwx " Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 06/13] module: Move " Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 07/13] module: Move extra signature support out of core code Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 08/13] module: Move kmemleak support to a separate file Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 09/13] module: Move kallsyms support into " Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 10/13] module: Move procfs " Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 11/13] module: Move sysfs " Aaron Tomlin
2022-01-06 23:43 ` [RFC PATCH v2 12/13] module: Move kdb_modules list out of core code Aaron Tomlin
2022-01-11 14:55 ` [RFC PATCH v2 00/13] module: core code clean up Allen
2022-01-12 1:16 ` Allen
2022-01-12 13:21 ` Aaron Tomlin
2022-01-12 15:52 ` Luis Chamberlain
2022-01-13 9:23 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd8ggcNEWgqAwmcD@dev0025.ash9.facebook.com \
--to=void@manifault.com \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=cl@linux.com \
--cc=ghalat@redhat.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.