From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4416C433EF for ; Wed, 12 Jan 2022 19:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356782AbiALTNE (ORCPT ); Wed, 12 Jan 2022 14:13:04 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:34666 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356769AbiALTLX (ORCPT ); Wed, 12 Jan 2022 14:11:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=V3MklzZNdawzVK+oVASgZ9JYoB5WDQelZ8fP9c6dJ7Y=; b=M26jxjwLTk+pRxB2OLICzHfnzu kPVYzK5u0Za0a4fxmNVvJmNvDEkUnI5Fx+kKmLA+GKkFn0Rpyxr+7VdJQm+c0glRugg5Sc7a2YA9s cpxQmOgp8L2/egQ5PUC+VpAUwq9Tve+qTd/o6ieaj9GREkfAmrttdHq/ldfEZuWwzrOM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n7j1i-001E2s-DY; Wed, 12 Jan 2022 20:11:18 +0100 Date: Wed, 12 Jan 2022 20:11:18 +0100 From: Andrew Lunn To: Robert Hancock Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com, davem@davemloft.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, michal.simek@xilinx.com, ariane.keller@tik.ee.ethz.ch, daniel@iogearbox.net Subject: Re: [PATCH net v2 1/9] net: axienet: increase reset timeout Message-ID: References: <20220112173700.873002-1-robert.hancock@calian.com> <20220112173700.873002-2-robert.hancock@calian.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220112173700.873002-2-robert.hancock@calian.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 12, 2022 at 11:36:52AM -0600, Robert Hancock wrote: > The previous timeout of 1ms was too short to handle some cases where the > core is reset just after the input clocks were started, which will > be introduced in an upcoming patch. Increase the timeout to 50ms. Also > simplify the reset timeout checking to use read_poll_timeout. > > Fixes: 8a3b7a252dca9 ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > Signed-off-by: Robert Hancock Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0BC9C433EF for ; Wed, 12 Jan 2022 19:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RNVJm53IQqFineR903QMYRmpdJ460ZddGBjA229PJsc=; b=EjTpP7+laoyYxf RhiOSWW5nD/zlDxbv22rjOmJfNiKn7YFcDouaDXL9CoIFp3V4LVme4lMVZj+/keFISTjtkdr6FKpj hq6A6VELDgS0k6qK5EmKMkh3bcYIqaHhjIG3QVyOtyY5r8NtvBSprvjGrBZDW6P15Q1OrYxmF/IML ZlRAhROHBXkgSd5NrcDMfobFZeyOLoVGtlGSH/V0LX+Bw1sioJTH50lX7VR/TtXg60W3tJlBM5FLz CQoOSPPRCy2sEI0UUGdtEZK14Odjx5b34kp5gyVzg2+wRbdBqPypzQKz3s8pKAmKWkfEIj7cgPA5X 2BEMSzIYZrZhDcJkEB5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7j1y-003YOs-Lh; Wed, 12 Jan 2022 19:11:34 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7j1w-003YOX-Bh for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 19:11:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=V3MklzZNdawzVK+oVASgZ9JYoB5WDQelZ8fP9c6dJ7Y=; b=M26jxjwLTk+pRxB2OLICzHfnzu kPVYzK5u0Za0a4fxmNVvJmNvDEkUnI5Fx+kKmLA+GKkFn0Rpyxr+7VdJQm+c0glRugg5Sc7a2YA9s cpxQmOgp8L2/egQ5PUC+VpAUwq9Tve+qTd/o6ieaj9GREkfAmrttdHq/ldfEZuWwzrOM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n7j1i-001E2s-DY; Wed, 12 Jan 2022 20:11:18 +0100 Date: Wed, 12 Jan 2022 20:11:18 +0100 From: Andrew Lunn To: Robert Hancock Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com, davem@davemloft.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, michal.simek@xilinx.com, ariane.keller@tik.ee.ethz.ch, daniel@iogearbox.net Subject: Re: [PATCH net v2 1/9] net: axienet: increase reset timeout Message-ID: References: <20220112173700.873002-1-robert.hancock@calian.com> <20220112173700.873002-2-robert.hancock@calian.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220112173700.873002-2-robert.hancock@calian.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_111132_420306_4461B170 X-CRM114-Status: UNSURE ( 8.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 12, 2022 at 11:36:52AM -0600, Robert Hancock wrote: > The previous timeout of 1ms was too short to handle some cases where the > core is reset just after the input clocks were started, which will > be introduced in an upcoming patch. Increase the timeout to 50ms. Also > simplify the reset timeout checking to use read_poll_timeout. > > Fixes: 8a3b7a252dca9 ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > Signed-off-by: Robert Hancock Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel