From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B697FC433EF for ; Wed, 12 Jan 2022 19:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357154AbiALT5w (ORCPT ); Wed, 12 Jan 2022 14:57:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357666AbiALTzq (ORCPT ); Wed, 12 Jan 2022 14:55:46 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8905C06173F; Wed, 12 Jan 2022 11:55:46 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id l15so5734113pls.7; Wed, 12 Jan 2022 11:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pTkXuSKZdEidYDtUquppnkS8GPvDaeca2bpqBFg2VUk=; b=aVDCcfyGG6eZ7fQRZwIpKvAV3p4XQAIsCDHU4V8R68gVluTPXLyO4TF+tuwhm7XNxH 2VFN9RxstCr5amo4nthsCVIpWzI31OwDeQN2LuYI4sWHzWcRLMB7vii4FIcLCxFHvuk1 hQ7tW6OYVeXC6Mkku3+HVMdiL4OicoRI+GOcEe8uOTotfiLnVvGoiJ7mL0/n/Ya0Yqv7 NfCSAd4pxzo1OW1rtcHHA87G7eCWLKSBrG/jHsP4/JaH4No9utBcUP7RryQqI8z3hg/V PUzZYlGbJLCwksdC5V2bXkWcbjX0AEAL/vErnFXE/LmN/wkCJmwpcfVzJIprU1iydK1r oKXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=pTkXuSKZdEidYDtUquppnkS8GPvDaeca2bpqBFg2VUk=; b=UMS0+xmWaSaIzOveVXJjY2wqC8Ruu1NM/oZ0S8KvEWAm4Rw9ROdEAAqjoFIEJamS/Z SFaROWCnp/MFYicmlqODkN+RSnSNhsKXiHZYll3VjFmfrlyVI2GTp7kZb5p2YnmL+0c7 v3eYwKluL+iZ8C1OSw631EDNN+6toQPX7oCpEAp/sKCfWZo2h2e/ePm7nszLcMJo9cs5 /FIK1sCf0h9sRlJmxDwtPA1M2rwnqzJMXos1uRs9KxVdwJ8wqYL/7PR4yzQQ1KYNVRuM Q5L8T/amv0nd+eBvksPegppIwC/dr/r2kPVVmklpk2F6fDvKVM9xiMAbrmqW1vr9Q6Nb Roew== X-Gm-Message-State: AOAM530acJndpMcpvrSKflV0eYGHRG8lp/YW83FS6hy0D1d7xkVDBMjJ ZQ5foQzpqQMcfl9gwFgkM1Q= X-Google-Smtp-Source: ABdhPJzHfrBMVxX8lg2F1rhL/JoDTXNGv358VL6jn2+Y1jzcadxQmUz0yRx0vf75QYU8VUnSG4huCg== X-Received: by 2002:a17:90a:de08:: with SMTP id m8mr1316255pjv.102.1642017346109; Wed, 12 Jan 2022 11:55:46 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id x12sm448834pjq.52.2022.01.12.11.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 11:55:45 -0800 (PST) Sender: Tejun Heo Date: Wed, 12 Jan 2022 09:55:44 -1000 From: Tejun Heo To: Wei Yang Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] cgroup: rstat: use same convention to assign cgroup_base_stat Message-ID: References: <20220108003817.6619-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220108003817.6619-1-richard.weiyang@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 08, 2022 at 12:38:16AM +0000, Wei Yang wrote: > In function cgroup_base_stat_flush(), we update cgroup_base_stat by > getting rstatc->bstat and adjust delta to related fields. > > There are two convention to assign cgroup_base_stat in this function: > > * rstat2 = rstat1 > * rstat2.cputime = rstat1.cputime > > The second convention may make audience think just field "cputime" is > updated, while cputime is the only field in cgroup_base_stat. > > Let's use the same convention to eliminate this confusion. > > Signed-off-by: Wei Yang Applied 1-2 to cgroup/for-5.18. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 1/2] cgroup: rstat: use same convention to assign cgroup_base_stat Date: Wed, 12 Jan 2022 09:55:44 -1000 Message-ID: References: <20220108003817.6619-1-richard.weiyang@gmail.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pTkXuSKZdEidYDtUquppnkS8GPvDaeca2bpqBFg2VUk=; b=aVDCcfyGG6eZ7fQRZwIpKvAV3p4XQAIsCDHU4V8R68gVluTPXLyO4TF+tuwhm7XNxH 2VFN9RxstCr5amo4nthsCVIpWzI31OwDeQN2LuYI4sWHzWcRLMB7vii4FIcLCxFHvuk1 hQ7tW6OYVeXC6Mkku3+HVMdiL4OicoRI+GOcEe8uOTotfiLnVvGoiJ7mL0/n/Ya0Yqv7 NfCSAd4pxzo1OW1rtcHHA87G7eCWLKSBrG/jHsP4/JaH4No9utBcUP7RryQqI8z3hg/V PUzZYlGbJLCwksdC5V2bXkWcbjX0AEAL/vErnFXE/LmN/wkCJmwpcfVzJIprU1iydK1r oKXw== Sender: Tejun Heo Content-Disposition: inline In-Reply-To: <20220108003817.6619-1-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yang Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Sat, Jan 08, 2022 at 12:38:16AM +0000, Wei Yang wrote: > In function cgroup_base_stat_flush(), we update cgroup_base_stat by > getting rstatc->bstat and adjust delta to related fields. > > There are two convention to assign cgroup_base_stat in this function: > > * rstat2 = rstat1 > * rstat2.cputime = rstat1.cputime > > The second convention may make audience think just field "cputime" is > updated, while cputime is the only field in cgroup_base_stat. > > Let's use the same convention to eliminate this confusion. > > Signed-off-by: Wei Yang Applied 1-2 to cgroup/for-5.18. Thanks. -- tejun