* [PATCH 1/1] RDMA/rxe: Remove the unused variable
@ 2021-12-16 5:48 yanjun.zhu
2022-01-03 8:02 ` Leon Romanovsky
2022-01-05 19:06 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: yanjun.zhu @ 2021-12-16 5:48 UTC (permalink / raw)
To: zyjzyj2000, dledford, jgg, linux-rdma, leon, yanjun.zhu
From: Zhu Yanjun <yanjun.zhu@linux.dev>
The member variable xmit_errors can be replaced with
rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So
remove it.
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/sw/rxe/rxe_net.c | 1 -
drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
index 2cb810cb890a..112506c31b37 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -444,7 +444,6 @@ int rxe_xmit_packet(struct rxe_qp *qp, struct rxe_pkt_info *pkt,
else
err = rxe_send(skb, pkt);
if (err) {
- rxe->xmit_errors++;
rxe_counter_inc(rxe, RXE_CNT_SEND_ERR);
return err;
}
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index 35e041450090..af0117710175 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -392,8 +392,6 @@ struct rxe_dev {
struct net_device *ndev;
- int xmit_errors;
-
struct rxe_pool uc_pool;
struct rxe_pool pd_pool;
struct rxe_pool ah_pool;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] RDMA/rxe: Remove the unused variable
2021-12-16 5:48 [PATCH 1/1] RDMA/rxe: Remove the unused variable yanjun.zhu
@ 2022-01-03 8:02 ` Leon Romanovsky
2022-01-05 19:06 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-01-03 8:02 UTC (permalink / raw)
To: yanjun.zhu; +Cc: zyjzyj2000, dledford, jgg, linux-rdma
On Thu, Dec 16, 2021 at 12:48:42AM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The member variable xmit_errors can be replaced with
> rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So
> remove it.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
> 2 files changed, 3 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] RDMA/rxe: Remove the unused variable
2021-12-16 5:48 [PATCH 1/1] RDMA/rxe: Remove the unused variable yanjun.zhu
2022-01-03 8:02 ` Leon Romanovsky
@ 2022-01-05 19:06 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2022-01-05 19:06 UTC (permalink / raw)
To: yanjun.zhu; +Cc: zyjzyj2000, dledford, linux-rdma, leon
On Thu, Dec 16, 2021 at 12:48:42AM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The member variable xmit_errors can be replaced with
> rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So
> remove it.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
> 2 files changed, 3 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-05 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 5:48 [PATCH 1/1] RDMA/rxe: Remove the unused variable yanjun.zhu
2022-01-03 8:02 ` Leon Romanovsky
2022-01-05 19:06 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.