From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 560A7C433EF for ; Tue, 4 Jan 2022 09:01:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229577AbiADJBJ (ORCPT ); Tue, 4 Jan 2022 04:01:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbiADJBJ (ORCPT ); Tue, 4 Jan 2022 04:01:09 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7F87C061761 for ; Tue, 4 Jan 2022 01:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=W8Jz48f7bRk1ckbh4lsS0Wqn9maF4BXhcKl5LWNLDcE=; b=rKPFBLWVfgwe1ZR7mZ4fAzfexV CM+neKQzyz7koeftNBXpsry0RaGRmOqF7zTj3pU0bzG6c6+P7m+cOxyA0FVLDCXqayEIdl3+Xe/U/ 3wR7qz4qRpgQ1ueeJOHYOuuuz44cmKoSD+vbCXSvoclRIg1rA1CdBhPqHmoIjLVUDbdY6idLUX/l+ QRDb2K7+vW917cWR89mCcE4fP/IdK+t5HHkvruDSkj0q2fIKBia7lPulVvfOYMBK3rKZw0Gobi7sx Rq0MzJMujVMZnOp3RE5zT2HZ3qdsh2WBF/zMT4Ad0DirE0JXzcMiMjj7FlBXzjTVBFUJaAmjhlnqD b9cPUyTQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56546) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n4fgh-0006nD-G9; Tue, 04 Jan 2022 09:00:59 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n4fgf-00075v-EL; Tue, 04 Jan 2022 09:00:57 +0000 Date: Tue, 4 Jan 2022 09:00:57 +0000 From: "Russell King (Oracle)" To: Harini Katakam Cc: Jakub Kicinski , Michal Simek , Radhey Shyam Pandey , Sean Anderson , "David S. Miller" , netdev , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs Message-ID: References: <20211216071513.6d1e0f55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 04, 2022 at 01:26:28PM +0530, Harini Katakam wrote: > On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam wrote: > > > > Hi Russell, > > > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > > wrote: > > > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > > > > being a legacy driver. > > > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > > > > we support switching between SGMII and 1000baseX. However, when clear, > > > > > this also blocks updating the 1000baseX advertisement, which it > > > > > probably should not be doing. Nevertheless, this behaviour is preserved > > > > > but a comment is added. > > > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' > > > > > > Fixed that and the sha1 issue you raised in patch 2. Since both are > > > "documentation" issues, I won't send out replacement patches until > > > I've heard they've been tested on hardware though. > > > > Thanks for the patches. > > Series looks good and we're testing at our end; will get back to you > > early next week. > > Thanks Russell. I've tested AXI Ethernet and it works fine. Happy new year! Thanks - can I use that as a tested-by please, and would you be happy for me to send the patches for merging this week? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24EFDC433EF for ; Tue, 4 Jan 2022 09:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ju+GTPMI9a3O+caa+PApDMynVXu2EEWgQb2Hgb95CLI=; b=r55sEDr7HDRfCB QLptnjhmJT1BI+6O/f4ngrUkAj8y8Gy5n4z2z8g4ig3dzU/cM20APLrvyM49MYi8HJNvUm4qx52Jw /1XKNrypK8QchgcTK2fh1WfBVTFe4GFAIZZTIbSXuiyDCnGJdUCgQys5MgwGrUN1nrtVj4yoH8GtR baXcsbD1uefxiRTdNoLM0XbghgVIZYxsrbjalrGNm3BuPguiUHgD2aj31SQe718oqJm1t3ITWnN6N 9O/AUeZpztCdA4xdf3iJ5Y71Epd9XUObHW2PAoFwSpEX0B7WxZ0TfC6/zo4lZUpG0MA97oGRliiUV 9KD52eIR33VGdfrKfCFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4fkv-00AsXK-KM; Tue, 04 Jan 2022 09:05:23 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4fgu-00ArM4-IV for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 09:01:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=W8Jz48f7bRk1ckbh4lsS0Wqn9maF4BXhcKl5LWNLDcE=; b=rKPFBLWVfgwe1ZR7mZ4fAzfexV CM+neKQzyz7koeftNBXpsry0RaGRmOqF7zTj3pU0bzG6c6+P7m+cOxyA0FVLDCXqayEIdl3+Xe/U/ 3wR7qz4qRpgQ1ueeJOHYOuuuz44cmKoSD+vbCXSvoclRIg1rA1CdBhPqHmoIjLVUDbdY6idLUX/l+ QRDb2K7+vW917cWR89mCcE4fP/IdK+t5HHkvruDSkj0q2fIKBia7lPulVvfOYMBK3rKZw0Gobi7sx Rq0MzJMujVMZnOp3RE5zT2HZ3qdsh2WBF/zMT4Ad0DirE0JXzcMiMjj7FlBXzjTVBFUJaAmjhlnqD b9cPUyTQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56546) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n4fgh-0006nD-G9; Tue, 04 Jan 2022 09:00:59 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n4fgf-00075v-EL; Tue, 04 Jan 2022 09:00:57 +0000 Date: Tue, 4 Jan 2022 09:00:57 +0000 From: "Russell King (Oracle)" To: Harini Katakam Cc: Jakub Kicinski , Michal Simek , Radhey Shyam Pandey , Sean Anderson , "David S. Miller" , netdev , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs Message-ID: References: <20211216071513.6d1e0f55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_010112_668980_1A41D255 X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 04, 2022 at 01:26:28PM +0530, Harini Katakam wrote: > On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam wrote: > > > > Hi Russell, > > > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > > wrote: > > > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > > > > being a legacy driver. > > > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > > > > we support switching between SGMII and 1000baseX. However, when clear, > > > > > this also blocks updating the 1000baseX advertisement, which it > > > > > probably should not be doing. Nevertheless, this behaviour is preserved > > > > > but a comment is added. > > > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' > > > > > > Fixed that and the sha1 issue you raised in patch 2. Since both are > > > "documentation" issues, I won't send out replacement patches until > > > I've heard they've been tested on hardware though. > > > > Thanks for the patches. > > Series looks good and we're testing at our end; will get back to you > > early next week. > > Thanks Russell. I've tested AXI Ethernet and it works fine. Happy new year! Thanks - can I use that as a tested-by please, and would you be happy for me to send the patches for merging this week? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel