From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] Refactoring aio-stress.c using LTP API
Date: Tue, 4 Jan 2022 11:09:21 +0100 [thread overview]
Message-ID: <YdQc0bKswgMze2IA@pevik> (raw)
In-Reply-To: <20220104092049.13033-2-andrea.cervesato@suse.com>
Hi Andrea,
> + ret = asprintf(&msg, " %.0f < %d", lat->deviations[i], deviations[i]);
> + if (ret < 0)
> + tst_brk(TBROK, "asprintf memory allocation error");
> + ptr += sprintf(ptr,"%s", msg);
ptr += sprintf(ptr,"%s", msg);
make check-aio-stress warns: ERROR: space required after that ',' (ctx:VxV)
Otherwise obviously ok, waiting if anybody wants to have a look before I merge
it.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-04 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 9:20 [LTP] [PATCH v3 0/2] aio-stress.c refactoring Andrea Cervesato via ltp
2022-01-04 9:20 ` [LTP] [PATCH v3 1/2] Refactoring aio-stress.c using LTP API Andrea Cervesato via ltp
2022-01-04 10:09 ` Petr Vorel [this message]
2022-01-04 9:20 ` [LTP] [PATCH v3 2/2] Update ltp-aio-stress suites using new options Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdQc0bKswgMze2IA@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.