From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0DBC433F5 for ; Tue, 4 Jan 2022 11:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232328AbiADLdU (ORCPT ); Tue, 4 Jan 2022 06:33:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230229AbiADLdU (ORCPT ); Tue, 4 Jan 2022 06:33:20 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99300C061761; Tue, 4 Jan 2022 03:33:19 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id i22so75522337wrb.13; Tue, 04 Jan 2022 03:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=K1B3s/Iyg8kOfoQT3YZHQpq29FuzQTyUhgevv3DY7WE=; b=QCuzwYMyCxw27llSQlhw08xuDEpypnKLsXZcy24BNHON+BE1JcTmPp5u1iYNcxBJ3h EZ5W2QEd7Qg3JTbVo0S2CBPMG/13XXNYMgtTsGUngU/3QDlCPdB5nq7iSpLFANVjE/Bq oYnuE/3BqOW+TXIMOTeO0+tW7QltgoSUziB5YSvll5tO8O6Jqtk5leCCnCuHkVWUJgZg /B2vXA6LAI3kal7FdtrN/f3uwqSeVmNNyXa1/CI6TnM0Lg3DVJnjp1PJIyqqh9ClM2zS kg6Oc7NS1jz60afuzQKImB2bqL3O88Z2eVpgkYKQg5Bxtj7k4LDJdd/izkRx58tI61cb aing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=K1B3s/Iyg8kOfoQT3YZHQpq29FuzQTyUhgevv3DY7WE=; b=wOk+5ZAynrINVyv/e5Ug9QIYJ70TvSEsIRJWilDef+dWVBrar56sMDSAxgtQvS4w3E QQAjjnOLWXN1Z5gbWDKocqo3FRY9b3jmMovPB+kuhAzFV44IMSnL5/RKd6TOuycaDTPf ymmkTR20O+OKfYmQILn9kkExoj9JZsL7WkEmQKR206EV7u2MvoxomRhZ569m3EUNLyHs 8EsS6Fe/34hldH20s0xGxt3PYFYxmNobQmwAqDwjov/sPDzuMuhypc0Srv0okpXcl+wh uG69jCQSgT4azLGvBNbafaXlpGrdrNw4fXGzlOA18AJiIMl57KQUpTvTGKLapfoQ3Lu2 qBuQ== X-Gm-Message-State: AOAM5329A5Sr3MniowEe+MFY7IYGzOAQdFm31bFT1Luqt2b8Uqn8JBKC 3cJsNx0ZVXtw0kvwtIXm1d0= X-Google-Smtp-Source: ABdhPJzmlL3Q0kCPhxEMRvMnViX7ZIBziNKLzBM51UKace5jcFsIknnh+g2IzyPkDHuJMEgWAXIeIw== X-Received: by 2002:a05:6000:137a:: with SMTP id q26mr18236641wrz.634.1641295998291; Tue, 04 Jan 2022 03:33:18 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id x20sm11436482wmi.43.2022.01.04.03.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 03:33:18 -0800 (PST) Date: Tue, 4 Jan 2022 12:33:15 +0100 From: Corentin Labbe To: "Russell King (Oracle)" Cc: linus.walleij@linaro.org, ulli.kroll@googlemail.com, kuba@kernel.org, davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: phy: marvell: network working with generic PHY and not with marvell PHY Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Tue, Jan 04, 2022 at 11:14:46AM +0000, Russell King (Oracle) a écrit : > On Tue, Jan 04, 2022 at 11:58:01AM +0100, Corentin Labbe wrote: > > Hello > > > > I have a gemini SSI 1328 box which has a cortina ethernet MAC with a Marvell 88E1118 as given by: > > Marvell 88E1118 gpio-0:01: attached PHY driver (mii_bus:phy_addr=gpio-0:01, irq=POLL) > > So booting with CONFIG_MARVELL_PHY=y lead to a non-working network with link set at 1Gbit > > Setting 'max-speed = <100>;' (as current state in mainline dtb) lead to a working network. > > By not working, I mean kernel started with ip=dhcp cannot get an IP. > > How is the PHY connected to the host (which interface mode?) If it's > RGMII, it could be that the wrong RGMII interface mode is specified in > DT. > The PHY is set as RGMII in DT (arch/arm/boot/dts/gemini-ssi1328.dts) The only change to the mainline dtb is removing the max-speed. Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39B26C433EF for ; Tue, 4 Jan 2022 11:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vlU152Ox0Z+Kzux/V5LAOfyz9dKg9tTmws6F9lXxPo4=; b=o8ImkviO0V1pVb +t2DFazNgVXLkK+CD9dLK0TJl9B4t4SoTS5tnxJMNQqnGV6VKa3UZ3/sFNjr81dBxpqEvXhYFTBwS O/5SFwOrTqN59AGdxRUgm3L6T/z+2WFt8QkXxsT/kAnUK4+hdbsajS+yNi8unoVMcS98mBqRqsSCv +WIdvCn9X92k4UiMcrcR0KlJ4TbNQelnTgUG3MFBeFTchqmCWO+6HucjkQaIb67FRFkhaFs8Ts1cJ AGBgBGMeZir1ZKqWCBXy6A1QvOSofdlyhaHrgmxqgRHMu9syDdbjTe7nN4xoVnzSB3YrLdou1DFHY 2xQdyHHPimftwQwZQpNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4i4C-00BIdX-6u; Tue, 04 Jan 2022 11:33:24 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4i48-00BIbV-Mq for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 11:33:21 +0000 Received: by mail-wr1-x429.google.com with SMTP id v7so75448044wrv.12 for ; Tue, 04 Jan 2022 03:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=K1B3s/Iyg8kOfoQT3YZHQpq29FuzQTyUhgevv3DY7WE=; b=QCuzwYMyCxw27llSQlhw08xuDEpypnKLsXZcy24BNHON+BE1JcTmPp5u1iYNcxBJ3h EZ5W2QEd7Qg3JTbVo0S2CBPMG/13XXNYMgtTsGUngU/3QDlCPdB5nq7iSpLFANVjE/Bq oYnuE/3BqOW+TXIMOTeO0+tW7QltgoSUziB5YSvll5tO8O6Jqtk5leCCnCuHkVWUJgZg /B2vXA6LAI3kal7FdtrN/f3uwqSeVmNNyXa1/CI6TnM0Lg3DVJnjp1PJIyqqh9ClM2zS kg6Oc7NS1jz60afuzQKImB2bqL3O88Z2eVpgkYKQg5Bxtj7k4LDJdd/izkRx58tI61cb aing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=K1B3s/Iyg8kOfoQT3YZHQpq29FuzQTyUhgevv3DY7WE=; b=hQjayIdFRgWEwKgbsoOQz6ARlXS8LZJQ6eSniBtd3t/00uHoFW1K5012lEFCEBoEY9 8KLBxcTuhr4AsIyucKUVU6Y9hnWUDICcjX/qzRHBcwKzEnz/WNxX6dsc+rSr+ps1AGfS /xWTWMd1W/Z0cUdcvEwKSSi6su3MR9MeVotoXQ5HiWb4Fgu6WMK9iuJYhc1V931TvQ6b oWsgjY0OK7a7zm8O8fHBb1+OlwTpp/m/fbWCjDPt0RE5vtNr6TH9UCb1tveO0iM+XsPW WJ/VyGBhalSQ1n+UNb5vZABoSS4jZJiQ5+xlWK8jz6X2MfLfMcPkE6M3K6KKjNuI/6q8 cP5A== X-Gm-Message-State: AOAM532W1GMzsOxIE2itegRZi3h8LVGv7jw3BoHpkNH4geogcUNN7VXw 98sdu3uFesKEO3m8/Z3cJ2g= X-Google-Smtp-Source: ABdhPJzmlL3Q0kCPhxEMRvMnViX7ZIBziNKLzBM51UKace5jcFsIknnh+g2IzyPkDHuJMEgWAXIeIw== X-Received: by 2002:a05:6000:137a:: with SMTP id q26mr18236641wrz.634.1641295998291; Tue, 04 Jan 2022 03:33:18 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id x20sm11436482wmi.43.2022.01.04.03.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 03:33:18 -0800 (PST) Date: Tue, 4 Jan 2022 12:33:15 +0100 From: Corentin Labbe To: "Russell King (Oracle)" Cc: linus.walleij@linaro.org, ulli.kroll@googlemail.com, kuba@kernel.org, davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: phy: marvell: network working with generic PHY and not with marvell PHY Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_033320_785054_FD0E1945 X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Tue, Jan 04, 2022 at 11:14:46AM +0000, Russell King (Oracle) a =E9crit : > On Tue, Jan 04, 2022 at 11:58:01AM +0100, Corentin Labbe wrote: > > Hello > > = > > I have a gemini SSI 1328 box which has a cortina ethernet MAC with a Ma= rvell 88E1118 as given by: > > Marvell 88E1118 gpio-0:01: attached PHY driver (mii_bus:phy_addr=3Dgpio= -0:01, irq=3DPOLL) > > So booting with CONFIG_MARVELL_PHY=3Dy lead to a non-working network wi= th link set at 1Gbit > > Setting 'max-speed =3D <100>;' (as current state in mainline dtb) lead = to a working network. > > By not working, I mean kernel started with ip=3Ddhcp cannot get an IP. > = > How is the PHY connected to the host (which interface mode?) If it's > RGMII, it could be that the wrong RGMII interface mode is specified in > DT. > = The PHY is set as RGMII in DT (arch/arm/boot/dts/gemini-ssi1328.dts) The only change to the mainline dtb is removing the max-speed. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel