From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 733F2C433F5 for ; Tue, 4 Jan 2022 11:41:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232452AbiADLlu (ORCPT ); Tue, 4 Jan 2022 06:41:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232327AbiADLls (ORCPT ); Tue, 4 Jan 2022 06:41:48 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B350C061761; Tue, 4 Jan 2022 03:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=titoXQwkTQtPF0RW5RLXQyPOz3CoNfy3Us8bQFyRxUU=; b=V28Os2e9tG5qOMQm1tOh+sV0oG LMbJkmxjVzumYkf4Oi1e0V0qHh9f78zvfHfHXgyxnDtTOITJ4uhnhY3bhh0coJcgWumC1JLo3qAxf UWEbi2gjpmHm07yBqfE20wt1dYXZpRZTsAc8EAPFcNWbwR0TVi5+iK1mdlxchNpLvH2Oy32NhGRYs csFnqv27u6B2QMcKVB60I7vdNMsc4A0upm9qQaBj8okEY/WUNXk7J0YnSPuAI35GIAC+LuW+GAndT h6otIgSRX3pXfbXIpTGn5eAtAzHMt59YuJ/ZQCOkzzv+NABOyNhUCQbeX50IEjkvkdjuLx6xmwHen Uw84RKeg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56554) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n4iCE-0006w1-MZ; Tue, 04 Jan 2022 11:41:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n4iCC-0007Cn-T3; Tue, 04 Jan 2022 11:41:40 +0000 Date: Tue, 4 Jan 2022 11:41:40 +0000 From: "Russell King (Oracle)" To: Corentin Labbe Cc: linus.walleij@linaro.org, ulli.kroll@googlemail.com, kuba@kernel.org, davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: phy: marvell: network working with generic PHY and not with marvell PHY Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 04, 2022 at 12:33:15PM +0100, Corentin Labbe wrote: > Le Tue, Jan 04, 2022 at 11:14:46AM +0000, Russell King (Oracle) a écrit : > > On Tue, Jan 04, 2022 at 11:58:01AM +0100, Corentin Labbe wrote: > > > Hello > > > > > > I have a gemini SSI 1328 box which has a cortina ethernet MAC with a Marvell 88E1118 as given by: > > > Marvell 88E1118 gpio-0:01: attached PHY driver (mii_bus:phy_addr=gpio-0:01, irq=POLL) > > > So booting with CONFIG_MARVELL_PHY=y lead to a non-working network with link set at 1Gbit > > > Setting 'max-speed = <100>;' (as current state in mainline dtb) lead to a working network. > > > By not working, I mean kernel started with ip=dhcp cannot get an IP. > > > > How is the PHY connected to the host (which interface mode?) If it's > > RGMII, it could be that the wrong RGMII interface mode is specified in > > DT. > > > > The PHY is set as RGMII in DT (arch/arm/boot/dts/gemini-ssi1328.dts) > The only change to the mainline dtb is removing the max-speed. So, it's using "rgmii" with no delay configured at the PHY with the speed limited to 100Mbps. You then remove the speed limitation and it doesn't work at 1Gbps. I think I've seen this on other platforms (imx6 + ar8035) when the RGMII delay is not correctly configured - it will work at slower speeds but not 1G. The RGMII spec specifies that there will be a delay - and the delay can be introduced by either the MAC, PHY or by PCB track routing. It sounds to me like your boot environment configures the PHY to introduce the necessary delay, but then, because the DT "rgmii" mode means "no delay at the PHY" when you use the Marvell driver (which respects that), the Marvell driver configures the PHY for no delay, resulting in a non- working situation at 1G. I would suggest checking how the boot environment configures the PHY, and change the "rgmii" mode in DT to match. There is a description of the four RGMII modes in Documentation/networking/phy.rst that may help understand what each one means. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0C31C433F5 for ; Tue, 4 Jan 2022 11:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LY4Q3xHlUqdj3wYgqzGr1n4UB6GjzIYWSSbSqLtlS9w=; b=h6i89ULpS3A6vm gSQJe42RWGTq2zYy5O0lZvuCRKUi2vHLnClVHdl/SuaCylpmysurz51I0hiQi8Vbs6jGQs2RdEfQG AMw90CEUZxwG/hBfbd9theANgF0EezYY1e6GghpZ9MXSqWIKzu+5LEpwVNbaI/lNLQTriCv54R4de owREXepnEKw5WAa3qTuIgsQ9knTkT4Ied/wWeuhFKQ2mwP25Z8ZMaaHG88SMvZHmvuo4J56VRO0Rr RoztLQ8+iv25swL0E2eWtzt6YfpwkhaFLify2intrhMUANfn6UflV8uyYsj01Oa8n30ZhXi7ujPoQ m3AfWpXWjsJ/yDuubaIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4iCO-00BJko-H3; Tue, 04 Jan 2022 11:41:52 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4iCK-00BJjb-QS for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 11:41:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=titoXQwkTQtPF0RW5RLXQyPOz3CoNfy3Us8bQFyRxUU=; b=V28Os2e9tG5qOMQm1tOh+sV0oG LMbJkmxjVzumYkf4Oi1e0V0qHh9f78zvfHfHXgyxnDtTOITJ4uhnhY3bhh0coJcgWumC1JLo3qAxf UWEbi2gjpmHm07yBqfE20wt1dYXZpRZTsAc8EAPFcNWbwR0TVi5+iK1mdlxchNpLvH2Oy32NhGRYs csFnqv27u6B2QMcKVB60I7vdNMsc4A0upm9qQaBj8okEY/WUNXk7J0YnSPuAI35GIAC+LuW+GAndT h6otIgSRX3pXfbXIpTGn5eAtAzHMt59YuJ/ZQCOkzzv+NABOyNhUCQbeX50IEjkvkdjuLx6xmwHen Uw84RKeg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56554) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n4iCE-0006w1-MZ; Tue, 04 Jan 2022 11:41:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n4iCC-0007Cn-T3; Tue, 04 Jan 2022 11:41:40 +0000 Date: Tue, 4 Jan 2022 11:41:40 +0000 From: "Russell King (Oracle)" To: Corentin Labbe Cc: linus.walleij@linaro.org, ulli.kroll@googlemail.com, kuba@kernel.org, davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: phy: marvell: network working with generic PHY and not with marvell PHY Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_034148_889346_35936368 X-CRM114-Status: GOOD ( 22.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 04, 2022 at 12:33:15PM +0100, Corentin Labbe wrote: > Le Tue, Jan 04, 2022 at 11:14:46AM +0000, Russell King (Oracle) a =E9crit= : > > On Tue, Jan 04, 2022 at 11:58:01AM +0100, Corentin Labbe wrote: > > > Hello > > > = > > > I have a gemini SSI 1328 box which has a cortina ethernet MAC with a = Marvell 88E1118 as given by: > > > Marvell 88E1118 gpio-0:01: attached PHY driver (mii_bus:phy_addr=3Dgp= io-0:01, irq=3DPOLL) > > > So booting with CONFIG_MARVELL_PHY=3Dy lead to a non-working network = with link set at 1Gbit > > > Setting 'max-speed =3D <100>;' (as current state in mainline dtb) lea= d to a working network. > > > By not working, I mean kernel started with ip=3Ddhcp cannot get an IP. > > = > > How is the PHY connected to the host (which interface mode?) If it's > > RGMII, it could be that the wrong RGMII interface mode is specified in > > DT. > > = > = > The PHY is set as RGMII in DT (arch/arm/boot/dts/gemini-ssi1328.dts) > The only change to the mainline dtb is removing the max-speed. So, it's using "rgmii" with no delay configured at the PHY with the speed limited to 100Mbps. You then remove the speed limitation and it doesn't work at 1Gbps. I think I've seen this on other platforms (imx6 + ar8035) when the RGMII delay is not correctly configured - it will work at slower speeds but not 1G. The RGMII spec specifies that there will be a delay - and the delay can be introduced by either the MAC, PHY or by PCB track routing. It sounds to me like your boot environment configures the PHY to introduce the necessary delay, but then, because the DT "rgmii" mode means "no delay at the PHY" when you use the Marvell driver (which respects that), the Marvell driver configures the PHY for no delay, resulting in a non- working situation at 1G. I would suggest checking how the boot environment configures the PHY, and change the "rgmii" mode in DT to match. There is a description of the four RGMII modes in Documentation/networking/phy.rst that may help understand what each one means. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel