From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65AFFC433FE for ; Tue, 4 Jan 2022 13:08:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233317AbiADNIQ (ORCPT ); Tue, 4 Jan 2022 08:08:16 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:49696 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232078AbiADNIN (ORCPT ); Tue, 4 Jan 2022 08:08:13 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 625E96135E; Tue, 4 Jan 2022 13:08:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 130B1C36AEF; Tue, 4 Jan 2022 13:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1641301692; bh=mT5t79gxCgRdT1vNcMcGQnrvh/Z6pQHv2BwjqHfeFy8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fKRY9zkTPp3BP+ryztGtFWSEw0kyX0BM2Uf2v3VZK6GCUVOr6rnw3hzih2LhKe2Wi YdL6yux9ihG5mBuIvYPn9TY2ER/O//0iHoOJ+kRPUZTH/pvUQr+jz5IqdmRogD9e9I zMvA2mLwuJ2ds7EvjPMoNPox+9VGjjtx5nfvN100= Date: Tue, 4 Jan 2022 14:04:09 +0100 From: Greg Kroah-Hartman To: Jason Gunthorpe Cc: Christoph Hellwig , Lu Baolu , Joerg Roedel , Alex Williamson , Bjorn Helgaas , Kevin Tian , Ashok Raj , Will Deacon , Robin Murphy , Dan Williams , rafael@kernel.org, Diana Craciun , Cornelia Huck , Eric Auger , Liu Yi L , Jacob jun Pan , Chaitanya Kulkarni , Stuart Yoder , Laurentiu Tudor , Thierry Reding , David Airlie , Daniel Vetter , Jonathan Hunter , Li Yang , Dmitry Osipenko , iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 02/14] driver core: Add dma_cleanup callback in bus_type Message-ID: References: <20220104015644.2294354-1-baolu.lu@linux.intel.com> <20220104015644.2294354-3-baolu.lu@linux.intel.com> <20220104123911.GE2328285@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220104123911.GE2328285@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 04, 2022 at 08:39:11AM -0400, Jason Gunthorpe wrote: > On Tue, Jan 04, 2022 at 02:08:36AM -0800, Christoph Hellwig wrote: > > All these bus callouts still looks horrible and just create tons of > > boilerplate code. > > Yes, Lu - Greg asked questions then didn't respond to their answers > meaning he accepts them, you should stick with the v4 version. Trying to catch up on emails from the break, that was way down my list of things to get back to as it's messy and non-obvious. I'll revisit it again after 5.17-rc1 is out, this is too late for that merge window anyway. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B156C433EF for ; Tue, 4 Jan 2022 13:08:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3496B81434; Tue, 4 Jan 2022 13:08:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sW4qygPwICio; Tue, 4 Jan 2022 13:08:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id CB79E823CB; Tue, 4 Jan 2022 13:08:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AE9CBC0030; Tue, 4 Jan 2022 13:08:19 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 15E6BC001E for ; Tue, 4 Jan 2022 13:08:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EB0B481434 for ; Tue, 4 Jan 2022 13:08:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6DrS7RjyQWLE for ; Tue, 4 Jan 2022 13:08:14 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7626F823CB for ; Tue, 4 Jan 2022 13:08:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D67261295; Tue, 4 Jan 2022 13:08:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 130B1C36AEF; Tue, 4 Jan 2022 13:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1641301692; bh=mT5t79gxCgRdT1vNcMcGQnrvh/Z6pQHv2BwjqHfeFy8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fKRY9zkTPp3BP+ryztGtFWSEw0kyX0BM2Uf2v3VZK6GCUVOr6rnw3hzih2LhKe2Wi YdL6yux9ihG5mBuIvYPn9TY2ER/O//0iHoOJ+kRPUZTH/pvUQr+jz5IqdmRogD9e9I zMvA2mLwuJ2ds7EvjPMoNPox+9VGjjtx5nfvN100= Date: Tue, 4 Jan 2022 14:04:09 +0100 From: Greg Kroah-Hartman To: Jason Gunthorpe Subject: Re: [PATCH v5 02/14] driver core: Add dma_cleanup callback in bus_type Message-ID: References: <20220104015644.2294354-1-baolu.lu@linux.intel.com> <20220104015644.2294354-3-baolu.lu@linux.intel.com> <20220104123911.GE2328285@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220104123911.GE2328285@nvidia.com> Cc: Stuart Yoder , rafael@kernel.org, David Airlie , linux-pci@vger.kernel.org, Thierry Reding , Diana Craciun , Dmitry Osipenko , Will Deacon , Ashok Raj , Jonathan Hunter , Christoph Hellwig , Kevin Tian , Chaitanya Kulkarni , Alex Williamson , kvm@vger.kernel.org, Bjorn Helgaas , Dan Williams , Cornelia Huck , linux-kernel@vger.kernel.org, Li Yang , iommu@lists.linux-foundation.org, Jacob jun Pan , Daniel Vetter , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jan 04, 2022 at 08:39:11AM -0400, Jason Gunthorpe wrote: > On Tue, Jan 04, 2022 at 02:08:36AM -0800, Christoph Hellwig wrote: > > All these bus callouts still looks horrible and just create tons of > > boilerplate code. > > Yes, Lu - Greg asked questions then didn't respond to their answers > meaning he accepts them, you should stick with the v4 version. Trying to catch up on emails from the break, that was way down my list of things to get back to as it's messy and non-obvious. I'll revisit it again after 5.17-rc1 is out, this is too late for that merge window anyway. thanks, greg k-h _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu