From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpio: tps68470: Allow building as module
Date: Tue, 4 Jan 2022 16:08:28 +0200 [thread overview]
Message-ID: <YdRU3DVsByJzyXmn@smile.fi.intel.com> (raw)
In-Reply-To: <CAHp75Vdz1zxE5V_ff+jSp6VUo34aRinLj-gK_HOi5-2Zgw3E8w@mail.gmail.com>
On Sat, Dec 25, 2021 at 04:41:58PM +0200, Andy Shevchenko wrote:
> On Sat, Dec 25, 2021 at 2:00 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > The gpio-tps68470 driver binds to a tps68470-gpio platform-device which
> > itself gets instantiated by a special MFD driver from
> > drivers/platform/x86/intel/int3472/tps68470.c
> >
> > This MFD driver itself can be build as a module, so it makes no sense to
>
> built
>
> > force the gpio-tps68470 driver to always be builtin.
>
> built-in
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> (see one minor comment below)
I don't see the next version, in any case it's too far from the beginning of
the v5.16 cycle and I gave my tags so Bart may (or may not :-) apply them. If
it's okay to be v5.18 material, I'll take a new version sent after v5.17-rc1.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-04 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 12:00 [PATCH 1/2] gpio: tps68470: Allow building as module Hans de Goede
2021-12-25 12:00 ` [PATCH 2/2] gpio: crystalcove: Set IRQ domain bus token to DOMAIN_BUS_WIRED Hans de Goede
2021-12-25 14:44 ` Andy Shevchenko
2021-12-25 14:41 ` [PATCH 1/2] gpio: tps68470: Allow building as module Andy Shevchenko
2022-01-04 14:08 ` Andy Shevchenko [this message]
2022-01-11 10:42 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdRU3DVsByJzyXmn@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.