From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244C6C433FE for ; Wed, 5 Jan 2022 21:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244366AbiAEVMm (ORCPT ); Wed, 5 Jan 2022 16:12:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244353AbiAEVMi (ORCPT ); Wed, 5 Jan 2022 16:12:38 -0500 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42EC9C061201 for ; Wed, 5 Jan 2022 13:12:38 -0800 (PST) Received: by mail-il1-x130.google.com with SMTP id o1so371383ilo.6 for ; Wed, 05 Jan 2022 13:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+IvGtL/Cdr/WsdAI8BblKEPdwrJXksPcRkkKFt5itRQ=; b=ZaehH+x5c0zMI/IfYQs/P2s8KjVJpoFcoUPnh+aQ843si2v3nD3DC7aBVH2zE+H7IV XtKaomiGdT9vzvdrdiYMNczQ4NKF5buM1kOQS4NV1m8sbZ7/KvWCfG6wlcavCzgDRu3z IcI7k4fHp3NQ8f1SrS8r5KhG3fearM36RhnFmjv5QN+q4bMI8CpX03N+yOPa4NpnXfdV u7ez66TZ5917ahjPpH/7swu5B4GjVkgttA13c7TRCjugt20r8n4f0zTa9bIJ1pCFcC69 PhdYDdzGv14ETQauuHZaLzl4lRqnrBcSApmHgmYtJAwIvVNNup/UqMg0qa8XdhM6Q1XM f0hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+IvGtL/Cdr/WsdAI8BblKEPdwrJXksPcRkkKFt5itRQ=; b=1A8fu5Qdi0SI0AWnb18F2YcbkJ3ho7CN/4XCs+3aUkExv2J9Qy45jQTFRmPaGz+lCK bAdDc7+X/5yOBjHG963pVMhyfmpyHf0y/6F13+6p7748vnF61+OsyvcTJuIjnpiBxDQE EWJiGYglt9sLUhIP4i+J9ukldZCD99qrcM4lOx6USZgSajJQ1IOnu4tqDpCcrMiraZeJ SJTQSMXOEYkvcWADaUKf2QdxPmtOL62+LHQQzAACfwjdIVqmxBxdiCUeIZyvgAicLTsN GB50LfSqdmeR2R4vwE+VPmuo/EJuiaiDzkL/TOito5MVmhUQGvv7Nm/XWturC5tcrHtF V8Ow== X-Gm-Message-State: AOAM532aFlSE+E3iaXz9+/CinDvXNYjsYnJ7R6h2lhE1mRreksCwaSA8 IC1ZU+Gh5CDtC8CCle9MiLkMmA== X-Google-Smtp-Source: ABdhPJw1baUlWmMI6qXqkj6NLFvmqM5nQ0X8KL8YRZ2jVPVCm0ebJk8cq3iWAIKjjYEoHOCd/Ir/iA== X-Received: by 2002:a05:6e02:148c:: with SMTP id n12mr27203549ilk.51.1641417157408; Wed, 05 Jan 2022 13:12:37 -0800 (PST) Received: from google.com ([2620:15c:183:200:5b02:855e:267d:5b0]) by smtp.gmail.com with ESMTPSA id z16sm907465ilz.60.2022.01.05.13.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 13:12:36 -0800 (PST) Date: Wed, 5 Jan 2022 14:12:33 -0700 From: Yu Zhao To: Linus Torvalds Cc: Andrew Morton , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , Linux ARM , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Linux-MM , page-reclaim@google.com, the arch/x86 maintainers Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 04, 2022 at 01:43:13PM -0800, Linus Torvalds wrote: > On Tue, Jan 4, 2022 at 12:30 PM Yu Zhao wrote: > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. > > I'll leave this to Andrew. I had some stylistic nits, but all the > actual complexity is in that aging and eviction, and while I looked at > the patches, I certainly couldn't make much of a judgement on them. > > The proof is in the numbers, and they look fine, but who knows what > happens when others test it. I don't see anything that looks worrisome > per se, I just see the silly small things that made me go "Eww". I appreciate your time, I'll address all your comments togather with others' in the next spin, after I hear from Andrew. (I'm assuming he will have comments too.) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A731FC4332F for ; Wed, 5 Jan 2022 21:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7OUeB5RDWQ5l8Ksk+0/SFWSLE+uXs4hqqSQY78Pb7/U=; b=KPoH+JNWhpwrhX vwUjoXPfw71j291XWUgzWmFr3R24a3/zwCs1N821BKrxeF4Uvc6bW2WITBJJiTn31li1+iQpzNSau j9+Gv/usKWFANnoqVq2bGt64SpOvDgjDMTY4HEfCu3zwKV/UkfyLzfStyUGhqZ1qXhEV145BlhtIv 5NRDTN4JaaK++fqVi0lxaSTp0C9BSSqqEjjpbzLUBKSWL2Pe7e7OuAAo8TIbCS6MGgzR5NfxJRnyy aNXFn+y/Y44Le33Anzuzq1JAsaBl8yRTHFTbtgRsI1g5kA7aeD1pn6izM5pRBf8lrMWC8Kmp6CW1W bIFt6U2IDLLm7ji9Uumw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5DaL-00Fsdk-CJ; Wed, 05 Jan 2022 21:12:41 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5DaI-00Fscb-O0 for linux-arm-kernel@lists.infradead.org; Wed, 05 Jan 2022 21:12:40 +0000 Received: by mail-il1-x130.google.com with SMTP id d14so556673ila.1 for ; Wed, 05 Jan 2022 13:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+IvGtL/Cdr/WsdAI8BblKEPdwrJXksPcRkkKFt5itRQ=; b=ZaehH+x5c0zMI/IfYQs/P2s8KjVJpoFcoUPnh+aQ843si2v3nD3DC7aBVH2zE+H7IV XtKaomiGdT9vzvdrdiYMNczQ4NKF5buM1kOQS4NV1m8sbZ7/KvWCfG6wlcavCzgDRu3z IcI7k4fHp3NQ8f1SrS8r5KhG3fearM36RhnFmjv5QN+q4bMI8CpX03N+yOPa4NpnXfdV u7ez66TZ5917ahjPpH/7swu5B4GjVkgttA13c7TRCjugt20r8n4f0zTa9bIJ1pCFcC69 PhdYDdzGv14ETQauuHZaLzl4lRqnrBcSApmHgmYtJAwIvVNNup/UqMg0qa8XdhM6Q1XM f0hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+IvGtL/Cdr/WsdAI8BblKEPdwrJXksPcRkkKFt5itRQ=; b=qtZUwAw3ILJTKtL9OGdyVLUOSuXNkDO1GYWTzzl5MZjo8fukSlr3fH3ecOIG4LmqL6 O4oArunw7Pyl8dGlMNz2ddpKgIzWc9mqvM3zNtQVtKRZXmPPgjpcBibRYF5+Bm/wWFkW q7HjJZjhEpVGa6xyNoAB1+SezT0NboCDqb77mo/blzJNhMbWvx/D523WebFA72GxWqEw nYcpzJfSUorewcZBDJwQ3Br1PqNffe+nUK7uKeBGcgW0hIbPI23hJ85IunoYhCkecWUA a32euFdTiJq4w5eEbQS3bIRO3ueUd7cb0CrCdTFIFJnGIZwuKbOl187dTFMy0DVXCt2b m46A== X-Gm-Message-State: AOAM532kz9ZXxaQrRwxIw+Jw0PucjiSQANEAts1ry63D5XLUJZLIqUqH cHug8iIJnIn4ON3EdHE7uD4MJg== X-Google-Smtp-Source: ABdhPJw1baUlWmMI6qXqkj6NLFvmqM5nQ0X8KL8YRZ2jVPVCm0ebJk8cq3iWAIKjjYEoHOCd/Ir/iA== X-Received: by 2002:a05:6e02:148c:: with SMTP id n12mr27203549ilk.51.1641417157408; Wed, 05 Jan 2022 13:12:37 -0800 (PST) Received: from google.com ([2620:15c:183:200:5b02:855e:267d:5b0]) by smtp.gmail.com with ESMTPSA id z16sm907465ilz.60.2022.01.05.13.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 13:12:36 -0800 (PST) Date: Wed, 5 Jan 2022 14:12:33 -0700 From: Yu Zhao To: Linus Torvalds Cc: Andrew Morton , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , Linux ARM , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Linux-MM , page-reclaim@google.com, the arch/x86 maintainers Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220105_131238_810700_195A272D X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 04, 2022 at 01:43:13PM -0800, Linus Torvalds wrote: > On Tue, Jan 4, 2022 at 12:30 PM Yu Zhao wrote: > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. > > I'll leave this to Andrew. I had some stylistic nits, but all the > actual complexity is in that aging and eviction, and while I looked at > the patches, I certainly couldn't make much of a judgement on them. > > The proof is in the numbers, and they look fine, but who knows what > happens when others test it. I don't see anything that looks worrisome > per se, I just see the silly small things that made me go "Eww". I appreciate your time, I'll address all your comments togather with others' in the next spin, after I hear from Andrew. (I'm assuming he will have comments too.) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel