From: Mark Brown <broonie@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, vladimir.oltean@nxp.com
Subject: Re: [PATCH net-next] ptp: don't include ptp_clock_kernel.h in spi.h
Date: Fri, 7 Jan 2022 16:01:33 +0000 [thread overview]
Message-ID: <Ydhj3QP2VxXIWfZq@sirena.org.uk> (raw)
In-Reply-To: <20220107155645.806985-1-kuba@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Fri, Jan 07, 2022 at 07:56:45AM -0800, Jakub Kicinski wrote:
> Commit b42faeee718c ("spi: Add a PTP system timestamp
> to the transfer structure") added an include of ptp_clock_kernel.h
> to spi.h for struct ptp_system_timestamp but a forward declaration
> is enough. Let's use that to limit the number of objects we have
> to rebuild every time we touch networking headers.
Nack, this is a purely SPI patch and should go via SPI (and you've not
even bothered to fix the subject line). It's already in my queue with
that fixed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-07 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 15:56 [PATCH net-next] ptp: don't include ptp_clock_kernel.h in spi.h Jakub Kicinski
2022-01-07 16:01 ` Mark Brown [this message]
2022-01-07 16:51 ` Jakub Kicinski
2022-01-07 17:48 ` Mark Brown
2022-01-07 18:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydhj3QP2VxXIWfZq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.