From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DE7AC433F5 for ; Mon, 10 Jan 2022 12:18:41 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3BB1C3C93A6 for ; Mon, 10 Jan 2022 13:18:39 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 4B4623C07BA for ; Mon, 10 Jan 2022 13:18:29 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id A1F432000DF for ; Mon, 10 Jan 2022 13:18:28 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D864B210EE; Mon, 10 Jan 2022 12:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641817107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LstIyx6nbwXbPuQdC6qxFTFAd1kbPI8icRG2HJ3ri1k=; b=RdprpUvZdvuUa85wgZbVkp4gc8PoegiMBlq3HlIiI2ill/cvQhZXBFgHiYigccXYbJSyjx 1lA8U2ptU+DDcpyticsm4yyFThsqrppQyJ6Xa5hlIZMvP1yxQdFeztYSB2lG1LxRyP2RNc F7yTKYuVQ2w7+BKGfrNWGSKqg4fPDh4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641817107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LstIyx6nbwXbPuQdC6qxFTFAd1kbPI8icRG2HJ3ri1k=; b=M8ZJhgLdg7gUv+W5KkPwoNFmEPSqIvtUscpoeQNytZ0tPA3Vb4o6a1uhZECnQX0BXwwn2c Qb/Nnqs2c2YIxVBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB90313CCB; Mon, 10 Jan 2022 12:18:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 53kNLRMk3GEZDwAAMHmgww (envelope-from ); Mon, 10 Jan 2022 12:18:27 +0000 Date: Mon, 10 Jan 2022 13:20:02 +0100 From: Cyril Hrubis To: Yang Xu Message-ID: References: <1641779349-8424-1-git-send-email-xuyang2018.jy@fujitsu.com> <1641779349-8424-2-git-send-email-xuyang2018.jy@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1641779349-8424-2-git-send-email-xuyang2018.jy@fujitsu.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 2/4] lib: Introduce KCONFIG_SKIP_CHECK environment variable X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > This environment variable is designed to add kernel config check functionality > switch. So we can skip kconfig check completely and it is useful especially > for the embedded platforms that they don't have kernel config. > > Signed-off-by: Yang Xu > --- > doc/user-guide.txt | 1 + > lib/tst_kconfig.c | 20 ++++++++++++++++++++ > lib/tst_test.c | 1 + > 3 files changed, 22 insertions(+) > > diff --git a/doc/user-guide.txt b/doc/user-guide.txt > index 494652618..864467f60 100644 > --- a/doc/user-guide.txt > +++ b/doc/user-guide.txt > @@ -10,6 +10,7 @@ For running LTP network tests see `testcases/network/README.md`. > |============================================================================== > | 'KCONFIG_PATH' | The path to the kernel config file, (if not set, it tries > the usual paths '/boot/config-RELEASE' or '/proc/config.gz'). > +| 'KCONFIG_SKIP_CHECK' | Skip kernel config check, the default is empty(don't skip). ^ Space here please > | 'LTPROOT' | Prefix for installed LTP, the default is '/opt/ltp'. > | 'LTP_COLORIZE_OUTPUT' | Force colorized output behaviour. 'y' or '1': always colorize > 'n' or '0': never colorize. > diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c > index 7d7aecfc1..e4264101d 100644 > --- a/lib/tst_kconfig.c > +++ b/lib/tst_kconfig.c > @@ -15,6 +15,16 @@ > #include "tst_kconfig.h" > #include "tst_bool_expr.h" > > +static int kconfig_check_skipped(void) ^ I would have named this same as the variable, i.e. kconfig_skip_check() Other that these two minor things: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp