From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5684C433F5 for ; Mon, 10 Jan 2022 15:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236335AbiAJPiS (ORCPT ); Mon, 10 Jan 2022 10:38:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233743AbiAJPiR (ORCPT ); Mon, 10 Jan 2022 10:38:17 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF10C06173F for ; Mon, 10 Jan 2022 07:38:16 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id x4so2347023wru.7 for ; Mon, 10 Jan 2022 07:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zYb/b2eN9/xxenlM3wRxRRdx4QgyTjqcoOjnTYvHl8Y=; b=jr3s3gUNQLaELn3BiUstpJOD3qP44llteog38teNUMkkzXnxP973PoY8Pxmx+9LuXQ CSQxYPNwgJCG5eHItofZCzgxYQZwSDwW8sTbBzktRRupG1duLRT1JM2SSL1mDkGd6Umt hrsJ5276dyeSly/rH59fJmGD2E1EeqdfmUs2p2g9CtixSJyAhu0LeQ3L+suPSp6MmI3/ uOmoo+DeQ2cV42IGf4uRanKLaVU6btt9FISxS48fW89888iS3gZ5CeieEka5OtxRB/Hn ogo1UZ0vAlfChyluX//wx9R5ZOm6DyVsxJSJ+49SDWdTlOf4SUJ0pSQVzFJTKUh9YRGb NOAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zYb/b2eN9/xxenlM3wRxRRdx4QgyTjqcoOjnTYvHl8Y=; b=ejKggDyVLMDJ5S/EG15RcUnwbWqrhFRsl8wg9tcBvXegSZl1IUzw9Hdif1L7SlctGS E+/pMZZiEhL+cfWJWjCUDujJMVMcpEazVf2bEC9+ixAM4xKt6NP7+WnGu2vl+MOcUdFU a8F/AdNZFlXx9OgyAxn+qt+Uvr6yG29r+0J+LuwSV8hHgSKmqOBOPVJzhXQlcGubxqi8 frCh87QnotcdTSEJv456Xqg1iQE9bhhVl2sM20b2axJ7RdRVdvRMnZ1Q1RvpiGp2mEQX g+2x8x3whywSzREmCBLevkO0iLTgNUGMOcH8BHnxrCCUCFM1wjYK6//PH6AQcuijjhID UIIw== X-Gm-Message-State: AOAM5317l5hPOdb3xslbGiZHZEEvavQuIG8OUPVwO6zW7jknkIbJNcCy RJMyGaypco1367+pyQjiI/F63A== X-Google-Smtp-Source: ABdhPJziX28sEa5ijCKSY/r3feNH1vgCBSTwVExJgIw4NhbYSnqyALWrvsW1r5ujIYqjlpaU1oEbNw== X-Received: by 2002:adf:df0a:: with SMTP id y10mr183503wrl.360.1641829095355; Mon, 10 Jan 2022 07:38:15 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id j13sm7504485wmq.11.2022.01.10.07.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 07:38:14 -0800 (PST) Date: Mon, 10 Jan 2022 15:38:12 +0000 From: Lee Jones To: Claudiu Beznea Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, romain.izard.pro@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Codrin Ciubotariu Subject: Re: [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Message-ID: References: <20211028135138.3481166-1-claudiu.beznea@microchip.com> <20211028135138.3481166-3-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211028135138.3481166-3-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Oct 2021, Claudiu Beznea wrote: > Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation > mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might > be connected critical devices (like PMIC) which on suspend/resume should > be suspended/resumed at the end/beginning. i2c uses > .suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom > to use .resume_noirq as it should be resumed before the embedded IPs. > Otherwise the embedded devices might behave badly. > > Fixes: 7fdec11015c3 ("atmel_flexcom: Support resuming after a chip reset") > Signed-off-by: Claudiu Beznea > Tested-by: Codrin Ciubotariu > Acked-by: Nicolas Ferre > --- > drivers/mfd/atmel-flexcom.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c > index 962f66dc8813..559eb4d352b6 100644 > --- a/drivers/mfd/atmel-flexcom.c > +++ b/drivers/mfd/atmel-flexcom.c > @@ -87,7 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match); > > -static int __maybe_unused atmel_flexcom_resume(struct device *dev) > +static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev) > { > struct atmel_flexcom *ddata = dev_get_drvdata(dev); > int err; > @@ -105,8 +105,9 @@ static int __maybe_unused atmel_flexcom_resume(struct device *dev) > return 0; > } > > -static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL, > - atmel_flexcom_resume); > +static const struct dev_pm_ops atmel_flexcom_pm_ops = { > + .resume_noirq = atmel_flexcom_resume_noirq, Doesn't this mean you can remove __maybe_unused? > +}; > > static struct platform_driver atmel_flexcom_driver = { > .probe = atmel_flexcom_probe, -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54DB6C433EF for ; Mon, 10 Jan 2022 15:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TjpgdcMH8UBz/eg7PIqQQN8jYiAcgsZHtW9VGMGjRAY=; b=JEHrDPK6NfzSVo F6jSjjoWoOn0n4DEkd0mnmjo3Awur13a3UqcTAgTVcWXK9KSDgdqxkEUrFChzipeeoo85RERyjFkA zIsC3vlMqE4xYMBpqzjai1x1R0HJncu5qM38vPRXk6rAXKRGMvcDYDFnt/qeQbSGbjVjqtSAmmq/c 0+tkh91Yna7F/oyTB97hbWvNVjUKTfYh2iNiyHjgXBsMyTdZFeA0PalusKAij205a9DovPrK0ox7Y nDP1Grq0FIt/27PdcVVprdx86qCHuaITYW+iocEmWeom+2rNmUvGa7VeiGFYHqnUW5hBak6JGtk67 Vfpw4C7kWIIp5cRRGT9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6wkW-00C6IT-FG; Mon, 10 Jan 2022 15:38:20 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6wkT-00C6HC-7c for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 15:38:18 +0000 Received: by mail-wr1-x436.google.com with SMTP id v6so27449864wra.8 for ; Mon, 10 Jan 2022 07:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zYb/b2eN9/xxenlM3wRxRRdx4QgyTjqcoOjnTYvHl8Y=; b=jr3s3gUNQLaELn3BiUstpJOD3qP44llteog38teNUMkkzXnxP973PoY8Pxmx+9LuXQ CSQxYPNwgJCG5eHItofZCzgxYQZwSDwW8sTbBzktRRupG1duLRT1JM2SSL1mDkGd6Umt hrsJ5276dyeSly/rH59fJmGD2E1EeqdfmUs2p2g9CtixSJyAhu0LeQ3L+suPSp6MmI3/ uOmoo+DeQ2cV42IGf4uRanKLaVU6btt9FISxS48fW89888iS3gZ5CeieEka5OtxRB/Hn ogo1UZ0vAlfChyluX//wx9R5ZOm6DyVsxJSJ+49SDWdTlOf4SUJ0pSQVzFJTKUh9YRGb NOAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zYb/b2eN9/xxenlM3wRxRRdx4QgyTjqcoOjnTYvHl8Y=; b=d1LD9TduIAPNrdxn7dvNkwleamp5g6hYvPqoHcJmKph3pBcIy6JDM54M+j/7UM3pJo 1cHcI6bdDAiAvNuUs9IMDUOoY32v8NCblAGNVLGN/wdQ7zy5rgZS4iTDTLgPxOI5k3bN Q/RoPjYe+WfCtO7Vi11jUZy3bHTOI7GLwqWct4KwLfn9slyBLLlGQ8MtXKq2vstNO8yl uJQ+V/UXuAZSOEaprAT/0WZ6kal+CNj5FfZrUEdwjRPOq0UuPxzJ841VniuTfu9iqwZW l9RRZaFLQUYj5mX+hmZGWebe4P+fJk/Q3TM60bQd5wVDZ/yAPbQJsB7xIQEf5v3pW85s 14yg== X-Gm-Message-State: AOAM533URggiejP4BH1sTo5MYvEvO22iA+4VVUSkb5z9UIIZXukggV2r vBPpTBtPhgJH3XkNjCOShat2wQ== X-Google-Smtp-Source: ABdhPJziX28sEa5ijCKSY/r3feNH1vgCBSTwVExJgIw4NhbYSnqyALWrvsW1r5ujIYqjlpaU1oEbNw== X-Received: by 2002:adf:df0a:: with SMTP id y10mr183503wrl.360.1641829095355; Mon, 10 Jan 2022 07:38:15 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id j13sm7504485wmq.11.2022.01.10.07.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 07:38:14 -0800 (PST) Date: Mon, 10 Jan 2022 15:38:12 +0000 From: Lee Jones To: Claudiu Beznea Subject: Re: [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Message-ID: References: <20211028135138.3481166-1-claudiu.beznea@microchip.com> <20211028135138.3481166-3-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211028135138.3481166-3-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_073817_310178_33EC03BD X-CRM114-Status: GOOD ( 21.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, romain.izard.pro@gmail.com, Codrin Ciubotariu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyOCBPY3QgMjAyMSwgQ2xhdWRpdSBCZXpuZWEgd3JvdGU6Cgo+IEZsZXhjb20gSVAg ZW1iZWRzIDMgb3RoZXIgSVBzOiB1c2FydCwgaTJjLCBzcGkgYW5kIHNlbGVjdHMgdGhlIG9wZXJh dGlvbgo+IG1vZGUgKHVzYXJ0LCBpMmMsIHNwaSkgdmlhIG1vZGUgcmVnaXN0ZXIgKEZMRVhfTVIp LiBPbiBpMmMgYnVzIHRoZXJlIG1pZ2h0Cj4gYmUgY29ubmVjdGVkIGNyaXRpY2FsIGRldmljZXMg KGxpa2UgUE1JQykgd2hpY2ggb24gc3VzcGVuZC9yZXN1bWUgc2hvdWxkCj4gYmUgc3VzcGVuZGVk L3Jlc3VtZWQgYXQgdGhlIGVuZC9iZWdpbm5pbmcuIGkyYyB1c2VzCj4gLnN1c3BlbmRfbm9pcnEv LnJlc3VtZV9ub2lycSBmb3IgdGhpcyBraW5kIG9mIHB1cnBvc2VzLiBBbGlnbiBmbGV4Y29tCj4g dG8gdXNlIC5yZXN1bWVfbm9pcnEgYXMgaXQgc2hvdWxkIGJlIHJlc3VtZWQgYmVmb3JlIHRoZSBl bWJlZGRlZCBJUHMuCj4gT3RoZXJ3aXNlIHRoZSBlbWJlZGRlZCBkZXZpY2VzIG1pZ2h0IGJlaGF2 ZSBiYWRseS4KPiAKPiBGaXhlczogN2ZkZWMxMTAxNWMzICgiYXRtZWxfZmxleGNvbTogU3VwcG9y dCByZXN1bWluZyBhZnRlciBhIGNoaXAgcmVzZXQiKQo+IFNpZ25lZC1vZmYtYnk6IENsYXVkaXUg QmV6bmVhIDxjbGF1ZGl1LmJlem5lYUBtaWNyb2NoaXAuY29tPgo+IFRlc3RlZC1ieTogQ29kcmlu IENpdWJvdGFyaXUgPGNvZHJpbi5jaXVib3Rhcml1QG1pY3JvY2hpcC5jb20+Cj4gQWNrZWQtYnk6 IE5pY29sYXMgRmVycmUgPG5pY29sYXMuZmVycmVAbWljcm9jaGlwLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9tZmQvYXRtZWwtZmxleGNvbS5jIHwgNyArKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv bWZkL2F0bWVsLWZsZXhjb20uYyBiL2RyaXZlcnMvbWZkL2F0bWVsLWZsZXhjb20uYwo+IGluZGV4 IDk2MmY2NmRjODgxMy4uNTU5ZWI0ZDM1MmI2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL2F0 bWVsLWZsZXhjb20uYwo+ICsrKyBiL2RyaXZlcnMvbWZkL2F0bWVsLWZsZXhjb20uYwo+IEBAIC04 Nyw3ICs4Nyw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGF0bWVsX2ZsZXhj b21fb2ZfbWF0Y2hbXSA9IHsKPiAgfTsKPiAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgYXRtZWxf ZmxleGNvbV9vZl9tYXRjaCk7Cj4gIAo+IC1zdGF0aWMgaW50IF9fbWF5YmVfdW51c2VkIGF0bWVs X2ZsZXhjb21fcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiArc3RhdGljIGludCBfX21heWJl X3VudXNlZCBhdG1lbF9mbGV4Y29tX3Jlc3VtZV9ub2lycShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4g IHsKPiAgCXN0cnVjdCBhdG1lbF9mbGV4Y29tICpkZGF0YSA9IGRldl9nZXRfZHJ2ZGF0YShkZXYp Owo+ICAJaW50IGVycjsKPiBAQCAtMTA1LDggKzEwNSw5IEBAIHN0YXRpYyBpbnQgX19tYXliZV91 bnVzZWQgYXRtZWxfZmxleGNvbV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ICAJcmV0dXJu IDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBTSU1QTEVfREVWX1BNX09QUyhhdG1lbF9mbGV4Y29tX3Bt X29wcywgTlVMTCwKPiAtCQkJIGF0bWVsX2ZsZXhjb21fcmVzdW1lKTsKPiArc3RhdGljIGNvbnN0 IHN0cnVjdCBkZXZfcG1fb3BzIGF0bWVsX2ZsZXhjb21fcG1fb3BzID0gewo+ICsJLnJlc3VtZV9u b2lycSA9IGF0bWVsX2ZsZXhjb21fcmVzdW1lX25vaXJxLAoKRG9lc24ndCB0aGlzIG1lYW4geW91 IGNhbiByZW1vdmUgX19tYXliZV91bnVzZWQ/Cgo+ICt9Owo+ICAKPiAgc3RhdGljIHN0cnVjdCBw bGF0Zm9ybV9kcml2ZXIgYXRtZWxfZmxleGNvbV9kcml2ZXIgPSB7Cj4gIAkucHJvYmUJPSBhdG1l bF9mbGV4Y29tX3Byb2JlLAoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpQcmluY2lwYWwgVGVj aG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3Vy Y2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRl ciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK