From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201
Date: Mon, 10 Jan 2022 18:01:08 +0200 [thread overview]
Message-ID: <YdxYRGHhJ8l/5+kx@intel.com> (raw)
In-Reply-To: <20220104184857.784563-1-jani.nikula@intel.com>
On Tue, Jan 04, 2022 at 08:48:56PM +0200, Jani Nikula wrote:
> DP_SINK_COUNT_ESI and DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 have the same
> contents as DP_SINK_COUNT and DP_DEVICE_SERVICE_IRQ_VECTOR,
> respectively.
IIRC there was an oversight in the earlier spec revisions that
showed bit 7 as reserved for one of the locations. But looks like
that got fixed.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_dp_helper.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 30359e434c3f..98d020835b49 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1038,11 +1038,8 @@ struct drm_panel;
> #define DP_SIDEBAND_MSG_UP_REQ_BASE 0x1600 /* 1.2 MST */
>
> /* DPRX Event Status Indicator */
> -#define DP_SINK_COUNT_ESI 0x2002 /* 1.2 */
> -/* 0-5 sink count */
> -# define DP_SINK_COUNT_CP_READY (1 << 6)
> -
> -#define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 0x2003 /* 1.2 */
> +#define DP_SINK_COUNT_ESI 0x2002 /* same as 0x200 */
> +#define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 0x2003 /* same as 0x201 */
>
> #define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI1 0x2004 /* 1.2 */
> # define DP_RX_GTC_MSTR_REQ_STATUS_CHANGE (1 << 0)
> --
> 2.30.2
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-01-10 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 18:48 [PATCH 1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201 Jani Nikula
2022-01-04 18:48 ` [Intel-gfx] " Jani Nikula
2022-01-04 18:48 ` [PATCH 2/2] drm/mst: use DP_GET_SINK_COUNT() for sink count in ESI Jani Nikula
2022-01-04 18:48 ` [Intel-gfx] " Jani Nikula
2022-01-10 16:01 ` Ville Syrjälä
2022-01-04 20:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201 Patchwork
2022-01-04 20:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-01-10 16:01 ` Ville Syrjälä [this message]
2022-01-11 15:51 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula
2022-01-11 10:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201 (rev2) Patchwork
2022-01-11 11:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-11 15:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdxYRGHhJ8l/5+kx@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.