From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23BE3C433EF for ; Mon, 10 Jan 2022 17:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238405AbiAJRfh (ORCPT ); Mon, 10 Jan 2022 12:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238135AbiAJRfh (ORCPT ); Mon, 10 Jan 2022 12:35:37 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EED64C061748 for ; Mon, 10 Jan 2022 09:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oboNtAoUWLsyeVM8PpifuWGTYIwJBQfehNw83Vmr4u4=; b=o3SuQnzYKLWCP49KiDSN7cSWhI oFTrYYBIWlIumONVPRJwznFC8bUwFzlJdMwQI8gFd3gYh4H7GlZ60Gdp4/zRDLG3JWRKvtXiBwJOr Fo7QEYGmq5SMCjc7/VWuBRlwThdzM5w6xvLBxfSV2ygqX1lA2aik/ciy57yzN/wRd+a8r9yADyNSN MAU5X57Jb0NVmEkbRAv9UyYl4GIsOwev6TICiM4N725sibLSYZeE/7ScqnOEwXv5pYcvSVxYCeTSZ FWQkfXiMOxL+RmAiLuUwKtAzpSJhLJuhzaXmViahkQgRRS0Glg3Upl++wOKjsWqRUzy6AVqLRelXq 5Cxhys8Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6yZm-00CacX-H0; Mon, 10 Jan 2022 17:35:22 +0000 Date: Mon, 10 Jan 2022 09:35:22 -0800 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Mike Snitzer , linux-block@vger.kernel.org, dm-devel@redhat.com, lining , Tejun Heo , Chunguang Xu Subject: Re: [PATCH 1/2] block: add resubmit_bio_noacct() Message-ID: References: <20220110075141.389532-1-ming.lei@redhat.com> <20220110075141.389532-2-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110075141.389532-2-ming.lei@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jan 10, 2022 at 03:51:40PM +0800, Ming Lei wrote: > Add block layer API of resubmit_bio_noacct() for handling blk-throttle > iops limit correctly. Typical use case is that bio split, and it isn't > good to export blk_throtl_charge_bio_split() for drivers, so add new API > for serving such purpose. Umm, submit_bio_noacct is meant exactly for this case of resubmitting a bio. We should not need another API for that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C8BFC433F5 for ; Mon, 10 Jan 2022 18:52:20 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-EDKz_I0nN7CGgt2W1d0SWQ-1; Mon, 10 Jan 2022 13:52:17 -0500 X-MC-Unique: EDKz_I0nN7CGgt2W1d0SWQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D93FA81EE61; Mon, 10 Jan 2022 18:52:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE43F7FBA7; Mon, 10 Jan 2022 18:52:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2EFD51809CB8; Mon, 10 Jan 2022 18:52:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20AIq6nb000843 for ; Mon, 10 Jan 2022 13:52:07 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0E9F61121322; Mon, 10 Jan 2022 18:52:06 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AD991121321 for ; Mon, 10 Jan 2022 18:52:03 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1200A1C093C5 for ; Mon, 10 Jan 2022 18:52:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-JvTgw76bMCqPPepzhEHtnw-1; Mon, 10 Jan 2022 13:51:59 -0500 X-MC-Unique: JvTgw76bMCqPPepzhEHtnw-1 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6yZm-00CacX-H0; Mon, 10 Jan 2022 17:35:22 +0000 Date: Mon, 10 Jan 2022 09:35:22 -0800 From: Christoph Hellwig To: Ming Lei Message-ID: References: <20220110075141.389532-1-ming.lei@redhat.com> <20220110075141.389532-2-ming.lei@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220110075141.389532-2-ming.lei@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Mike Snitzer , linux-block@vger.kernel.org, dm-devel@redhat.com, lining , Tejun Heo , Chunguang Xu Subject: Re: [dm-devel] [PATCH 1/2] block: add resubmit_bio_noacct() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jan 10, 2022 at 03:51:40PM +0800, Ming Lei wrote: > Add block layer API of resubmit_bio_noacct() for handling blk-throttle > iops limit correctly. Typical use case is that bio split, and it isn't > good to export blk_throtl_charge_bio_split() for drivers, so add new API > for serving such purpose. Umm, submit_bio_noacct is meant exactly for this case of resubmitting a bio. We should not need another API for that. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel