All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: wenyehai <wenyehai@huawei.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP]  答复:  [PATCH] add several hash algorithms for crypto/crypto_user02.c
Date: Mon, 10 Jan 2022 09:44:19 -0800	[thread overview]
Message-ID: <Ydxwc65JO2C057hm@sol.localdomain> (raw)
In-Reply-To: <0035845766004452880d56963135c616@huawei.com>

On Mon, Jan 10, 2022 at 03:59:39AM +0000, wenyehai wrote:
> Hi Eric:
> 
> 
> 
> Thank you very much for your kind reply, and I am very sorry for not
> describing the background clearly.
> 
> 
> 
> Actually, I wanted to test the sha3 algorithm in kernel 5.10, but
> crypto_user02.c return "no viable algorithm found" as follows:
> 
> 
> 
> [cid:image001.png@01D80618.14306F90]
> 
> 
> 
> So I add sha3 to crypto_user02.c and run again, at the same time, according to
> the latest linux kernel encryption module, add several hash algorithms, as
> follows:
> 
> 
> 
> [cid:image002.png@01D80618.F702D790]

[For compatibility with the mailing list, please use plain text email without
images -- thanks!]

I still don't understand exactly what you're trying to do.  If you're just
trying to get crypto_user02 to run in more cases, then your patch makes sense.
If on the other hand you're actually trying to get the kernel to instantiate
more algorithms so that their in-kernel self-tests are run, that is *not* the
purpose of crypto_user02; a new test should be written for that purpose.  The
test could try to instantiate all algorithms which have in-kernel self-tests.

- Eric

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-01-10 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04  9:15 [LTP] [PATCH] add several hash algorithms for crypto/crypto_user02.c wenyehai via ltp
2022-01-05 15:13 ` Eric Biggers
2022-01-10  3:59   ` [LTP] 答复: " wenyehai via ltp
2022-01-10 17:44     ` Eric Biggers [this message]
2022-01-11  2:19       ` [LTP] 答复: " wenyehai via ltp
2022-01-11  3:03         ` Eric Biggers
2022-01-11  3:11           ` [LTP] 答复: " wenyehai via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ydxwc65JO2C057hm@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=wenyehai@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.