From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F2A8C433EF for ; Mon, 10 Jan 2022 18:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242535AbiAJSxw (ORCPT ); Mon, 10 Jan 2022 13:53:52 -0500 Received: from sin.source.kernel.org ([145.40.73.55]:33890 "EHLO sin.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239168AbiAJSxu (ORCPT ); Mon, 10 Jan 2022 13:53:50 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5159CCE16C4; Mon, 10 Jan 2022 18:53:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EA0CC36AE3; Mon, 10 Jan 2022 18:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641840827; bh=u6uaLdOge181QgZ/WBbSjT4alS+LdP4sDloYENcqsnI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLUoK6Em10PO+uF0VZvOZcLRrNS2V7xbv+Y6DUmP7cxExszqYfEKe7/eRYvl9Mijg dvlf+bUpKSimfPwvgQ/qyxiGog2Y6xJt9LZfJ1aoU8UAVxIis0FeJZphjj4cIxg5H4 7sjR9Kk14EdunSP2Au51ZORxJV9MyFOuENkfHFlaKoXXhXvl3BvvkFkzuE6cOaaNgl Ptj4PUY72DmFFgWnAHC8Cui1oeHiPev1H87Hd/G5SLllHbeTzYm3CTG1+3qspApZoG 8VFOPtLbw/957MugwQ2QQ+YkRWr5i//PGtBgJRIP1Rqcxad8UQTwQrcLE/m8jk0L6O WCFVdih47ch7Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E624140B92; Mon, 10 Jan 2022 15:53:45 -0300 (-03) Date: Mon, 10 Jan 2022 15:53:45 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Andi Kleen , Jiri Olsa , Namhyung Kim , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com, eranian@google.com Subject: Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu. Message-ID: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-3-irogers@google.com> <57ab982e-ecc1-3f49-c580-0a251e29698b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 10, 2022 at 03:52:11PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jan 10, 2022 at 09:36:49AM -0800, Ian Rogers escreveu: > > On Mon, Jan 10, 2022 at 9:10 AM John Garry wrote: > > > > > > On 05/01/2022 06:13, Ian Rogers wrote: > > > > > > > > +struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx, > > > > + void *data) > > > > +{ > > > > + if (idx < 0 || idx > map->nr) > > > > + return cpu_map__empty_aggr_cpu_id(); > > > > + > > > > + return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data); > > > > +} > > > > + > > > > > > > > > This is later deleted in the series. Can the series be reworked so that > > > we don't add stuff and then later delete it? One reason for that > > > approach is that we don't spend time reviewing something which will be > > > deleted, especially in such a big series... > > > > Hi John, > > > > I think you are asking to squash: > > https://lore.kernel.org/lkml/20220105061351.120843-8-irogers@google.com/ > > into this change. There are other similar related changes that may > > also be squashed. The changes are trying to introduce a new API and > > then add changes to switch over to using it. This is with a view to > > making bisection easier, have each change only do 1 thing and so on. I > > believe the format of the patches is house style, but it is fine to > > squash changes together too. Having sent patches to Arnaldo and having > > had them split I'm reluctant to do a v5 with them squashed without him > > expressing a preference. > > Right, sometimes this is needed, I'm getting the patchkit now to test > build it in my containers and will go patch by patch reviewing. Good start: ⬢[acme@toolbox perf]$ b4 am -ctsl --cc-trailers CAP-5=fWT_19OfZTTjvLUcChV4nDwqc5Zq4VE93Gak6OO4NORsA@mail.gmail.com Looking up https://lore.kernel.org/r/CAP-5%3DfWT_19OfZTTjvLUcChV4nDwqc5Zq4VE93Gak6OO4NORsA%40mail.gmail.com Grabbing thread from lore.kernel.org/all/CAP-5%3DfWT_19OfZTTjvLUcChV4nDwqc5Zq4VE93Gak6OO4NORsA%40mail.gmail.com/t.mbox.gz Checking for newer revisions on https://lore.kernel.org/all/ Analyzing 58 messages in the thread Checking attestation on all messages, may take a moment... --- ✓ [PATCH v4 1/48] libperf: Add comments to perf_cpu_map. + Reviewed-by: John Garry + Signed-off-by: Arnaldo Carvalho de Melo + Link: https://lore.kernel.org/r/20220105061351.120843-2-irogers@google.com Cover: ./v4_20220104_irogers_refactor_perf_cpumap.cover Link: https://lore.kernel.org/r/20220105061351.120843-1-irogers@google.com Base: applies clean to current tree git checkout -b v4_20220104_irogers_google_com HEAD git am ./v4_20220104_irogers_refactor_perf_cpumap.mbx :-) - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E69BCC433EF for ; Mon, 10 Jan 2022 18:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UpAdtHE47vHn0l+2d1zWXQNK1sWwyNVW/VsBvYvYG48=; b=2pdC+b+ir6mPBg oisWMI3ek+k3pgNuAKlCdMGlcjmlNPLk+8PcPIsCJzN+dscAH2JJB4QQVi7q4hVUr1oC3VnM8V1Of mGWLEancJiQ1sWPrRJISeXo4F5ky27RYFGUNSchuC49jXiJ3K+bSWYPmLJYhPc+l0s12OENXKTN2j qA6MBSnRjsTqwFjhjOI48Yt6D/NAu6dNyfVJtfgo2psTwdll8EtCWFpdb/2dvWBHc27qQitBf/O+T prCNTJzYHY9SMg1d+Eq5x4Vj5IIs4QQBjRZGGDJwyZm7UKZUeXDbOz8Gr7if5iboSuiPGVrZ/jTnE TUx6COHA5pmw7sVlUDdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6znk-00CsBb-0b; Mon, 10 Jan 2022 18:53:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zni-00CsB9-4G for linux-arm-kernel@bombadil.infradead.org; Mon, 10 Jan 2022 18:53:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=li2DH9PPv/qGHy+PbpFJWPC7UT1n87bwNe5a+JnFxTs=; b=QH7JPJgF+y9mjv8rOr60KbkYgA m/tLSPeyinTKbmlC9fKadcLz0sw3HITw5v0lAwPgA9gZW638xhNwatkjlHIlO+tTxrOjFZ9Ym8LTv LEcm5lnpitjuK1eurQ/tsqaeUbiprcKcDlFPWunccO6QtVn3ygX6z+eFuFUXfG4j7XdhJ6s1f+qvM bLEC58lokmrTG+YxK8wj38P1h+p1muzDVTNCLVAzCl+MEyfBL26KLnat1LZL7iTAtVCOMDZWZ5lD2 3YOvU7yfQkEhV1xJkCEk/vITI0S63YW6mcRGKpkG0j2ztj+azesdTV4l0Q5pLcnkl/6Y9vMyQhjHt UoLr5z8w==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zng-000ROe-CR; Mon, 10 Jan 2022 18:53:48 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E624140B92; Mon, 10 Jan 2022 15:53:45 -0300 (-03) Date: Mon, 10 Jan 2022 15:53:45 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Andi Kleen , Jiri Olsa , Namhyung Kim , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com, eranian@google.com Subject: Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu. Message-ID: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-3-irogers@google.com> <57ab982e-ecc1-3f49-c580-0a251e29698b@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gTW9uLCBKYW4gMTAsIDIwMjIgYXQgMDM6NTI6MTFQTSAtMDMwMCwgQXJuYWxkbyBDYXJ2YWxo byBkZSBNZWxvIGVzY3JldmV1Ogo+IEVtIE1vbiwgSmFuIDEwLCAyMDIyIGF0IDA5OjM2OjQ5QU0g LTA4MDAsIElhbiBSb2dlcnMgZXNjcmV2ZXU6Cj4gPiBPbiBNb24sIEphbiAxMCwgMjAyMiBhdCA5 OjEwIEFNIEpvaG4gR2FycnkgPGpvaG4uZ2FycnlAaHVhd2VpLmNvbT4gd3JvdGU6Cj4gPiA+Cj4g PiA+IE9uIDA1LzAxLzIwMjIgMDY6MTMsIElhbiBSb2dlcnMgd3JvdGU6Cj4gPiA+ID4KPiA+ID4g PiArc3RydWN0IGFnZ3JfY3B1X2lkIGNwdV9tYXBfX2dldF9zb2NrZXQoc3RydWN0IHBlcmZfY3B1 X21hcCAqbWFwLCBpbnQgaWR4LAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB2b2lkICpkYXRhKQo+ID4gPiA+ICt7Cj4gPiA+ID4gKyAgICAgaWYgKGlkeCA8IDAg fHwgaWR4ID4gbWFwLT5ucikKPiA+ID4gPiArICAgICAgICAgICAgIHJldHVybiBjcHVfbWFwX19l bXB0eV9hZ2dyX2NwdV9pZCgpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICByZXR1cm4gY3B1X21h cF9fZ2V0X3NvY2tldF9hZ2dyX2J5X2NwdShtYXAtPm1hcFtpZHhdLCBkYXRhKTsKPiA+ID4gPiAr fQo+ID4gPiA+ICsKPiA+ID4KPiA+ID4KPiA+ID4gVGhpcyBpcyBsYXRlciBkZWxldGVkIGluIHRo ZSBzZXJpZXMuIENhbiB0aGUgc2VyaWVzIGJlIHJld29ya2VkIHNvIHRoYXQKPiA+ID4gd2UgZG9u J3QgYWRkIHN0dWZmIGFuZCB0aGVuIGxhdGVyIGRlbGV0ZSBpdD8gT25lIHJlYXNvbiBmb3IgdGhh dAo+ID4gPiBhcHByb2FjaCBpcyB0aGF0IHdlIGRvbid0IHNwZW5kIHRpbWUgcmV2aWV3aW5nIHNv bWV0aGluZyB3aGljaCB3aWxsIGJlCj4gPiA+IGRlbGV0ZWQsIGVzcGVjaWFsbHkgaW4gc3VjaCBh IGJpZyBzZXJpZXMuLi4KPiA+IAo+ID4gSGkgSm9obiwKPiA+IAo+ID4gSSB0aGluayB5b3UgYXJl IGFza2luZyB0byBzcXVhc2g6Cj4gPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMjIw MTA1MDYxMzUxLjEyMDg0My04LWlyb2dlcnNAZ29vZ2xlLmNvbS8KPiA+IGludG8gdGhpcyBjaGFu Z2UuIFRoZXJlIGFyZSBvdGhlciAgc2ltaWxhciByZWxhdGVkIGNoYW5nZXMgdGhhdCBtYXkKPiA+ IGFsc28gYmUgc3F1YXNoZWQuIFRoZSBjaGFuZ2VzIGFyZSB0cnlpbmcgdG8gaW50cm9kdWNlIGEg bmV3IEFQSSBhbmQKPiA+IHRoZW4gYWRkIGNoYW5nZXMgdG8gc3dpdGNoIG92ZXIgdG8gdXNpbmcg aXQuIFRoaXMgaXMgd2l0aCBhIHZpZXcgdG8KPiA+IG1ha2luZyBiaXNlY3Rpb24gZWFzaWVyLCBo YXZlIGVhY2ggY2hhbmdlIG9ubHkgZG8gMSB0aGluZyBhbmQgc28gb24uIEkKPiA+IGJlbGlldmUg dGhlIGZvcm1hdCBvZiB0aGUgcGF0Y2hlcyBpcyBob3VzZSBzdHlsZSwgYnV0IGl0IGlzIGZpbmUg dG8KPiA+IHNxdWFzaCBjaGFuZ2VzIHRvZ2V0aGVyIHRvby4gSGF2aW5nIHNlbnQgcGF0Y2hlcyB0 byBBcm5hbGRvIGFuZCBoYXZpbmcKPiA+IGhhZCB0aGVtIHNwbGl0IEknbSByZWx1Y3RhbnQgdG8g ZG8gYSB2NSB3aXRoIHRoZW0gc3F1YXNoZWQgd2l0aG91dCBoaW0KPiA+IGV4cHJlc3NpbmcgYSBw cmVmZXJlbmNlLgo+IAo+IFJpZ2h0LCBzb21ldGltZXMgdGhpcyBpcyBuZWVkZWQsIEknbSBnZXR0 aW5nIHRoZSBwYXRjaGtpdCBub3cgdG8gdGVzdAo+IGJ1aWxkIGl0IGluIG15IGNvbnRhaW5lcnMg YW5kIHdpbGwgZ28gcGF0Y2ggYnkgcGF0Y2ggcmV2aWV3aW5nLgoKR29vZCBzdGFydDoKCuKsolth Y21lQHRvb2xib3ggcGVyZl0kIGI0IGFtIC1jdHNsIC0tY2MtdHJhaWxlcnMgQ0FQLTU9ZldUXzE5 T2ZaVFRqdkxVY0NoVjRuRHdxYzVacTRWRTkzR2FrNk9PNE5PUnNBQG1haWwuZ21haWwuY29tCkxv b2tpbmcgdXAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci9DQVAtNSUzRGZXVF8xOU9mWlRUanZM VWNDaFY0bkR3cWM1WnE0VkU5M0dhazZPTzROT1JzQSU0MG1haWwuZ21haWwuY29tCkdyYWJiaW5n IHRocmVhZCBmcm9tIGxvcmUua2VybmVsLm9yZy9hbGwvQ0FQLTUlM0RmV1RfMTlPZlpUVGp2TFVj Q2hWNG5Ed3FjNVpxNFZFOTNHYWs2T080Tk9Sc0ElNDBtYWlsLmdtYWlsLmNvbS90Lm1ib3guZ3oK Q2hlY2tpbmcgZm9yIG5ld2VyIHJldmlzaW9ucyBvbiBodHRwczovL2xvcmUua2VybmVsLm9yZy9h bGwvCkFuYWx5emluZyA1OCBtZXNzYWdlcyBpbiB0aGUgdGhyZWFkCkNoZWNraW5nIGF0dGVzdGF0 aW9uIG9uIGFsbCBtZXNzYWdlcywgbWF5IHRha2UgYSBtb21lbnQuLi4KLS0tCiAg4pyTIFtQQVRD SCB2NCAxLzQ4XSBsaWJwZXJmOiBBZGQgY29tbWVudHMgdG8gcGVyZl9jcHVfbWFwLgogICAgKyBS ZXZpZXdlZC1ieTogSm9obiBHYXJyeSA8am9obi5nYXJyeUBodWF3ZWkuY29tPgogICAgKyBTaWdu ZWQtb2ZmLWJ5OiBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8gPGFjbWVAcmVkaGF0LmNvbT4KICAg ICsgTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci8yMDIyMDEwNTA2MTM1MS4xMjA4NDMt Mi1pcm9nZXJzQGdvb2dsZS5jb20KPEJJRyBTTklQPgpDb3ZlcjogLi92NF8yMDIyMDEwNF9pcm9n ZXJzX3JlZmFjdG9yX3BlcmZfY3B1bWFwLmNvdmVyCiBMaW5rOiBodHRwczovL2xvcmUua2VybmVs Lm9yZy9yLzIwMjIwMTA1MDYxMzUxLjEyMDg0My0xLWlyb2dlcnNAZ29vZ2xlLmNvbQogQmFzZTog YXBwbGllcyBjbGVhbiB0byBjdXJyZW50IHRyZWUKICAgICAgIGdpdCBjaGVja291dCAtYiB2NF8y MDIyMDEwNF9pcm9nZXJzX2dvb2dsZV9jb20gSEVBRAogICAgICAgZ2l0IGFtIC4vdjRfMjAyMjAx MDRfaXJvZ2Vyc19yZWZhY3Rvcl9wZXJmX2NwdW1hcC5tYngKCjotKQoKLSBBcm5hbGRvCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==