All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: ycaibb <ycaibb@gmail.com>
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, kafai@fb.com, songliubraving@fb.com,
	yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [PATCH] inet: missing lock releases in udp.c
Date: Sun, 23 Jan 2022 11:57:43 -0800	[thread overview]
Message-ID: <Ye2zN0R/R9uKEUNa@pop-os.localdomain> (raw)
In-Reply-To: <20220121031553.5342-1-ycaibb@gmail.com>

On Fri, Jan 21, 2022 at 11:15:53AM +0800, ycaibb wrote:
> From: Ryan Cai <ycaibb@gmail.com>
> 
> In method udp_get_first, the lock hslot->lock is not released when afinfo->family == AF_UNSPEC || sk->sk_family == afinfo->family is true. This patch fixes the problem by adding the unlock statement.
> 

It should be unlocked by udp_seq_stop(). Do you see any real lockdep
warning or bug report?

Thanks.

  parent reply	other threads:[~2022-01-23 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21  3:15 [PATCH] inet: missing lock releases in udp.c ycaibb
2022-01-21  6:26 ` kernel test robot
2022-01-21  6:26   ` kernel test robot
2022-01-23  7:11 ` [inet] 1b84613d30: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip kernel test robot
2022-01-23  7:11   ` kernel test robot
2022-01-23 19:57 ` Cong Wang [this message]
2022-01-21 21:13 [PATCH] inet: missing lock releases in udp.c kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye2zN0R/R9uKEUNa@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=ycaibb@gmail.com \
    --cc=yhs@fb.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.