From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D83C433FE for ; Mon, 24 Jan 2022 15:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238881AbiAXP60 (ORCPT ); Mon, 24 Jan 2022 10:58:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237340AbiAXP6Y (ORCPT ); Mon, 24 Jan 2022 10:58:24 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B088C06173D for ; Mon, 24 Jan 2022 07:58:24 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id z22so57182132edd.12 for ; Mon, 24 Jan 2022 07:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=4nWlje6hEWftLkmYh7UZghhd768mUQlCbDsNDXVtRqI=; b=J5y+pelekVRPrBjgpqHY48R3nd2xvpjQHruu5xm059Q4IG+KseEGv+JCWZC4DdyyQZ LOMCsaxnv/q3tb2Zkae3NmRqJATgzdqG+TVPOwyIbaWHDpQaBOeVjW5CAGIbzq7b8gz3 ZtVZduChtO5k5JI2uY2dRDw3hqg5u/uERchW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=4nWlje6hEWftLkmYh7UZghhd768mUQlCbDsNDXVtRqI=; b=FRcRE03N0oJG9n1FQCR9YzkLKOFCl51PRi/gZNNJJcNRC0mpqN/oB6nhG1tFuy5zaH Gzm4F7KAnNh5Ou6bM2YGDq9P8Y2SBHhUDwnHr8GYEITUR+/ZwqS8FUz5TjhrGcduApPF bDBljpPzzDx3fK4gW7ksurkOB8fbPXGcQE/rArxmZWgWs2G2+cXNC2KqTBt2LdCBN/hJ +0eBRCTanpDK5pgyIxFupBdqnC1FB+lFPenhwo9HVReqoBVCOkULxIT/Hluqi0AVZJ+q 6Qsun+xTFGUi/e7Ubz6D7rLdKzTzZG4EAqZDEKSLWKzXGV4lV06tmEK7QwUJ2X9WJ2It 7W+A== X-Gm-Message-State: AOAM531Fv3a9pKioS7Ez8gtHdVNCT/DHGUBChP6JF24UYyHaJSRvhb9y K0B90TQCQkTX4NPyuP0fJgHpUQ== X-Google-Smtp-Source: ABdhPJxBcAp+wHHeVIPr1OYBq3V8XRus1POAoPs7MtC4E082B+GMR3KGFFoUO4WrJ2lRKdlRLfAa3w== X-Received: by 2002:a05:6402:1764:: with SMTP id da4mr16458148edb.189.1643039902624; Mon, 24 Jan 2022 07:58:22 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h20sm6452616eds.9.2022.01.24.07.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 07:58:22 -0800 (PST) Date: Mon, 24 Jan 2022 16:58:20 +0100 From: Daniel Vetter To: Helge Deller Cc: Javier Martinez Canillas , Thomas Zimmermann , Gerd Hoffmann , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Sven Schnelle , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Linus Torvalds , Tomi Valkeinen , Claudio Suarez , Pavel Machek , Daniel Vetter , Geert Uytterhoeven , Sam Ravnborg Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Message-ID: Mail-Followup-To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Gerd Hoffmann , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Sven Schnelle , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Linus Torvalds , Tomi Valkeinen , Claudio Suarez , Pavel Machek , Daniel Vetter , Geert Uytterhoeven , Sam Ravnborg References: <20220119110839.33187-1-deller@gmx.de> <20220119110839.33187-3-deller@gmx.de> <6c000477-002b-d125-b945-2c4831bad8a5@gmx.de> <20220121072006.ylw2hdl7jbkbwnre@sirius.home.kraxel.org> <64fd46cb-9746-3fd0-ec92-c64dba76875a@gmx.de> <2fc200bb-4b40-7833-31c9-90a78512b601@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 24, 2022 at 04:29:34PM +0100, Helge Deller wrote: > On 1/24/22 12:50, Javier Martinez Canillas wrote: > > On 1/24/22 12:33, Thomas Zimmermann wrote: > > > > [snip] > > > >>> Thoughts? > >> > >> I can't say I approve keeping fbdev alive, but... > >> > >> With fbdev emulation, every DRM driver is an fbdev driver too. So > >> CONFIG_FB_DRIVER is somewhat misleading. Better add an option like > >> CONFIG_FBCON_HW_SCROLLING and have it selected by the fbdev drivers that > >> absolutely need HW acceleration. That option would then protect the rsp > >> code. > > I'm not a fan of something like CONFIG_FBCON_HW_SCROLLING, but I'm not > against it either. > For me it sounds that this is not the real direction you want to go, > which is to prevent that any other drivers take the framebuffer before > you take it with simpledrm or similiar. > CONFIG_FBCON_HW_SCROLLING IMHO just disables the (from your POV) neglectable accleration part. > With an option like CONFIG_FB_DRIVER (maybe better: CONFIG_FB_LEGACY_DRIVERS) > it's an easy option for distros to disable all of the legacy drivers > from being built & shipped. > > Instead of CONFIG_FBCON_HW_SCROLLING we could also choose > CONFIG_FBCON_LEGACY_ACCELERATION, because it includes fillrect() as well... +1 on that name, since on the lwn discussions I've also seen some noise about resurrecting scrollback. And I guess we could do that too and then just add it all behind that same option. -Daniel > > Agreed that this option would be better and allow distros > > to disable the code that was reverted. > > Yes, but IMHO it doesn't hurt either to leave it in. > It doesn't break anything at least. > Anyway... > > Helge -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78FA5C433EF for ; Mon, 24 Jan 2022 15:58:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FC8510E217; Mon, 24 Jan 2022 15:58:25 +0000 (UTC) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32FCD10E217 for ; Mon, 24 Jan 2022 15:58:24 +0000 (UTC) Received: by mail-ed1-x52f.google.com with SMTP id j2so57242891edj.8 for ; Mon, 24 Jan 2022 07:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=4nWlje6hEWftLkmYh7UZghhd768mUQlCbDsNDXVtRqI=; b=J5y+pelekVRPrBjgpqHY48R3nd2xvpjQHruu5xm059Q4IG+KseEGv+JCWZC4DdyyQZ LOMCsaxnv/q3tb2Zkae3NmRqJATgzdqG+TVPOwyIbaWHDpQaBOeVjW5CAGIbzq7b8gz3 ZtVZduChtO5k5JI2uY2dRDw3hqg5u/uERchW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=4nWlje6hEWftLkmYh7UZghhd768mUQlCbDsNDXVtRqI=; b=xh8QC9PaU9jogZ6VUweKTDu2V9R9VBLgMqEA863r5ID1E/7J6s1QJoCk+hLv+fz1Qy tDyKmv1Dlnn5ioBMc4n6UvNYZwHPp2s72cPClCFapHi6/b/+o/o/qEDGIhWnFQAS/wuI EWD9mTc4dB6ji5ntBlwxSl5Sfux2Wk3WYRimdelw4g8pcj1hPmxpRg/TLUdY4lu+iiWL ns0YbEcItZCqaLrXHmBcTf7Us80zewPO9zZ1pGhY/a4nKe6djNgRwNgGdVvywRzzQh8l nZ76tDvvvpX/9pohXuNf7egz/AHx8sqZCjtRJcUyKWfPo1ke3TWiavMUaBGVII2ljjXC GIjA== X-Gm-Message-State: AOAM530twBxcUF5RNBSsgTYyDcK4vXrZ3eswD0sUzA4rBccaXj9CzB0E lPjRXnOiRZeQ3EbkTGH8I9iACw== X-Google-Smtp-Source: ABdhPJxBcAp+wHHeVIPr1OYBq3V8XRus1POAoPs7MtC4E082B+GMR3KGFFoUO4WrJ2lRKdlRLfAa3w== X-Received: by 2002:a05:6402:1764:: with SMTP id da4mr16458148edb.189.1643039902624; Mon, 24 Jan 2022 07:58:22 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h20sm6452616eds.9.2022.01.24.07.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 07:58:22 -0800 (PST) Date: Mon, 24 Jan 2022 16:58:20 +0100 From: Daniel Vetter To: Helge Deller Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Message-ID: Mail-Followup-To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Gerd Hoffmann , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Sven Schnelle , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Linus Torvalds , Tomi Valkeinen , Claudio Suarez , Pavel Machek , Daniel Vetter , Geert Uytterhoeven , Sam Ravnborg References: <20220119110839.33187-1-deller@gmx.de> <20220119110839.33187-3-deller@gmx.de> <6c000477-002b-d125-b945-2c4831bad8a5@gmx.de> <20220121072006.ylw2hdl7jbkbwnre@sirius.home.kraxel.org> <64fd46cb-9746-3fd0-ec92-c64dba76875a@gmx.de> <2fc200bb-4b40-7833-31c9-90a78512b601@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Pavel Machek , Sam Ravnborg , Greg Kroah-Hartman , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Linus Torvalds , Geert Uytterhoeven , Tomi Valkeinen , Claudio Suarez , Gerd Hoffmann , Thomas Zimmermann , Daniel Vetter , Sven Schnelle Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 24, 2022 at 04:29:34PM +0100, Helge Deller wrote: > On 1/24/22 12:50, Javier Martinez Canillas wrote: > > On 1/24/22 12:33, Thomas Zimmermann wrote: > > > > [snip] > > > >>> Thoughts? > >> > >> I can't say I approve keeping fbdev alive, but... > >> > >> With fbdev emulation, every DRM driver is an fbdev driver too. So > >> CONFIG_FB_DRIVER is somewhat misleading. Better add an option like > >> CONFIG_FBCON_HW_SCROLLING and have it selected by the fbdev drivers that > >> absolutely need HW acceleration. That option would then protect the rsp > >> code. > > I'm not a fan of something like CONFIG_FBCON_HW_SCROLLING, but I'm not > against it either. > For me it sounds that this is not the real direction you want to go, > which is to prevent that any other drivers take the framebuffer before > you take it with simpledrm or similiar. > CONFIG_FBCON_HW_SCROLLING IMHO just disables the (from your POV) neglectable accleration part. > With an option like CONFIG_FB_DRIVER (maybe better: CONFIG_FB_LEGACY_DRIVERS) > it's an easy option for distros to disable all of the legacy drivers > from being built & shipped. > > Instead of CONFIG_FBCON_HW_SCROLLING we could also choose > CONFIG_FBCON_LEGACY_ACCELERATION, because it includes fillrect() as well... +1 on that name, since on the lwn discussions I've also seen some noise about resurrecting scrollback. And I guess we could do that too and then just add it all behind that same option. -Daniel > > Agreed that this option would be better and allow distros > > to disable the code that was reverted. > > Yes, but IMHO it doesn't hurt either to leave it in. > It doesn't break anything at least. > Anyway... > > Helge -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch